id,node_id,number,title,user,state,locked,assignee,milestone,comments,created_at,updated_at,closed_at,author_association,active_lock_reason,draft,pull_request,body,reactions,performed_via_github_app,state_reason,repo,type 89180768,MDU6SXNzdWU4OTE4MDc2OA==,437,bit of code missing in documentation (http://xray.readthedocs.org/en/latest/io.html#combining-multiple-files),2539828,closed,0,,1172685,1,2015-06-18T02:34:08Z,2015-06-22T15:44:59Z,2015-06-22T15:44:59Z,NONE,,,,"in [http://xray.readthedocs.org/en/latest/io.html#combining-multiple-files](http://xray.readthedocs.org/en/latest/io.html#combining-multiple-files) there is a bit of code missing in the function `read_netcdfs`: instead of: ``` def read_netcdfs(files, dim, transform_func=None): def process_one_path(path): # use a context manager, to ensure the file gets closed after use with xray.open_dataset(path) as ds: # transform_func should do some sort of selection or # aggregation if transform_func is not None: ds = transform_func(ds) # load all data from the transformed dataset, to ensure we can # use it after closing each original file ds.load() return ds paths = sorted(glob(files)) datasets = [process_one_path(p) for p in paths] xray.concat(datasets, dim) ``` it should be: ``` def read_netcdfs(files, dim, transform_func=None): def process_one_path(path): # use a context manager, to ensure the file gets closed after use with xray.open_dataset(path) as ds: # transform_func should do some sort of selection or # aggregation if transform_func is not None: ds = transform_func(ds) # load all data from the transformed dataset, to ensure we can # use it after closing each original file ds.load() return ds paths = sorted(glob(files)) datasets = [process_one_path(p) for p in paths] dset = xray.concat(datasets, dim) return dset ``` ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/437/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,13221727,issue