id,node_id,number,title,user,state,locked,assignee,milestone,comments,created_at,updated_at,closed_at,author_association,active_lock_reason,draft,pull_request,body,reactions,performed_via_github_app,state_reason,repo,type
477427854,MDExOlB1bGxSZXF1ZXN0MzA0NzU0OTc2,3187,reduce the size of example dataset in dask docs,868027,closed,0,,,4,2019-08-06T14:50:27Z,2019-08-06T20:41:39Z,2019-08-06T20:41:38Z,CONTRIBUTOR,,0,pydata/xarray/pulls/3187,"Another attempt at getting the docs to build again on RTD (#3182).
The current failure is due to high memory usage in the dask examples. I've converted the two most memory expensive code blocks into `:verbatim:` blocks so they don't use any additional memory. The contents of these blocks were taken from the last time the docs successfully built on RTD","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/3187/reactions"", ""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull
477084478,MDExOlB1bGxSZXF1ZXN0MzA0NDgxOTY3,3186,bump rasterio to 1.0.24 in doc building environment,868027,closed,0,,,2,2019-08-05T22:24:59Z,2019-08-06T01:20:16Z,2019-08-06T01:20:15Z,CONTRIBUTOR,,0,pydata/xarray/pulls/3186,"This is hopefully a fix for #3182 but I wasn't sure how to really test this on read the docs (RTD) itself.
There may be a few things going on:
* Local testing showed removing the ""auto_gallery"" dir would cause the failing gallery examples to actually be recognized as failing (i.e. bust the cache)
* https://github.com/conda-forge/rasterio-feedstock/issues/118 and some examining of the `conda list` output on RTD for led me to think this was a deeper problem. Local testing with a bumped version of rasterio resulted in conda-forge being the channel source (rather than pip?), it also fixed the failing builds which relied on rasterio.","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/3186/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull
476323960,MDExOlB1bGxSZXF1ZXN0MzAzOTAzNjg1,3180,enable sphinx.ext.napoleon,868027,closed,0,,,3,2019-08-02T19:26:46Z,2019-08-02T21:17:43Z,2019-08-02T21:17:43Z,CONTRIBUTOR,,0,pydata/xarray/pulls/3180,"Enables the napoleon extension in sphinx. This will interpret the numpydoc style parameters and types and convert them to sphinx `:param type name:` Note that `sphinx.ext.napoleon` must come before the `numpydoc` extension.
Eventually the numpydoc dependency might be able to be removed but currently removing it makes the wrapped `ufunc` documentation omit the ""parameters"" and ""returns"", see the attached screenshot for what one of these ufuncs looks like with `numpydoc` removed.
- [ ] Closes #3056
","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/3180/reactions"", ""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 1, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull
476317653,MDExOlB1bGxSZXF1ZXN0MzAzODk4NDE4,3179,remove type annotations from autodoc method signatures,868027,closed,0,,,1,2019-08-02T19:07:44Z,2019-08-02T20:17:59Z,2019-08-02T20:17:58Z,CONTRIBUTOR,,0,pydata/xarray/pulls/3179,"This PR removes all the type hints from method signatures generated by sphinx.ext.autodoc. See http://www.sphinx-doc.org/en/master/usage/extensions/autodoc.html#confval-autodoc_typehints
The sphinx documentation doesn't say which version this was added in, but I imagine it is quite recent.
- [ ] Closes #3178","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/3179/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull
354539078,MDExOlB1bGxSZXF1ZXN0MjExMjc3OTMz,2386,fix typo in uri in the docs,868027,closed,0,,,1,2018-08-28T01:46:56Z,2018-08-28T01:49:02Z,2018-08-28T01:48:59Z,CONTRIBUTOR,,0,pydata/xarray/pulls/2386,Seems I left off a trailing `>` in the `whats-new.rst`. Here is a minor fix for that.,"{""url"": ""https://api.github.com/repos/pydata/xarray/issues/2386/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull
345322908,MDExOlB1bGxSZXF1ZXN0MjA0NTA2MTg2,2322,BUG: modify behavior of Dataset.filter_by_attrs to match netCDF4.Data…,868027,closed,0,,,5,2018-07-27T18:25:42Z,2018-08-28T01:48:00Z,2018-08-28T01:21:20Z,CONTRIBUTOR,,0,pydata/xarray/pulls/2322,"Here is my fix for #2315 which matches the behavior of Dataset.filter_by_attrs to be that of its netCDF4 inspiration. I followed the pattern seen in the netCDF4 library which set a boolean flag while looping over attributes and short circuits the loop if any test returns false. Only if all the ``key=value/callable`` tests pass is the variable added to the output.
- [x] Closes #2315
- [x] Tests added (for all bug fixes or enhancements)
- [x] Tests passed (for all non-documentation changes)
- [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)
","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/2322/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull
344631360,MDU6SXNzdWUzNDQ2MzEzNjA=,2315,Behavior of filter_by_attrs() does not match netCDF4.Dataset.get_variables_by_attributes,868027,closed,0,,,8,2018-07-25T22:35:14Z,2018-08-28T01:21:20Z,2018-08-28T01:21:20Z,CONTRIBUTOR,,,,"When using the `filter_by_attrs()` method of a Dataset it was returning more matches than I expected. The returned match set appears to be the logical OR of all the key=value pairs passed into the method. This does not match the behavior of the `netCDF4.Dataset.get_variables_by_attributes` which returns the logical AND of all the key=value pairs passed into it. I couldn't tell from the documentation if this was the intended behavior.
#### Minimal Example
```python
import xarray as xr
example_dataset = xr.Dataset({
""var1"": xr.DataArray([], attrs={""standard_name"": ""example1"", ""priority"": 0}),
""var2"": xr.DataArray([], attrs={""standard_name"": ""example2""})
})
example_dataset.filter_by_attrs(standard_name=""example2"", priority=0)
```
#### Example Output
```python
Dimensions: (dim_0: 0)
Dimensions without coordinates: dim_0
Data variables:
var1 (dim_0) float64
var2 (dim_0) float64
```
#### Expected Output
```python
Dimensions: ()
Data variables:
*empty*
```
Alternatively, chaining calls to filter_by_attrs will result in the expected behavior:
```python
import xarray as xr
example_dataset = xr.Dataset({
""var1"": xr.DataArray([], attrs={""standard_name"": ""example1"", ""priority"": 0}),
""var2"": xr.DataArray([], attrs={""standard_name"": ""example2""})
})
example_dataset.filter_by_attrs(standard_name=""example2"").filter_by_attrs(priority=0)
Dimensions: ()
Data variables:
*empty*
```
#### Output of ``xr.show_versions()``
INSTALLED VERSIONS
------------------
commit: None
python: 3.7.0.final.0
python-bits: 64
OS: Darwin
OS-release: 17.7.0
machine: x86_64
processor: i386
byteorder: little
LC_ALL: en_US.UTF-8
LANG: en_US.UTF-8
LOCALE: en_US.UTF-8
xarray: 0.10.8
pandas: 0.23.3
numpy: 1.14.5
scipy: 1.1.0
netCDF4: 1.4.0
h5netcdf: None
h5py: None
Nio: None
zarr: None
bottleneck: 1.2.1
cyordereddict: None
dask: 0.18.2
distributed: 1.22.0
matplotlib: 2.2.2
cartopy: 0.16.0
seaborn: None
setuptools: 39.0.1
pip: 10.0.1
conda: None
pytest: 3.6.3
IPython: 6.4.0
sphinx: None
","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/2315/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,13221727,issue