id,node_id,number,title,user,state,locked,assignee,milestone,comments,created_at,updated_at,closed_at,author_association,active_lock_reason,draft,pull_request,body,reactions,performed_via_github_app,state_reason,repo,type 898971620,MDExOlB1bGxSZXF1ZXN0NjUwNzUyNTI4,5364,use assert_allcose on test_resample_loffset,199050,closed,0,,,4,2021-05-23T08:56:52Z,2021-05-26T07:09:06Z,2021-05-26T07:08:22Z,CONTRIBUTOR,,0,pydata/xarray/pulls/5364,"`test_resample_loffset` failed on i586 with Python 3.9 as it used `assert_identical`. Changed to the more permissive `assert_allclose`. - [x] Closes #5341 - [ ] Tests added - [ ] Passes `pre-commit run --all-files` - [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - [ ] New functions/methods are listed in `api.rst` ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/5364/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 895163261,MDU6SXNzdWU4OTUxNjMyNjE=,5341,Test test_resample_loffset fails on i586 with Python 3.9,199050,closed,0,,,3,2021-05-19T08:42:05Z,2021-05-26T07:08:22Z,2021-05-26T07:08:22Z,CONTRIBUTOR,,,," **What happened**: Running tests with `pytest-3.9 -v -n auto xarray` -> ``` [ 262s] =================================== FAILURES =================================== [ 262s] ______________________ TestDataset.test_resample_loffset _______________________ [ 262s] [gw1] linux -- Python 3.9.5 /usr/bin/python3.9 [ 262s] [ 262s] self = [ 262s] [ 262s] def test_resample_loffset(self): [ 262s] times = pd.date_range(""2000-01-01"", freq=""6H"", periods=10) [ 262s] ds = Dataset( [ 262s] { [ 262s] ""foo"": ([""time"", ""x"", ""y""], np.random.randn(10, 5, 3)), [ 262s] ""bar"": (""time"", np.random.randn(10), {""meta"": ""data""}), [ 262s] ""time"": times, [ 262s] } [ 262s] ) [ 262s] ds.attrs[""dsmeta""] = ""dsdata"" [ 262s] [ 262s] # Our use of `loffset` may change if we align our API with pandas' changes. [ 262s] # ref https://github.com/pydata/xarray/pull/4537 [ 262s] actual = ds.resample(time=""24H"", loffset=""-12H"").mean().bar [ 262s] expected_ = ds.bar.to_series().resample(""24H"").mean() [ 262s] expected_.index += to_offset(""-12H"") [ 262s] expected = DataArray.from_series(expected_) [ 262s] > assert_identical(actual, expected) [ 262s] E AssertionError: Left and right DataArray objects are not identical [ 262s] E [ 262s] E Differing values: [ 262s] E L [ 262s] E array([ 0.018477, -0.178807, -0.792644]) [ 262s] E R [ 262s] E array([ 0.018477, -0.178807, -0.792644]) [ 262s] [ 262s] /home/abuild/rpmbuild/BUILD/xarray-0.18.1/xarray/tests/test_dataset.py:3991: AssertionError ``` [devel:languages:python:numeric-python-xarray-openSUSE_Tumbleweed-i586.txt](Complete log) **What you expected to happen**: Tests succeed **Minimal Complete Verifiable Example**: ```python # Put your MCVE code here ``` **Anything else we need to know?**: Tests with x86_64 succeed **Environment**: openSUSE Tumbleweed build environment (for packaging)
Output of xr.show_versions() ``` INSTALLED VERSIONS ------------------ commit: None python: 3.9.5 (default, May 05 2021, 15:23:13) [GCC] python-bits: 32 OS: Linux OS-release: 5.12.3-1-default machine: x86_64 processor: x86_64 byteorder: little LC_ALL: None LANG: None LOCALE: ('en_US', 'UTF-8') libhdf5: None libnetcdf: None xarray: 0.18.1 pandas: 1.2.4 numpy: 1.20.2 scipy: 1.6.3 netCDF4: None pydap: None h5netcdf: None h5py: None Nio: None zarr: None cftime: None nc_time_axis: None PseudoNetCDF: None rasterio: None cfgrib: None iris: None bottleneck: None dask: 2021.04.1 distributed: None matplotlib: None cartopy: None seaborn: None numbagg: None pint: None setuptools: 44.1.1 pip: None conda: None pytest: 6.2.2 IPython: None sphinx: None ```
","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/5341/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,13221727,issue