id,node_id,number,title,user,state,locked,assignee,milestone,comments,created_at,updated_at,closed_at,author_association,active_lock_reason,draft,pull_request,body,reactions,performed_via_github_app,state_reason,repo,type 1562840229,PR_kwDOAMm_X85I1gYs,7489,Remove Dask single-threaded setting in tests,11656932,closed,0,,,7,2023-01-30T17:13:16Z,2023-01-31T18:51:28Z,2023-01-31T18:45:47Z,CONTRIBUTOR,,0,pydata/xarray/pulls/7489,"I'm not totally sure why `single-threaded` was being set to begin with, so I might be missing some important context here Closes https://github.com/pydata/xarray/issues/7483 ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/7489/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 1562931560,PR_kwDOAMm_X85I10MO,7491,Fix `isort` `pre-commit` install,11656932,closed,0,,,2,2023-01-30T18:08:12Z,2023-01-30T18:16:15Z,2023-01-30T18:16:11Z,CONTRIBUTOR,,0,pydata/xarray/pulls/7491,"xref https://github.com/PyCQA/isort/issues/2077 Closes https://github.com/pydata/xarray/issues/7490","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/7491/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 1562851680,I_kwDOAMm_X85dJzlg,7490,`pre-commit` hooks broken,11656932,closed,0,,,1,2023-01-30T17:19:49Z,2023-01-30T18:15:50Z,2023-01-30T18:15:50Z,CONTRIBUTOR,,,,"### What happened? When I attempt to run `pre-commit` locally I get the following error: ``` ❯ pre-commit run --all-files [INFO] Installing environment for https://github.com/PyCQA/isort. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... An unexpected error has occurred: CalledProcessError: command: ('/Users/james/.cache/pre-commit/repo_eax0t7q/py_env-python3.9/bin/python', '-mpip', 'install', '.') return code: 1 expected return code: 0 stdout: Processing /Users/james/.cache/pre-commit/repo_eax0t7q Installing build dependencies: started Installing build dependencies: finished with status 'done' Getting requirements to build wheel: started Getting requirements to build wheel: finished with status 'done' Preparing wheel metadata: started Preparing wheel metadata: finished with status 'error' stderr: DEPRECATION: A future pip version will change local packages to be built in-place without first copying to a temporary directory. We recommend you use --use-feature=in-tree-build to test your packages with this new behavior before it becomes the default. pip 21.3 will remove support for this functionality. You can find discussion regarding this at https://github.com/pypa/pip/issues/7555. ERROR: Command errored out with exit status 1: command: /Users/james/.cache/pre-commit/repo_eax0t7q/py_env-python3.9/bin/python /Users/james/.cache/pre-commit/repo_eax0t7q/py_env-python3.9/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py prepare_metadata_for_build_wheel /var/folders/k_/lx1rdvqn253gd1wrcx__5frm0000gn/T/tmphq1i398_ cwd: /private/var/folders/k_/lx1rdvqn253gd1wrcx__5frm0000gn/T/pip-req-build-4ywk4y5l Complete output (14 lines): Traceback (most recent call last): File ""/Users/james/.cache/pre-commit/repo_eax0t7q/py_env-python3.9/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py"", line 280, in main() File ""/Users/james/.cache/pre-commit/repo_eax0t7q/py_env-python3.9/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py"", line 263, in main json_out['return_val'] = hook(**hook_input['kwargs']) File ""/Users/james/.cache/pre-commit/repo_eax0t7q/py_env-python3.9/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py"", line 133, in prepare_metadata_for_build_wheel return hook(metadata_directory, config_settings) File ""/private/var/folders/k_/lx1rdvqn253gd1wrcx__5frm0000gn/T/pip-build-env-bvdexj4q/overlay/lib/python3.9/site-packages/poetry/core/masonry/api.py"", line 40, in prepare_metadata_for_build_wheel poetry = Factory().create_poetry(Path(""."").resolve(), with_groups=False) File ""/private/var/folders/k_/lx1rdvqn253gd1wrcx__5frm0000gn/T/pip-build-env-bvdexj4q/overlay/lib/python3.9/site-packages/poetry/core/factory.py"", line 57, in create_poetry raise RuntimeError(""The Poetry configuration is invalid:\n"" + message) RuntimeError: The Poetry configuration is invalid: - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$' ---------------------------------------- WARNING: Discarding file:///Users/james/.cache/pre-commit/repo_eax0t7q. Command errored out with exit status 1: /Users/james/.cache/pre-commit/repo_eax0t7q/py_env-python3.9/bin/python /Users/james/.cache/pre-commit/repo_eax0t7q/py_env-python3.9/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py prepare_metadata_for_build_wheel /var/folders/k_/lx1rdvqn253gd1wrcx__5frm0000gn/T/tmphq1i398_ Check the logs for full command output. ERROR: Command errored out with exit status 1: /Users/james/.cache/pre-commit/repo_eax0t7q/py_env-python3.9/bin/python /Users/james/.cache/pre-commit/repo_eax0t7q/py_env-python3.9/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py prepare_metadata_for_build_wheel /var/folders/k_/lx1rdvqn253gd1wrcx__5frm0000gn/T/tmphq1i398_ Check the logs for full command output. Check the log at /Users/james/.cache/pre-commit/pre-commit.log ``` It also looks like we're seeing the same thing in CI https://results.pre-commit.ci/run/github/13221727/1675098797.6-zAnTMbQXC74StmKz5PFw ### What did you expect to happen? _No response_ ### Minimal Complete Verifiable Example _No response_ ### MVCE confirmation - [ ] Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray. - [ ] Complete example — the example is self-contained, including all data and the text of any traceback. - [ ] Verifiable example — the example copy & pastes into an IPython prompt or [Binder notebook](https://mybinder.org/v2/gh/pydata/xarray/main?urlpath=lab/tree/doc/examples/blank_template.ipynb), returning the result. - [ ] New issue — a search of GitHub Issues suggests this is not a duplicate. ### Relevant log output _No response_ ### Anything else we need to know? _No response_ ### Environment
``` INSTALLED VERSIONS ------------------ commit: 12f6d2449b478afbcf442a39bc3f0048b1fa8c29 python: 3.9.6 | packaged by conda-forge | (default, Jul 11 2021, 03:36:15) [Clang 11.1.0 ] python-bits: 64 OS: Darwin OS-release: 22.2.0 machine: x86_64 processor: i386 byteorder: little LC_ALL: None LANG: en_US.UTF-8 LOCALE: ('en_US', 'UTF-8') libhdf5: 1.10.6 libnetcdf: 4.7.4 xarray: 0.19.0 pandas: 1.3.2 numpy: 1.21.2 scipy: 1.7.1 netCDF4: 1.5.6 pydap: installed h5netcdf: 0.11.0 h5py: 3.3.0 Nio: None zarr: 2.8.3 cftime: 1.5.0 nc_time_axis: 1.3.1 PseudoNetCDF: installed rasterio: 1.2.6 cfgrib: 0.9.9.0 iris: 3.0.4 bottleneck: 1.3.2 dask: 2023.1.1+1.ga8327a35c distributed: 2023.1.1 matplotlib: 3.4.3 cartopy: 0.19.0.post1 seaborn: 0.11.2 numbagg: 0.2.1 fsspec: 2021.06.1 cupy: None pint: 0.17 sparse: 0.13.0 flox: None numpy_groupies: None setuptools: 57.4.0 pip: 21.2.4 conda: None pytest: 6.2.4 mypy: None IPython: None sphinx: None ```
","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/7490/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,13221727,issue 1368328647,PR_kwDOAMm_X84-tGZl,7016,`kwargs` typo in custom backend docs,11656932,closed,0,,,1,2022-09-09T21:06:53Z,2022-09-09T22:37:10Z,2022-09-09T22:33:39Z,CONTRIBUTOR,,0,pydata/xarray/pulls/7016,Noticed a tiny typo when reading through https://docs.xarray.dev/en/stable/internals/how-to-add-new-backend.html,"{""url"": ""https://api.github.com/repos/pydata/xarray/issues/7016/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 1330548427,PR_kwDOAMm_X848v2u7,6884,Temporarily import `loop_in_thread` fixture from `distributed`,11656932,closed,0,,,5,2022-08-05T22:30:53Z,2022-08-08T15:12:42Z,2022-08-06T01:25:19Z,CONTRIBUTOR,,0,pydata/xarray/pulls/6884," - [x] Closes https://github.com/dask/distributed/issues/6842 - [ ] Tests added - [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - [ ] New functions/methods are listed in `api.rst` This is a quickfix similar to https://github.com/dask/dask/pull/9337. Note there's a conversation happening over in https://github.com/dask/distributed/issues/6806 around what testing utilities in `distributed` should be considered public. ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/6884/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 1103972043,PR_kwDOAMm_X84xDYL7,6166,Trigger upstream CI build,11656932,closed,0,,,0,2022-01-14T18:06:23Z,2022-01-14T18:38:31Z,2022-01-14T18:38:28Z,CONTRIBUTOR,,0,pydata/xarray/pulls/6166,Just wanting to check the test suite before issuing a `dask` release. Apologies for the noise.,"{""url"": ""https://api.github.com/repos/pydata/xarray/issues/6166/reactions"", ""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 983032639,MDExOlB1bGxSZXF1ZXN0NzIyNjgxMzEw,5751,Update `sparse` `test_chunk` xfail,11656932,closed,0,,,3,2021-08-30T17:32:49Z,2021-08-31T15:12:45Z,2021-08-31T14:27:17Z,CONTRIBUTOR,,0,pydata/xarray/pulls/5751,"`xarray/tests/test_sparse.py::test_chunk` now passes with the latest `sparse=0.13.0` release - [x] Closes https://github.com/pydata/xarray/issues/5654 - [ ] Tests added - [ ] Passes `pre-commit run --all-files` - [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - [ ] New functions/methods are listed in `api.rst` ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/5751/reactions"", ""total_count"": 5, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 5, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 960674159,MDU6SXNzdWU5NjA2NzQxNTk=,5675,Use of `force_to_top` for `isort`,11656932,closed,0,,,1,2021-08-04T16:01:09Z,2021-08-21T20:15:17Z,2021-08-21T20:15:17Z,CONTRIBUTOR,,,,"In https://github.com/dask/distributed/pull/5170, @fjetter pointed out that `distributed` was incorrectly using `force_to_top` in our `isort` configuration (we should have been using `float_to_top` instead). Just a minor point, but since `xarray`s `isort` configuration influenced what we did over in `dask` and `distributed`, I thought it was worth letting the Xarray devs know about it https://github.com/pydata/xarray/blob/8f5b4a185b304ab68723c390b1ad88e57f9a60d6/setup.cfg#L164","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/5675/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,13221727,issue 877723396,MDExOlB1bGxSZXF1ZXN0NjMxNjI5NzI2,5271,Ensure `HighLevelGraph` layers are `Layer` instances,11656932,closed,0,,,1,2021-05-06T16:46:48Z,2021-05-06T20:37:42Z,2021-05-06T20:29:55Z,CONTRIBUTOR,,0,pydata/xarray/pulls/5271,"This PR updates how we construct the `HighLevelGraph` in `subset_dataset_to_block`. Currently we create a `HighLevelGraph` and then manually add a few new layers, which are `dict`s, directly to `hlg.layers`. https://github.com/pydata/xarray/blob/eec2b59bd08498fe3d50d8549b540d0a8409c7ac/xarray/core/parallel.py#L537-L546 However since (in more recent versions of Dask) [`HighLevelGraph` layers are expected to be `Layer` class instances](https://github.com/dask/dask/blob/23c93d72c8fbd194b44614c29dd584ff93fc1eef/dask/highlevelgraph.py#L578-L582) this can result in unexpected errors (xref https://github.com/pydata/xarray/issues/5077#issuecomment-832359943). Instead of manually adding new layers to `hlg.layers`, this PR proposes we create a new `HighLevelGraph` altogether to ensure that `hlg.layers` won't contain any raw `dict` layers.","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/5271/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull