id,node_id,number,title,user,state,locked,assignee,milestone,comments,created_at,updated_at,closed_at,author_association,active_lock_reason,draft,pull_request,body,reactions,performed_via_github_app,state_reason,repo,type 714844298,MDExOlB1bGxSZXF1ZXN0NDk3ODU3MTA0,4485,Handle scale_factor and add_offset as scalar,500246,closed,0,,,3,2020-10-05T13:31:36Z,2020-10-16T21:20:14Z,2020-10-11T20:06:33Z,CONTRIBUTOR,,0,pydata/xarray/pulls/4485,"The h5netcdf engine exposes single-valued attributes as arrays of shape (1,), which is correct according to the NetCDF standard, but may cause a problem when reading a value of shape () before the scale_factor and add_offset have been applied. This PR adds a check for the dimensionality of add_offset and scale_factor and ensures they are scalar before they are used for further processing, adds a unit test to verify that this works correctly, and a note to the documentation to warn users of this difference between the h5netcdf and netcdf4 engines. - [x] Closes #4471 - [x] Tests added - [x] Passes `isort . && black . && mypy . && flake8` - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/4485/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 381633612,MDExOlB1bGxSZXF1ZXN0MjMxNTU2ODM5,2557,add missing comma and article in error message,500246,closed,0,,,2,2018-11-16T14:59:02Z,2018-11-16T16:40:03Z,2018-11-16T16:40:03Z,CONTRIBUTOR,,0,pydata/xarray/pulls/2557,"Add missing comma and article in error message when attribute values have the wrong type. I tihnk this change is sufficiently minor that no documentation or whatsnew changes should be necessary. ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/2557/reactions"", ""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 281552158,MDExOlB1bGxSZXF1ZXN0MTU3OTUwMzcy,1777,Respect PEP 440,500246,closed,0,,,4,2017-12-12T21:59:18Z,2017-12-15T07:26:33Z,2017-12-15T07:26:24Z,CONTRIBUTOR,,0,pydata/xarray/pulls/1777,"Change unreleased version numbers as to respect PEP 440. Rather than `0.10.0-9-g89a1a98` we will have `0.10.0+dev9.g89a1a98`. This means automated setuptools requirements can be respected. Closes #1300. - [x] Closes #1300 (remove if there is no corresponding issue, which should only be the case for minor changes) - [ ] Tests added (for all bug fixes or enhancements) - [ ] Tests passed (for all non-documentation changes) - [x] Passes ``git diff upstream/master **/*py | flake8 --diff`` (remove if you did not edit any Python files) - [ ] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later) ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/1777/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 269182902,MDExOlB1bGxSZXF1ZXN0MTQ5MjQ2NDQ5,1664,BUG: Added new names for pandas isna/notna unary functions,500246,closed,0,,,1,2017-10-27T17:38:54Z,2017-11-09T02:47:21Z,2017-11-09T02:47:21Z,CONTRIBUTOR,,0,pydata/xarray/pulls/1664,"In pandas commit https://github.com/pandas-dev/pandas/commit/793020293ee1e5fa023f45c12943a4ac51cc23d isna and notna were added as aliases for isnull and notnull. Those need to be added to PANDAS_UNARY_FUNCTIONS for xarray datasets notnull to work. Closes #1663. - [ ] Closes #1663 Note: I'm not sure how to test for this, as I think existing tests should be already failing due to this. In fact, when I run `nosetests` on my system I get 123 skips, 29 errors and 2 failures, none of which are related to my addition, so there must be something wrong on my system. I did not try the flake8 test and I think new documentation is exaggerated in this case. ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/1664/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 212471682,MDExOlB1bGxSZXF1ZXN0MTA5NTA3MzQz,1299,BUG/TST: Retain encoding upon concatenation,500246,closed,0,,,6,2017-03-07T15:46:11Z,2017-09-05T04:10:02Z,2017-09-05T04:10:02Z,CONTRIBUTOR,,0,pydata/xarray/pulls/1299,"Retain encoding upon concatenation of DataArray or Dataset. - [x] closes #1297 - [x] tests added / passed - [x] passes ``git diff upstream/master | flake8 --diff`` - [ ] whatsnew entry ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/1299/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 228036180,MDExOlB1bGxSZXF1ZXN0MTIwMTM4ODQ4,1406,"BUG: Allow unsigned integer indexing, fixes #1405",500246,closed,0,,,6,2017-05-11T15:41:50Z,2017-09-01T15:54:41Z,2017-09-01T15:54:41Z,CONTRIBUTOR,,0,pydata/xarray/pulls/1406,"Permit indexing with unsigned integers. This should fix #1405. - [x] closes #1405 - [ ] tests added / passed - [ ] passes ``git diff upstream/master | flake8 --diff`` - [ ] whatsnew entry ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/1406/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 204090452,MDExOlB1bGxSZXF1ZXN0MTAzNzkyMDAz,1241,BUG: Add mixing dimension name to error message,500246,closed,0,,,1,2017-01-30T18:24:52Z,2017-01-30T18:40:27Z,2017-01-30T18:40:27Z,CONTRIBUTOR,,0,pydata/xarray/pulls/1241,"Bugfix: error message for `KeyError` has spurious `%r`, into which the dimension name is apparently intended to be substituted, but wasn't. Substitute the dimension name so that the error message is more informative. ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/1241/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 200131742,MDExOlB1bGxSZXF1ZXN0MTAxMDkzNjEy,1200,DOC: fix small typo/mistake (NaN value not dtype),500246,closed,0,,,1,2017-01-11T15:57:15Z,2017-01-11T17:11:04Z,2017-01-11T17:11:01Z,CONTRIBUTOR,,0,pydata/xarray/pulls/1200,"Fix small mistake in documentation. It said NaN is not a valid dtype for integer dtypes, this surely should be NaN is not a valid value for integer dtypes.","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/1200/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull