id,node_id,number,title,user,state,locked,assignee,milestone,comments,created_at,updated_at,closed_at,author_association,active_lock_reason,draft,pull_request,body,reactions,performed_via_github_app,state_reason,repo,type
267220322,MDU6SXNzdWUyNjcyMjAzMjI=,1641,Rasterio backend broken with rasterio=1.0a10,3585769,closed,0,,,2,2017-10-20T15:49:45Z,2017-10-24T20:53:09Z,2017-10-24T20:53:09Z,CONTRIBUTOR,,,,"The latest alpha of rasterio (`1.0a10`) breaks the xarray backend (tested against `xarray=0.9.6`) because it expects either a `tuple` or `rasterio.windows.Window` passed as the `window` keyword argument to `read`. Tuples get converted to a `Window` in the latest alpha, but xarray currently passes the window as a list. Simply converting the window argument to a tuple fixes the backend ([see here for the fix I'm proposing](https://github.com/ceholden/xarray/commit/8dc7e748e1af273ed13f0d3dacc48a80e4741c21)).

Somewhat related, the CI services are currently testing against `rasterio=0.36` while this backend was originally tested against one of the 1.0 alphas. The cause is the `rasterio-feedstock` repo switched the development alpha releases to be distributed on the `conda-forge/label/dev` channel, instead of the regular `conda-forge` channel. Switching to the development channel for `1.0a10` should cause this issue to manifest itself on the CI services.

Happy to address these (and add to whats-new, etc) in the same or separate issues/PRs, depending on what you think makes sense. Thanks for all your work!","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/1641/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,13221727,issue
267228212,MDExOlB1bGxSZXF1ZXN0MTQ3ODM5ODUx,1642,Fix rasterio backend for rasterio=1.0a10,3585769,closed,0,,,0,2017-10-20T16:15:34Z,2017-10-24T20:53:09Z,2017-10-24T20:53:09Z,CONTRIBUTOR,,0,pydata/xarray/pulls/1642," - [x] Closes #1641
 - [x] Tests added / passed
 - [x] Passes ``git diff upstream/master | flake8 --diff``
 - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API

First commit should fix rasterio backend for the current alpha release `rasterio=1.0a10` and for future stable releases. Behind the scenes rasterio converts to a `Window` using `Window.from_slices`. I thought about doing the conversion within xarray and passing a `Window` directly, but that would require importing rasterio within the `__getitem__`, which seems not very great.

Second commit updates the CI service configurations to use the conda-forge development channel that the rasterio alphas are published on. I put the dev channel behind existing channels, and pinned the version of rasterio to anything `1.0` and beyond. Not so sure what the best course of action here is and I'm happy to take suggestions.

Still have to add to the `whats-new`. I'm assuming I can ignore flake8 warnings from the conda environment files (e.g., `git diff upstream/master -- '*.py' | flake8 --diff`)?","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/1642/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull