id,node_id,number,title,user,state,locked,assignee,milestone,comments,created_at,updated_at,closed_at,author_association,active_lock_reason,draft,pull_request,body,reactions,performed_via_github_app,state_reason,repo,type
517855271,MDExOlB1bGxSZXF1ZXN0MzM2ODQ0OTE1,3487,Respect user-specified coordinates attribute.,2448579,closed,0,,,5,2019-11-05T15:46:00Z,2019-12-10T16:02:20Z,2019-12-10T16:02:01Z,MEMBER,,0,pydata/xarray/pulls/3487,"<!-- Feel free to remove check-list items aren't relevant to your change -->

A minimally invasive solution to #3351. If `variable.encoding[""coordinates""]` is specified, we write that attribute to disk and warn the user that roundtripping may not work.

 - [x] Closes #3351
 - [x] Tests added
 - [x] Passes `black . && mypy . && flake8`
 - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API
","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/3487/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull
499481465,MDU6SXNzdWU0OTk0ODE0NjU=,3351,"custom ""coordinates"" attribute",2448579,closed,0,,,0,2019-09-27T14:32:58Z,2019-12-10T16:02:01Z,2019-12-10T16:02:01Z,MEMBER,,,,"This set of lines prevents users from writing files with a handcrafted `coordinates` attribute. This is useful when not all non-dimensional coordinates in a Dataset are appropriate for every data variable in a dataset.

https://github.com/pydata/xarray/blob/16fdac93c09036b44f90201d9078b17808f819e0/xarray/conventions.py#L667-L675

It seems to me like we should only automatically set ""coordinates"" when `""coordinates"" not in attrs`. We could raise a warning saying that setting `attrs[""coordinates""]` prevents full roundtripping of Datasets.

What do you think?
","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/3351/reactions"", ""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,13221727,issue
533462810,MDExOlB1bGxSZXF1ZXN0MzQ5NTMzMTYz,3597,Add Facetgrid.row_labels & Facetgrid.col_labels,2448579,closed,0,,,2,2019-12-05T16:35:38Z,2019-12-10T15:41:24Z,2019-12-10T15:41:21Z,MEMBER,,0,pydata/xarray/pulls/3597,"This allows labels to be changed later using `Facetgrid.set_titles`. We now save handles in `Facetgrid.row_labels` and `Facetgrid.col_labels`. I also added some API docs for facetgrid.

Example
```
g = darray.plot.imshow(row=""row"", col=""col"")
g.set_titles(""abc={value}"")
```

**before** (see row labels; the column labels work because those are set using `set_title`. )
![before](https://user-images.githubusercontent.com/2448579/70251014-b8122c80-1776-11ea-93ea-560c1062e374.png)


**after**
![after](https://user-images.githubusercontent.com/2448579/70251111-d7a95500-1776-11ea-8d8f-030ea76bded6.png)


 - [x] Tests added
 - [x] Passes `black . && mypy . && flake8`
 - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API
","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/3597/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull