id,node_id,number,title,user,state,locked,assignee,milestone,comments,created_at,updated_at,closed_at,author_association,active_lock_reason,draft,pull_request,body,reactions,performed_via_github_app,state_reason,repo,type 2180447578,PR_kwDOAMm_X85pUKwG,8821,Add small test exposing issue from #7794 and suggestion for `_wrap_numpy_scalars` fix,81219,open,0,,,1,2024-03-11T23:40:17Z,2024-04-03T18:53:28Z,,CONTRIBUTOR,,0,pydata/xarray/pulls/8821,"`_wrap_numpy_scalars` relies on `np.isscalar`, which incorrectly labels a single cftime object as not a scalar. ```python import cftime import numpy as np c = cftime.datetime(2000, 1, 1, calendar='360_day') np.isscalar(c) # False ``` The PR adds logic to handle non-numpy objects using the `np.ndim` function. The logic for built-ins and numpy objects should remain the same. The function logic could possibly be rewritten more clearly as ```python if hasattr(array, ""dtype""): if np.isscalar(array): return np.array(array) else: return array if np.ndim(array) == 0: return np.array(array) return array ``` - [x] Closes #7794 - [x] Tests added - [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - [ ] New functions/methods are listed in `api.rst` ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/8821/reactions"", ""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 741100024,MDExOlB1bGxSZXF1ZXN0NTE5NDc0NzQz,4573,Update xESMF link to pangeo-xesmf in related-projects,81219,closed,0,,,1,2020-11-11T22:00:34Z,2020-11-12T14:54:08Z,2020-11-12T14:53:56Z,CONTRIBUTOR,,0,pydata/xarray/pulls/4573," The new link is where development now occurs. ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/4573/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 561210241,MDExOlB1bGxSZXF1ZXN0MzcyMDYyNTM2,3758,Fix interp bug when indexer shares coordinates with array,81219,closed,0,,,4,2020-02-06T19:06:22Z,2020-03-13T13:58:38Z,2020-03-13T13:58:38Z,CONTRIBUTOR,,0,pydata/xarray/pulls/3758," - [x] Closes #3252 - [x] Tests added - [x] Passes `isort -rc . && black . && mypy . && flake8` - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API Replaces #3262 (I think). ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/3758/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 538620718,MDExOlB1bGxSZXF1ZXN0MzUzNzM1MDM4,3631,Add support for CFTimeIndex in get_clean_interp_index,81219,closed,0,,,11,2019-12-16T19:57:24Z,2020-01-26T18:36:24Z,2020-01-26T14:10:37Z,CONTRIBUTOR,,0,pydata/xarray/pulls/3631," - [x] Closes #3641 - [x] Tests added - [x] Passes `black . && mypy . && flake8` - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API Related to #3349 As suggested by @spencerkclark, index values are computed as a delta with respect to 1970-01-01. At the moment, this fails if dates fall outside of the range for nanoseconds timedeltas [ 1678 AD, 2262 AD]. Is this something we can fix ? ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/3631/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 539821504,MDExOlB1bGxSZXF1ZXN0MzU0NzMwNzI5,3642,Make datetime_to_numeric more robust to overflow errors,81219,closed,0,,,1,2019-12-18T17:34:41Z,2020-01-20T19:21:49Z,2020-01-20T19:21:49Z,CONTRIBUTOR,,0,pydata/xarray/pulls/3642," - [x] Closes #3641 - [x] Tests added - [x] Passes `black . && mypy . && flake8` - [ ] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API This is likely only safe with NumPy>=1.17 though. ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/3642/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 492987154,MDExOlB1bGxSZXF1ZXN0MzE3MDU0MjUz,3305,Honor `keep_attrs` in DataArray.quantile,81219,closed,0,,,1,2019-09-12T19:27:14Z,2019-09-15T22:16:27Z,2019-09-15T22:16:15Z,CONTRIBUTOR,,0,pydata/xarray/pulls/3305," - [x] Closes #3304 - [x] Tests added - [x] Passes `black . && mypy . && flake8` - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API Note that I've set the default to True (if keep_attrs is None). This sounded reasonable since quantiles share the same units and properties as the original array, but I can switch it to False if that's the usual default. ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/3305/reactions"", ""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 423405197,MDExOlB1bGxSZXF1ZXN0MjYyOTgzOTcz,2828,Add quantile method to GroupBy,81219,closed,0,,,6,2019-03-20T18:20:41Z,2019-06-24T15:21:36Z,2019-06-24T15:21:29Z,CONTRIBUTOR,,0,pydata/xarray/pulls/2828," - [x] Tests added - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API Fixes #3018 Note that I've added an unrelated test that exposes an issue with grouping when there is only one element per group. ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/2828/reactions"", ""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull