id,node_id,number,title,user,state,locked,assignee,milestone,comments,created_at,updated_at,closed_at,author_association,active_lock_reason,draft,pull_request,body,reactions,performed_via_github_app,state_reason,repo,type 1673579421,I_kwDOAMm_X85jwMud,7765,Revisiting Xarray's Minimum dependency versions policy,2443309,open,0,,,9,2023-04-18T17:46:03Z,2023-09-19T15:54:09Z,,MEMBER,,,,"### What is your issue? We have recently had a few reports expressing frustration with our minimum dependency version policy. This issue aims to discuss if changes to our policy are needed. ## Background 1. Our current minimum dependency versions policy reads: > ### Minimum dependency versions > > Xarray adopts a rolling policy regarding the minimum supported version of its dependencies: > > - Python: 24 months ([NEP-29](https://numpy.org/neps/nep-0029-deprecation_policy.html)) > - numpy: 18 months ([NEP-29](https://numpy.org/neps/nep-0029-deprecation_policy.html)) > - all other libraries: 12 months > > This means the latest minor (X.Y) version from N months prior. Patch versions (x.y.Z) are not pinned, and only the latest available at the moment of publishing the xarray release is guaranteed to work. > > You can see the actual minimum tested versions: > > [pydata/xarray](https://github.com/pydata/xarray/blob/main/ci/requirements/min-all-deps.yml) 2. We have a script that checks versions and dates and advises us on when to bump minimum versions. https://github.com/pydata/xarray/blob/main/ci/min_deps_check.py ## Diagnosis 1. Our policy and `min_deps_check.py` script have greatly reduced our deliberations on which versions to support and the maintenance burden of supporting out dated versions of dependencies. 2. We likely need to update our policy and `min_deps_check.py` script to properly account for Python's SEMVER bugfix releases. Depending on how you interpret the policy, we may have prematurely dropped Python 3.8 (see below for a potential action item). ## Discussion questions 1. Is the policy working as designed, are the support windows documented above still appropriate for where Xarray is at today? 2. Is this policy still in line with how our peer libraries are operating? ## Action items 1. There is likely a bug in the patch-version comparison in the minimum Python version. Moreover, we don't differentiate between bugfix and security releases. I suggest we have a special policy for our minimum supported Python version that reads something like: > Python: 24 months from the last bugfix release (security releases are not considered). ------ xref: https://github.com/pydata/xarray/issues/4179, https://github.com/pydata/xarray/pull/7461 Moderators note: I suspect a number of folks will want to comment on this issue with ""Please support Python 3.8 for longer..."". If that is the nature of your comment, please just give this a ❤️ reaction rather than filling up the discussion. ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/7765/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,reopened,13221727,issue 1902086612,PR_kwDOAMm_X85aoYuf,8206,flox: Set fill_value=np.nan always.,2448579,open,0,,,0,2023-09-19T02:19:49Z,2023-09-19T02:23:26Z,,MEMBER,,1,pydata/xarray/pulls/8206," - [x] Closes #8090 - [x] Tests added - [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - [ ] New functions/methods are listed in `api.rst` ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/8206/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 1869879398,PR_kwDOAMm_X85Y8P4c,8118,Add Coordinates `set_xindex()` and `drop_indexes()` methods,4160723,open,0,,,0,2023-08-28T14:28:24Z,2023-09-19T01:53:18Z,,MEMBER,,0,pydata/xarray/pulls/8118," - Complements #8102 - [ ] Tests added - [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - [ ] New functions/methods are listed in `api.rst` I don't think that we need to copy most API from Dataset / DataArray to `Coordinates`, but I find it convenient to have some relevant methods there too. For example, building Coordinates from scratch (with custom indexes) before passing the whole coords + indexes bundle around: ```python import dask.array as da import numpy as np import xarray as xr coords = ( xr.Coordinates( coords={""x"": da.arange(100_000_000), ""y"": np.arange(100)}, indexes={}, ) .set_xindex(""x"", DaskIndex) .set_xindex(""y"", xr.indexes.PandasIndex) ) ds = xr.Dataset(coords=coords) # # Dimensions: (x: 100000000, y: 100) # Coordinates: # * x (x) int64 dask.array # * y (y) int64 0 1 2 3 4 5 6 7 8 9 10 ... 90 91 92 93 94 95 96 97 98 99 # Data variables: # *empty* # Indexes: # x DaskIndex ``` ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/8118/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 1801393806,PR_kwDOAMm_X85VVV4q,7981,Document that Coarsen accepts coord func as callable,35968931,open,0,,,0,2023-07-12T17:01:31Z,2023-09-19T01:18:49Z,,MEMBER,,0,pydata/xarray/pulls/7981,"Documents a hidden feature I noticed yesterday, corrects incorrect docstrings, and tidies up some of the typing internally. - [ ] ~~Closes #xxxx~~ - [ ] Tests added - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - [ ] ~~New functions/methods are listed in `api.rst`~~ ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/7981/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull