id,node_id,number,title,user,state,locked,assignee,milestone,comments,created_at,updated_at,closed_at,author_association,active_lock_reason,draft,pull_request,body,reactions,performed_via_github_app,state_reason,repo,type 220368276,MDExOlB1bGxSZXF1ZXN0MTE0OTI3Mjc4,1361,Fix .where(drop=True) when arguments do not have indexes,1217238,closed,0,,2444330,2,2017-04-08T02:10:30Z,2017-04-14T22:55:43Z,2017-04-14T03:50:53Z,MEMBER,,0,pydata/xarray/pulls/1361,"There might be cleaner ways to fix this than aligning twice, but this will do for now. - [x] closes #1350 - [x] tests added / passed - [x] passes ``git diff upstream/master | flake8 --diff`` - [x] whatsnew entry ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/1361/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 219043002,MDU6SXNzdWUyMTkwNDMwMDI=,1350,"where(..., drop=True) error",4295853,closed,0,,2444330,4,2017-04-03T19:53:33Z,2017-04-14T03:50:53Z,2017-04-14T03:50:53Z,CONTRIBUTOR,,,,"These results appear to be incorrect unless I'm missing something: ```python In [1]: import xarray as xr In [2]: import numpy as np In [3]: array = xr.DataArray(np.zeros((1,2,3)), dims=['time','x','y'], coords={'x':np.arange(2)}) In [4]: array[0,1,1] = 1 In [5]: array.where(array !=0, drop=True) Out[5]: array([[[ 0.]]]) Coordinates: * x (x) int64 1 Dimensions without coordinates: time, y In [5]: array.where(array !=0, drop=True).values Out[5]: array([[[ 0.]]]) In [7]: array.values[array.values !=0] Out[7]: array([ 1.]) ``` ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/1350/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,13221727,issue 216535655,MDU6SXNzdWUyMTY1MzU2NTU=,1320,BUG: to_netcdf no longer works with file objects when engine='scipy',1217238,closed,0,1217238,2444330,0,2017-03-23T18:53:18Z,2017-04-13T05:32:59Z,2017-04-13T05:32:59Z,MEMBER,,,,"This worked in xarray v0.8.2, but no longer works in v0.9.1: `ds.to_netcdf(f, engine='scipy')` when `f` is a file-like object. The traceback looks like: ``` File ""...../xarray/core/dataset.py"", line 953, in to_netcdf unlimited_dims=unlimited_dims) File ""...../xarray/backends/api.py"", line 546, in to_netcdf path = _normalize_path(path) File ""...../xarray/backends/api.py"", line 51, in _normalize_path if is_remote_uri(path): File ""...../xarray/core/utils.py"", line 439, in is_remote_uri return bool(re.search('^https?\://', path)) File ""...../re.py"", line 146, in search return _compile(pattern, flags).search(string) TypeError: expected string or buffer ``` The problem is that `to_netcdf` does not check to make sure the path is a string before calling `_normalize_path`: https://github.com/pydata/xarray/blob/b3fc6c4e4fafdf4f075b791594633970a787ad79/xarray/backends/api.py#L545-L548 For now, it's easy enough to work around this by creating a byte-string with `to_netcdf` and then writing the file separately, but it would be nice to support writing to the file-like object directly again.","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/1320/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,13221727,issue 216537677,MDU6SXNzdWUyMTY1Mzc2Nzc=,1321,BUG: to_netcdf(engine='scipy') raises an error when it shouldn't,1217238,closed,0,1217238,2444330,0,2017-03-23T19:00:18Z,2017-04-13T05:32:59Z,2017-04-13T05:32:59Z,MEMBER,,,,"With xarray v0.9.1, I get the confusing error message: `ValueError: invalid engine for creating bytes with to_netcdf: 'scipy'. Only the default engine or engine='scipy' is supported` This check should be `elif engine != 'scipy'` instead: https://github.com/pydata/xarray/blob/b3fc6c4e4fafdf4f075b791594633970a787ad79/xarray/backends/api.py#L541","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/1321/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,13221727,issue 220160378,MDExOlB1bGxSZXF1ZXN0MTE0Nzc3NTU4,1358,Include missing conftest.py,1964655,closed,0,,2444330,8,2017-04-07T09:30:47Z,2017-04-12T22:29:34Z,2017-04-12T22:29:34Z,CONTRIBUTOR,,0,pydata/xarray/pulls/1358,"The tests cannot be run from the release tarball without this file. ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/1358/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 220241754,MDU6SXNzdWUyMjAyNDE3NTQ=,1359,Bug: open_dataarray does not pass properly its parameters to open_dataset,1997005,closed,0,,2444330,1,2017-04-07T15:06:50Z,2017-04-12T22:28:35Z,2017-04-12T22:28:35Z,CONTRIBUTOR,,,,"Hi, There's now a `autoclose` parameter to the `open_dataset` function. But `open_dataarray` uses positional arguments only, so now the arguments are no longer at their place, and `engine`, for instance, can't be specified. Thanks !","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/1359/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,13221727,issue