id,node_id,number,title,user,state,locked,assignee,milestone,comments,created_at,updated_at,closed_at,author_association,active_lock_reason,draft,pull_request,body,reactions,performed_via_github_app,state_reason,repo,type
1285767883,PR_kwDOAMm_X846ahUs,6730,move da and ds fixtures to conftest.py,10194086,closed,0,,,9,2022-06-27T12:56:05Z,2022-12-05T20:11:08Z,2022-07-11T12:44:55Z,MEMBER,,0,pydata/xarray/pulls/6730,"<!-- Feel free to remove check-list items aren't relevant to your change -->

This PR renames the `da` and `ds` fixtures (to `da_fixture` and `ds_fixture`) and moves them to conftest.py. This allows to remove the flake8 error suppression for the tests and seems more how the fixtures are [intended to be used](https://docs.pytest.org/en/6.2.x/fixture.html#conftest-py-sharing-fixtures-across-multiple-files) (from the pytest side). I think the name changes makes it a bit more obvious what happens but moving them to may make it a bit less obvious (if you don't know where to look).

Removing the flake8 error ignores also unearthed some unused imports:

https://github.com/pydata/xarray/blob/787a96c15161c9025182291b672b3d3c5548a6c7/setup.cfg#L155-L156

(What I actually wanted to do is move the tests for `rolling` to it's own file - but I think it makes sense to do this first.)","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/6730/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull