id,node_id,number,title,user,state,locked,assignee,milestone,comments,created_at,updated_at,closed_at,author_association,active_lock_reason,draft,pull_request,body,reactions,performed_via_github_app,state_reason,repo,type 1118729170,PR_kwDOAMm_X84xzR0v,6211,Xfail failing test,5635139,closed,0,,,8,2022-01-30T21:42:35Z,2022-01-31T17:21:40Z,2022-01-31T01:49:10Z,MEMBER,,0,pydata/xarray/pulls/6211," As per https://github.com/pydata/xarray/issues/6209#issuecomment-1025116203","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/6211/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 919842557,MDExOlB1bGxSZXF1ZXN0NjY5MDg1OTY0,5468,Run mypy in pre-commit only in CI?,5635139,closed,0,,,8,2021-06-13T17:11:36Z,2021-06-18T19:33:14Z,2021-06-18T19:01:48Z,MEMBER,,0,pydata/xarray/pulls/5468," On top of https://github.com/pydata/xarray/pull/5467, given I'm not sure this is correct. With `additional_dependencies`, we may not need the additional CI run. But OTOH there's nothing confirming that the `additional_dependencies` has the correct dependencies and there's no material cost to the additional step.","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/5468/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 849974334,MDExOlB1bGxSZXF1ZXN0NjA4NjIwOTIw,5110,Move mypy configs from pre-commit to mypy config,5635139,closed,0,,,8,2021-04-04T22:27:15Z,2021-04-19T06:10:34Z,2021-04-14T18:43:56Z,MEMBER,,0,pydata/xarray/pulls/5110," - [x] Passes `pre-commit run --all-files` This should mean that running `mypy .` doesn't operate differently from running it in pre-commit. It's also possible I've misunderstood something about mypy configs, please let me know if so! ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/5110/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 490752037,MDU6SXNzdWU0OTA3NTIwMzc=,3293,Drop 3.5 after 0.13?,5635139,closed,0,,,8,2019-09-08T13:05:29Z,2019-10-08T21:23:47Z,2019-10-08T21:23:47Z,MEMBER,,,,"I just saw https://numpy.org/neps/nep-0029-deprecation_policy.html, which suggests dropping 3.5 support earlier this year (though NEP is dated to this July) Ofc, existing xarray versions would still work with 3.5, only upgrades would require the new version (which I know everyone knows, but reinforces we don't need to wait for _everyone_ to move off 3.5)","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/3293/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,13221727,issue 423471477,MDExOlB1bGxSZXF1ZXN0MjYzMDM3MDIy,2831,Enable python 3.5.0-3.5.2,5635139,closed,0,,,8,2019-03-20T21:03:51Z,2019-03-22T15:12:27Z,2019-03-22T04:37:25Z,MEMBER,,0,pydata/xarray/pulls/2831, - [x] Closes some of https://github.com/pydata/xarray/issues/2830,"{""url"": ""https://api.github.com/repos/pydata/xarray/issues/2831/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 121569683,MDU6SXNzdWUxMjE1Njk2ODM=,674,Should Dataset constructor align DataArrays based on coords?,5635139,closed,0,,,8,2015-12-10T20:24:00Z,2018-05-31T00:22:59Z,2018-05-31T00:22:59Z,MEMBER,,,,"We have a DataArray unaligned to `coords` here: ``` python In [12]: coords={'a': range(4), 'b': range(3)} da = xray.DataArray(np.random.rand(4,3), coords=coords) da Out[12]: array([[ 0.05126985, 0.95460352, 0.12853847], [ 0.20577943, 0.80265117, 0.46370886], [ 0.0226791 , 0.33068145, 0.55748573], [ 0.15943175, 0.20183347, 0.46907727]]) Coordinates: * a (a) int64 0 1 2 3 * b (b) int64 0 1 2 In [13]: da_reindex = da.reindex(b=[1,2,0]) da_reindex Out[13]: array([[ 0.95460352, 0.12853847, 0.05126985], [ 0.80265117, 0.46370886, 0.20577943], [ 0.33068145, 0.55748573, 0.0226791 ], [ 0.20183347, 0.46907727, 0.15943175]]) Coordinates: * a (a) int64 0 1 2 3 * b (b) int64 1 2 0 ``` If we add this to Dataset and supply `coords=coords`, it raises, since there are conflicting coords: ``` python In [16]: : ds = xray.Dataset(variables={'da':da_reindex}, coords=coords) ds --------------------------------------------------------------------------- ValueError Traceback (most recent call last) in () ----> 1 ds = xray.Dataset(variables={'da':da_reindex}, coords=coords) 2 ds /usr/local/lib/python2.7/dist-packages/xray/core/dataset.pyc in __init__(self, variables, coords, attrs, compat) 317 coords = set() 318 if variables or coords: --> 319 self._set_init_vars_and_dims(variables, coords, compat) 320 if attrs is not None: 321 self.attrs = attrs /usr/local/lib/python2.7/dist-packages/xray/core/dataset.pyc in _set_init_vars_and_dims(self, vars, coords, compat) 371 aligned = _align_variables(variables) 372 new_variables, new_coord_names = _expand_variables(aligned, --> 373 compat=compat) 374 375 new_coord_names.update(coords) /usr/local/lib/python2.7/dist-packages/xray/core/dataset.pyc in _expand_variables(raw_variables, old_variables, compat) 142 add_variable(dim, coord.variable) 143 var = var.variable --> 144 add_variable(name, var) 145 146 return new_variables, new_coord_names /usr/local/lib/python2.7/dist-packages/xray/core/dataset.pyc in add_variable(name, var) 130 raise ValueError('conflicting value for variable %s:\n' 131 'first value: %r\nsecond value: %r' --> 132 % (name, variables[name], var)) 133 if compat == 'broadcast_equals': 134 maybe_promote_or_replace(name, var) ValueError: conflicting value for variable b: first value: array([1, 2, 0]) second value: array([0, 1, 2]) ``` But adding with `__setitem__` aligns as expected: ``` python In [17]: ds ds = xray.Dataset(coords=coords) ds['da']=da_reindex ds Out[17]: Dimensions: (a: 4, b: 3) Coordinates: * a (a) int64 0 1 2 3 * b (b) int64 0 1 2 Data variables: da (a, b) float64 0.05127 0.9546 0.1285 0.2058 0.8027 0.4637 ... ``` Is this desired behavior? I could imagine aligning to coords if they are explicitly supplied, but I don't know the nuances here. ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/674/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,13221727,issue 288382105,MDExOlB1bGxSZXF1ZXN0MTYyODA5ODA3,1828,pytest-ification,5635139,closed,0,,,8,2018-01-14T04:33:17Z,2018-01-15T22:25:33Z,2018-01-15T22:25:30Z,MEMBER,,0,pydata/xarray/pulls/1828,"So far, only the changes that `unittest2pytest` could fix. Need to work out how to sort through the exisiting xarray ones EDIT: ready to merge (and keen to get this in before there are divergences from other branches)","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/1828/reactions"", ""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull