id,node_id,number,title,user,state,locked,assignee,milestone,comments,created_at,updated_at,closed_at,author_association,active_lock_reason,draft,pull_request,body,reactions,performed_via_github_app,state_reason,repo,type
2267711587,PR_kwDOAMm_X85t8VWy,8978,more engine environment tricks in preparation for `numpy>=2`,14808389,closed,0,,,7,2024-04-28T17:54:38Z,2024-04-29T14:56:22Z,2024-04-29T14:56:21Z,MEMBER,,0,pydata/xarray/pulls/8978,"Turns out `pydap` also needs to build with `numpy>=2`. Until it does, we should remove it from the upstream-dev environment. Also, `numcodecs` build-depends on `setuptools-scm`.

And finally, the `h5py` nightlies might support `numpy>=2` (`h5py>=3.11` supposedly is `numpy>=2` compatible), so once again I'll try and see if CI passes.

- [x] towards #8844","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/8978/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull
2078559800,PR_kwDOAMm_X85j6NsC,8605,run CI on `python=3.12`,14808389,closed,0,,,7,2024-01-12T10:47:18Z,2024-01-17T21:54:13Z,2024-01-17T21:54:12Z,MEMBER,,0,pydata/xarray/pulls/8605,- [x] Closes #8580,"{""url"": ""https://api.github.com/repos/pydata/xarray/issues/8605/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull
1845449919,PR_kwDOAMm_X85Xp1U1,8064,adapt to NEP 51,14808389,closed,0,,,7,2023-08-10T15:43:13Z,2023-09-30T09:27:25Z,2023-09-25T04:46:49Z,MEMBER,,0,pydata/xarray/pulls/8064,"With NEP 51 (and the changes to `numpy` `main`), scalar types no longer pretend to be standard python types in their string representation. This fixes most of the errors in the tests but there are still a few remaining in the doctests (in particular, doctests for private plotting utils).

- [x] towards #8091","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/8064/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull
1898193938,PR_kwDOAMm_X85abbJ4,8188,fix the failing docs,14808389,closed,0,,,7,2023-09-15T11:01:42Z,2023-09-20T11:04:03Z,2023-09-15T13:26:24Z,MEMBER,,0,pydata/xarray/pulls/8188,"The docs have been failing because of a malformatted docstring we inherit from `pandas`, and this caused us to miss another error in #8183. The fix is to avoid installing `pandas=2.1.0`, which should be the only version with the malformatted docstring, and to apply the missing changes from #8183 here.

- [x] Closes #8157, follow-up to #8183","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/8188/reactions"", ""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull
1306887842,PR_kwDOAMm_X847g7WQ,6795,display the indexes in the string reprs,14808389,closed,0,,,7,2022-07-16T19:42:19Z,2022-10-15T18:28:36Z,2022-10-12T16:52:53Z,MEMBER,,0,pydata/xarray/pulls/6795,"With the flexible indexes refactor indexes have become much more important, which means we should include them in the reprs of `DataArray` and `Dataset` objects.

This is a initial attempt, covering only the string reprs, with a few unanswered questions:
- how do we format indexes? Do we delegate to their `__repr__` or some other method?
- should we skip `PandasIndex` and `PandasMultiIndex`?
- how do we present indexes that wrap multiple columns? At the moment, they are duplicated (see also the discussion in #6392)
- what do we do with the index marker in the coords repr?

(also, how do we best test this?)

- [ ] Tests added
- [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst`","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/6795/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull
935279688,MDExOlB1bGxSZXF1ZXN0NjgyMjIzODA2,5560,conditionally disable bottleneck,14808389,closed,0,,,7,2021-07-01T23:12:03Z,2021-08-12T15:05:48Z,2021-08-12T14:41:34Z,MEMBER,,0,pydata/xarray/pulls/5560,"As this came up in #5424 (and because I can't seem to reliably reproduce expected values in #4972 if it is enabled) this adds a option to disable `bottleneck`, even if it is installed.

In #5424 it was suggested to also allow replacing `bottleneck` with `numbagg`. If that's something we want (and `numbagg` supports the operations we need) I can try looking into renaming the new option to something like `xr.set_options(accelerate_with=""bottleneck"")` (or something else, if someone has a great idea).

Tests are missing because I have no idea how to check that this works (except by mocking bottleneck).

- [x] Closes #5424
- [x] Tests added
- [x] Passes `pre-commit run --all-files`
- [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst`
","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/5560/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull
896002237,MDExOlB1bGxSZXF1ZXN0NjQ4MTUzNTIy,5352,prefer the objects _repr_inline_ over xarray's custom reprs,14808389,closed,0,,,7,2021-05-19T22:24:19Z,2021-05-25T21:58:00Z,2021-05-25T21:57:57Z,MEMBER,,0,pydata/xarray/pulls/5352,"In preparation of pushing these upstream, this increases the priority of the `_repr_inline_` implementation of `dask` or `sparse` (once they are implemented) over our own custom functions.

- [ ] Tests added
- [x] Passes `pre-commit run --all-files`
- [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst`
","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/5352/reactions"", ""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull
807620560,MDExOlB1bGxSZXF1ZXN0NTcyODM5Mjk3,4902,also apply combine_attrs to the attrs of the variables,14808389,closed,0,,,7,2021-02-12T23:53:49Z,2021-05-05T16:43:08Z,2021-05-05T16:37:25Z,MEMBER,,0,pydata/xarray/pulls/4902,"Follow-up to #4827. The current behavior is to always combine with `combine_attrs=""override""`, even if the caller requested something else.

- [x] follow-up to #4827, closes #4017
- [x] Tests added
- [x] Passes `pre-commit run --all-files`
- [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst`
","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/4902/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull
686848844,MDExOlB1bGxSZXF1ZXN0NDc0MzczMTE4,4381,run black and blackdoc,14808389,closed,0,,,7,2020-08-27T00:23:04Z,2020-08-27T15:12:48Z,2020-08-27T14:56:38Z,MEMBER,,0,pydata/xarray/pulls/4381,"`black` changed their style (format docstrings and trailing comma handling mostly) in their new release. This simply runs that new version of `black` on the repository.

This is a separate PR so reviewing becomes easier.

Since it is an automatic change, this should be ready to be merged once the CI is green.","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/4381/reactions"", ""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull
640740029,MDExOlB1bGxSZXF1ZXN0NDM2MDk0MjQ3,4163,silence UnitStrippedWarnings,14808389,closed,0,,,7,2020-06-17T21:02:16Z,2020-07-02T17:29:28Z,2020-07-02T16:13:59Z,MEMBER,,0,pydata/xarray/pulls/4163,"Now that the tests are cleaned up, it is time to fix the numerous ""unit stripped"" warnings. We'll get there by promoting all `UnitStrippedWarning`s to errors (using `filterwarnings`) and fixing / xfailing the failing tests.

 - [x] Passes `isort -rc . && black . && mypy . && flake8`
 - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API
","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/4163/reactions"", ""total_count"": 2, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 2, ""eyes"": 0}",,,13221727,pull
603930174,MDExOlB1bGxSZXF1ZXN0NDA2NjE5MDkz,3988,built-in accessor documentation,14808389,closed,0,,,7,2020-04-21T11:39:36Z,2020-06-13T17:52:51Z,2020-06-13T17:52:46Z,MEMBER,,0,pydata/xarray/pulls/3988,"We currently use `property` to attach our built-in accessors (`plot`, `dt` and `str`) to the `DataArray` and `Dataset` classes. However, because `property` returns itself when trying to access it as a class attribute, this does not work when generating the documentation (`sphinx` inspects classes, not class instances).

This adds a `property`-like descriptor that works on both classes and instance objects (the name could be more descriptive) and uses that to document the `Dataset.plot.*` and `DataArray.plot.*` methods (see the [rendered documentation](https://xarray-keewis.readthedocs.io/en/accessor-documentation/api.html)). I have not been able to get `sphinx` to work with `_PlotMethods.__slots__`, though.

A few questions / comments on this:
1. I noticed we have `DataArray.plot.__call__` and `xarray.plot.plot` but not `DataArray.plot.plot`. Is that something that is worth adding?

2. The functions decorated with the custom property define docstrings which currently are lost. Should we patch them on their return values?

3. Right now, the error message when accidentally trying to call e.g. `xr.DataArray.plot.line()` is not very helpful:
```pytb
AttributeError: 'NoneType' object has no attribute 'dims'
```

4. Now that we can document the accessors, we need to think about how to structure `api.rst`. For `plot` and `str`, we could just list methods / attributes in subsections of `DataArray` / `Dataset` (or keep the `Plotting` / `str` / ... sections and add class subsections?), but `dt` is more complicated since it dispatches for `datetime` and `timedelta`

 - [x] Closes #3625
 - [x] Passes `isort -rc . && black . && mypy . && flake8`
 - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API

Edit: err, it seems I used the branch I pushed to the main repository for a documentation preview for this...","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/3988/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull
619455327,MDExOlB1bGxSZXF1ZXN0NDE4OTU3NzQ3,4070,remove the backslash escapes and typehint fragments in the API docs,14808389,closed,0,,,7,2020-05-16T11:55:23Z,2020-05-19T16:49:31Z,2020-05-19T16:49:26Z,MEMBER,,0,pydata/xarray/pulls/4070,"The reason for those fragments is that `napoleon` and `numpydoc` somehow conflict with each other. From a quick glance I couldn't find anything that breaks without `numpydoc`, but I might be missing something.

For reference, here's the new [API page](https://xarray-keewis.readthedocs.io/en/fix-signature-escapes/api.html).
 - [x] Closes #3178
 - [x] Passes `isort -rc . && black . && mypy . && flake8`
","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/4070/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull
536639533,MDExOlB1bGxSZXF1ZXN0MzUyMTM2MTEx,3611,Pint support for top-level functions,14808389,closed,0,,,7,2019-12-11T22:04:13Z,2020-03-09T11:35:27Z,2020-03-09T07:40:46Z,MEMBER,,0,pydata/xarray/pulls/3611,"This PR tries to get the pint integration tests (see #3594) to pass. To make sure this does not become a giant PR, it is limited to the top-level functions and the work on the tests for `DataArray` and `Dataset` will be done in other PRs.

I added pint master to the `upstream-dev` CI since that way CI finally helps finding bugs. Should I have edited `py36-min-nep18` instead?

 - [x] Passes `black . && mypy . && flake8`
 - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API

Also, I finally ran into a situation where I have to use `assert_allclose` instead of `assert_equal_with_units`. However, `assert_allclose` does not check for identical units, I think? Would it make sense to copy the code of `assert_allclose` and add the strict unit checking or would it be better to just use `assert_allclose` and something like `assert extract_units(expected) == extract_units(actual)`?

Failing tests list from #3594:
  - `align`: ~needs more investigation~ ~partially blocked by `where`, `IndexVariable` and a bug in `assert_equal_with_units` and / or the tests, also a behaviour decision on align~ works (but units in `IndexVariable` still fail)
  - `combine_by_coords`: ~needs more investigation~ ~partially blocked by `IndexVariable` and a test bug (due to #3483)~ works (but units in `IndexVariable` still fail)
  - `combine_nested`: ~needs more investigation~ ~blocked by `reindex`~ works (but units in `IndexVariable` still fail)
  - `concat`: ~needs more investigation~ works (but units in `IndexVariable` still fail)
  - `merge`: ~needs more investigation~ works (but units in `IndexVariable` still fail)
  - `full_like`: ~`pint` currently does not implement `copyto`~ blocked by hgrecco/pint#882
  - `where`: ~needs more investigation~ ~unit is stripped because `pint` does not implement `astype` and test bug in `test_where_dataset`~ works
  - `dot`: ~`pint` currently does not implement `einsum`~ works","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/3611/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull
532373563,MDExOlB1bGxSZXF1ZXN0MzQ4NjM2MTE1,3592,Silence sphinx warnings: Round 2,14808389,closed,0,,,7,2019-12-04T01:09:30Z,2019-12-06T15:38:54Z,2019-12-06T15:37:46Z,MEMBER,,0,pydata/xarray/pulls/3592,"As a follow-up to #3516, this silences the last warnings without `-n`, so once the doctest issue below is fixed we could replace `-n` with `-W --keep-going` and have the CI fail should a PR introduce new warnings.

There is, however, a problem with the doctest output for the 3D result of `GroupBy.quantile`: since the repr of a DataArray with at least 3 dimensions contains blank lines, it complains about a block quote ending without a blank line.

Also, the complaints from #3516 about duplicate definitions of attributes were caused by the `Attributes` section in the docstring of `DataArray`. I fixed this by removing the whole section, but we probably want to first make sure this does not remove any information (or maybe someone has a different idea?).

 - [x] Passes `black . && mypy . && flake8`
","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/3592/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull
520636106,MDExOlB1bGxSZXF1ZXN0MzM5MTc1NTI3,3508,add missing pint integration tests,14808389,closed,0,,,7,2019-11-10T18:13:49Z,2019-11-10T23:42:14Z,2019-11-10T23:41:52Z,MEMBER,,0,pydata/xarray/pulls/3508,"This adds the tests that were missed by #3238 and #3447.

 - [x] Tests added
 - [x] Passes `black . && mypy . && flake8`
 - [x] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API

This should be ready to merge, but I'm almost certain that while going through #3238 and #3447 and trying to fix obvious mistakes I will find more missing tests.

Missing tests:
* [x] `Dataset.broadcast_like` and `DataArray.broadcast_like`
* [x] `DataArray.head`, `DataArray.tail` and `DataArray.thin`","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/3508/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull
496826564,MDExOlB1bGxSZXF1ZXN0MzIwMDc4MzQ1,3333,More doc fixes,14808389,closed,0,,,7,2019-09-22T20:09:36Z,2019-09-23T10:46:34Z,2019-09-23T01:08:43Z,MEMBER,,0,pydata/xarray/pulls/3333,"While going through the docs, I noticed several issues:
* in `reshaping.rst`, a code block gets hidden because of a missing newline
* in `api.rst`, the section `What parts of xarray are considered public API?` is referenced (I think), but the link is broken.
* the code samples in `DataArray.plot` are not recognized as such because of missing newlines
* the documentation of `Dataset.plot.scatter` in the API reference is broken

This PR tries to fix all of those, but while the first three issues are easy to fix, I'm not sure whether my proposed fix for the one involving `scatter` is correct: I've added `plot.dataset_plot.scatter` to `plot.__all__` (exposing `xr.plot.scatter`) and changed `api.rst` to reference `plot.scatter` instead of `Dataset.plot.scatter`. It seems harmless to me, but the information that `scatter` only exists for `Dataset` is less visible. Is that the way to fix this?

 - [x] Passes `black . && mypy . && flake8`
 - [ ] Fully documented, including `whats-new.rst` for all changes and `api.rst` for new API
","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/3333/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull