id,node_id,number,title,user,state,locked,assignee,milestone,comments,created_at,updated_at,closed_at,author_association,active_lock_reason,draft,pull_request,body,reactions,performed_via_github_app,state_reason,repo,type 2021528727,PR_kwDOAMm_X85g7vZA,8502,change type of curvefit's p0 and bounds to mapping,43316012,closed,0,,,0,2023-12-01T20:18:19Z,2023-12-02T13:08:50Z,2023-12-01T22:02:38Z,COLLABORATOR,,0,pydata/xarray/pulls/8502," - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` Mini PR to improve the typing of curvefit. Using `dict` is problematic since it is invariant, while Mapping is `covariant`.","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/8502/reactions"", ""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 1620509524,PR_kwDOAMm_X85L19Mo,7616,add a test for scatter colorbar extend,43316012,closed,0,,,0,2023-03-12T20:58:45Z,2023-03-13T19:47:50Z,2023-03-13T19:47:50Z,COLLABORATOR,,0,pydata/xarray/pulls/7616," - [x] Closes #4975","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/7616/reactions"", ""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 1411110855,PR_kwDOAMm_X85A59Gg,7176,Add import ASV benchmark,43316012,closed,0,,,0,2022-10-17T08:11:58Z,2022-10-17T17:47:59Z,2022-10-17T15:25:18Z,COLLABORATOR,,0,pydata/xarray/pulls/7176,related to https://github.com/pydata/xarray/issues/6726,"{""url"": ""https://api.github.com/repos/pydata/xarray/issues/7176/reactions"", ""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 1393482925,PR_kwDOAMm_X84__h6j,7113,Minor tests improvements,43316012,closed,0,,,0,2022-10-01T17:19:42Z,2022-10-16T13:56:28Z,2022-10-02T15:38:16Z,COLLABORATOR,,0,pydata/xarray/pulls/7113,"- silences some user warning from renaming dims. - fix coverage config","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/7113/reactions"", ""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 1347715262,I_kwDOAMm_X85QVIC-,6949,Plot accessors miss static typing,43316012,closed,0,,,0,2022-08-23T10:38:56Z,2022-10-16T09:26:55Z,2022-10-16T09:26:55Z,COLLABORATOR,,,,"### What happened? The plot accessors i.e. `dataarray.plot` of type `_PlotMethods` are missing static typing especially of function attributes. See #6947 for an example. The problem is that many plotting methods are added using hooks via decorators, something that mypy does not understand. ### What did you expect to happen? As a quick fix: type the plot accessors as `_PlotMethods | Any` to avoid false positives in mypy. Better to either restructure the accessor with static methods instead of hooks or figure out another way of telling static type checkers about these methods. Anyway: mypy should not complain. ### Minimal Complete Verifiable Example ```Python import xarray as xr da = xr.DataArray([[1,2,3], [4,5,6]], dims=[""x"", ""y""]) da.plot.contourf(x=""x"", y=""y"") # mypy complains: # error: ""_PlotMethods"" has no attribute ""contourf"" ``` ### MVCE confirmation - [X] Minimal example — the example is as focused as reasonably possible to demonstrate the underlying issue in xarray. - [X] Complete example — the example is self-contained, including all data and the text of any traceback. - [X] Verifiable example — the example copy & pastes into an IPython prompt or [Binder notebook](https://mybinder.org/v2/gh/pydata/xarray/main?urlpath=lab/tree/doc/examples/blank_template.ipynb), returning the result. - [X] New issue — a search of GitHub Issues suggests this is not a duplicate. ### Relevant log output _No response_ ### Anything else we need to know? _No response_ ### Environment On mobile, can edit it later if required. Newest xarray should have this problem, before the accessor was Any.","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/6949/reactions"", ""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,13221727,issue 1401013957,PR_kwDOAMm_X85AYtU2,7140,Fixes deepcopy of Index,43316012,closed,0,,,0,2022-10-07T11:18:10Z,2022-10-07T21:57:12Z,2022-10-07T21:57:12Z,COLLABORATOR,,0,pydata/xarray/pulls/7140,"Forgot to add this to #7112 Also, correct the date of the 2022.09 release in whats-new, see #7135 ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/7140/reactions"", ""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 1386664116,PR_kwDOAMm_X84_o0Jy,7087,Add typing to FacetGrid,43316012,closed,0,,,0,2022-09-26T20:16:26Z,2022-09-28T20:15:53Z,2022-09-28T18:30:59Z,COLLABORATOR,,0,pydata/xarray/pulls/7087,Mainly to annoy @Illviljan :),"{""url"": ""https://api.github.com/repos/pydata/xarray/issues/7087/reactions"", ""total_count"": 4, ""+1"": 1, ""-1"": 0, ""laugh"": 3, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 917034151,MDU6SXNzdWU5MTcwMzQxNTE=,5458,DataArray.rename docu missing renaming of dimensions,43316012,closed,0,,,0,2021-06-10T07:57:11Z,2022-07-18T14:48:02Z,2022-07-18T14:48:02Z,COLLABORATOR,,,,"**What happened**: http://xarray.pydata.org/en/stable/generated/xarray.DataArray.rename.html#xarray.DataArray.rename states that: > Returns a new DataArray with renamed coordinates or a new name. **What you expected to happen**: It should state: ""Returns a new DataArray with renamed coordinates, dimensions or a new name."" Since it definitely can do that. **Minimal example** ``` xr.DataArray([1, 2, 3]).rename({""dim_0"": ""new""}) ``` **Further** While at it: Dataset.rename als does not mention explicitly that you can rename coordinates.","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/5458/reactions"", ""total_count"": 2, ""+1"": 2, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,13221727,issue 1292291988,PR_kwDOAMm_X846wMD8,6750,Add import change to whats-new,43316012,closed,0,,,0,2022-07-03T12:19:01Z,2022-07-12T18:09:40Z,2022-07-06T03:06:31Z,COLLABORATOR,,0,pydata/xarray/pulls/6750,"- [x] Closes #6741 - [x] ~~Tests added~~ - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - [x] ~~New functions/methods are listed in `api.rst`~~ ","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/6750/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull 1120378011,I_kwDOAMm_X85Cx5yb,6227,"[Bug]: Dataset.where(x, drop=True) behaves inconsistent",43316012,closed,0,,,0,2022-02-01T08:40:30Z,2022-06-12T22:06:51Z,2022-06-12T22:06:51Z,COLLABORATOR,,,,"### What happened? I tried to reduce some dimensions using where (sel did not work in this case) and shorten the dimensions with ""drop=True"". This works fine on DataArrays and Datasets with only a single dimension but fails as soon as you have a Dataset with two dimensions on different variables. The dimensions are left untouched and you have NaNs in the data, just as if you were using ""drop=False"" (see example). I am actually not sure what the expected behavior is, maybe I am wrong and it is correct due to some broadcasting rules? ### What did you expect to happen? I expected that relevant dims are shortened. If the `ds.where` with ""drop=False"" all variables along a dimenions have some NaNs, then using ""drop=True"" I expect these dimensions to be shortened and the NaNs removed. ### Minimal Complete Verifiable Example ```python import xarray as xr # this works ds = xr.Dataset({""a"": (""x"", [1, 2 ,3])}) ds.where(ds > 2, drop=True) # returns: # # Dimensions: (x: 1) # Dimensions without coordinates: x # Data variables: # a (x) float64 3.0 # this doesn't ds = xr.Dataset({""a"": (""x"", [1, 2 ,3]), ""b"": (""y"", [2, 3, 4])}) ds.where(ds > 2, drop=True) # returns: # # Dimensions: (x: 3, y: 3) # Dimensions without coordinates: x, y # Data variables: # a (x) float64 nan nan 3.0 # b (y) float64 nan 3.0 4.0 ``` ### Relevant log output _No response_ ### Anything else we need to know? _No response_ ### Environment INSTALLED VERSIONS ------------------ commit: None python: 3.9.1 (default, Jan 13 2021, 15:21:08) [GCC 4.8.5 20150623 (Red Hat 4.8.5-44)] python-bits: 64 OS: Linux OS-release: 3.10.0-1160.49.1.el7.x86_64 machine: x86_64 processor: x86_64 byteorder: little LC_ALL: None LANG: en_US.UTF-8 LOCALE: ('en_US', 'UTF-8') libhdf5: 1.12.0 libnetcdf: 4.7.4 xarray: 0.20.2 pandas: 1.3.5 numpy: 1.21.5 scipy: 1.7.3 netCDF4: 1.5.8 pydap: None h5netcdf: None h5py: None Nio: None zarr: None cftime: 1.5.1.1 nc_time_axis: None PseudoNetCDF: None rasterio: None cfgrib: None iris: None bottleneck: None dask: None distributed: None matplotlib: 3.5.1 cartopy: None seaborn: None numbagg: None fsspec: None cupy: None pint: None sparse: None setuptools: 49.2.1 pip: 22.0.2 conda: None pytest: 6.2.5 IPython: 8.0.0 sphinx: None","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/6227/reactions"", ""total_count"": 2, ""+1"": 2, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed,13221727,issue 1244978704,PR_kwDOAMm_X844SHU7,6630,"fix {full,zeros,ones}_like overloads",43316012,closed,0,,,0,2022-05-23T10:57:36Z,2022-05-27T06:32:37Z,2022-05-24T04:41:22Z,COLLABORATOR,,0,pydata/xarray/pulls/6630," - [x] Closes #6628 - [x] Tests added forgot to add defaults to the dtype argument, so the typing defaulted back to the Union definition...","{""url"": ""https://api.github.com/repos/pydata/xarray/issues/6630/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,,13221727,pull