issue_comments

Table actions

4 rows where user = 9948595 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

user 1

  • arabidopsis · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
613845875 https://github.com/pydata/xarray/issues/3972#issuecomment-613845875 https://api.github.com/repos/pydata/xarray/issues/3972 MDEyOklzc3VlQ29tbWVudDYxMzg0NTg3NQ== arabidopsis 9948595 2020-04-15T06:36:48Z 2020-04-15T06:36:48Z CONTRIBUTOR

OK PR done #3973 Sorry I forgot to create a new branch... hope that's OK.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Variable objects not displayable in notebook 599993415
487329592 https://github.com/pydata/xarray/pull/2924#issuecomment-487329592 https://api.github.com/repos/pydata/xarray/issues/2924 MDEyOklzc3VlQ29tbWVudDQ4NzMyOTU5Mg== arabidopsis 9948595 2019-04-28T00:21:15Z 2019-04-28T00:21:15Z CONTRIBUTOR

No problem. Thanks for xarray!

Just a question. I put a guard in to test just for tuples (because that's what was breaking for me) but it seems to me that _nan_minmax_object should just return utils.to_0d_object_array(data) unconditionally at that point no? It's a max or a min right.

Wasn't sure.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix multiIndex min max issue #2923 437956917
487298047 https://github.com/pydata/xarray/pull/2924#issuecomment-487298047 https://api.github.com/repos/pydata/xarray/issues/2924 MDEyOklzc3VlQ29tbWVudDQ4NzI5ODA0Nw== arabidopsis 9948595 2019-04-27T16:04:45Z 2019-04-27T16:04:45Z CONTRIBUTOR

Oops... I usually use black -- which I turned off since it would really have stuffed the code :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix multiIndex min max issue #2923 437956917
487291300 https://github.com/pydata/xarray/issues/2923#issuecomment-487291300 https://api.github.com/repos/pydata/xarray/issues/2923 MDEyOklzc3VlQ29tbWVudDQ4NzI5MTMwMA== arabidopsis 9948595 2019-04-27T14:38:12Z 2019-04-27T14:38:12Z CONTRIBUTOR

Seems that the problem begins when xarray.core.nanops._nan_minmax_object converts the max index value (2,99) tuple (which is correct) to np.array((0,99), dtype='O') which is not because np.array converts this from dims=() to dims=(2,).

Which is now incorrect. Interesting... how do you tell numpy to create a 0 dimension array with a tuple?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Calling max() on a stacked dimension raises exception 437940426

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);