issue_comments

Table actions

3 rows where user = 9049976 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, reactions, created_at (date), updated_at (date)

user 1

  • tammasloughran · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
822700398 https://github.com/pydata/xarray/pull/5174#issuecomment-822700398 https://api.github.com/repos/pydata/xarray/issues/5174 MDEyOklzc3VlQ29tbWVudDgyMjcwMDM5OA== tammasloughran 9049976 2021-04-19T18:56:27Z 2021-04-19T18:57:00Z CONTRIBUTOR

I don't quite understand understand what you mean. Like this?

Forgive me not being clear. The current test with the version check is great. And I hadn't realized there was a released dask version — even better that the test is already running on both versions of the code.

Well... I see now there is also a duplicate test here, which fails when using the newer dask version. I don't understand why xarray goes to all the trouble of directly unit testing an external library. Makes more sense to me to only test the xarray wrapper for the dask functionality. I could add another version check there, or remove that test. What do you think?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable __setitem__ for dask versions that support it. 860073545
822380259 https://github.com/pydata/xarray/pull/5174#issuecomment-822380259 https://api.github.com/repos/pydata/xarray/issues/5174 MDEyOklzc3VlQ29tbWVudDgyMjM4MDI1OQ== tammasloughran 9049976 2021-04-19T11:01:33Z 2021-04-19T11:01:33Z CONTRIBUTOR

Are there any current tests for the error that break on the new version (i.e. because it doesn't raise an error)?

I don't quite understand understand what you mean. Like this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable __setitem__ for dask versions that support it. 860073545
821451925 https://github.com/pydata/xarray/issues/5171#issuecomment-821451925 https://api.github.com/repos/pydata/xarray/issues/5171 MDEyOklzc3VlQ29tbWVudDgyMTQ1MTkyNQ== tammasloughran 9049976 2021-04-16T18:43:10Z 2021-04-16T18:43:10Z CONTRIBUTOR

PR #5174 . This is a start. I'm not too familiar with the inner workings of xarray, so it might need more work.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dask now supports item assignment. Shouldn't xarray support it too? 859933298

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);