issue_comments

Table actions

5 rows where user = 6645714 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

user 1

  • petercable · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
270737056 https://github.com/pydata/xarray/issues/1193#issuecomment-270737056 https://api.github.com/repos/pydata/xarray/issues/1193 MDEyOklzc3VlQ29tbWVudDI3MDczNzA1Ng== petercable 6645714 2017-01-05T19:38:47Z 2017-01-05T20:01:34Z CONTRIBUTOR

I found that changing char_to_string resulted in dropping the 0 length dimension:

before:

<xarray.Dataset> Dimensions: (dim0: 1, dim1: 0) Coordinates: * dim0 (dim0) int64 0 * dim1 (dim1) int64 Data variables: x (dim0, dim1) |S1

after:

<xarray.Dataset> Dimensions: (dim0: 1) Coordinates: * dim0 (dim0) int64 0 Data variables: x (dim0) |S1

So, instead I modified conventions.decode_cf_variable to not wrap character arrays with a terminal zero length dimension as CharToStringArray:

if concat_characters: if data.dtype.kind == 'S' and data.dtype.itemsize == 1 and data.shape[-1] != 0: dimensions = dimensions[:-1] data = CharToStringArray(data)

And this appears to round-trip correctly.

EDIT: fixed output when modifying char_to_string

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Reading netcdf containing empty N-d string arrays causes exception 199032440
149673897 https://github.com/pydata/xarray/pull/633#issuecomment-149673897 https://api.github.com/repos/pydata/xarray/issues/633 MDEyOklzc3VlQ29tbWVudDE0OTY3Mzg5Nw== petercable 6645714 2015-10-20T19:19:17Z 2015-10-20T19:19:17Z CONTRIBUTOR

Done!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove all mutable arguments from functions 112424213
130761187 https://github.com/pydata/xarray/pull/529#issuecomment-130761187 https://api.github.com/repos/pydata/xarray/issues/529 MDEyOklzc3VlQ29tbWVudDEzMDc2MTE4Nw== petercable 6645714 2015-08-13T17:01:16Z 2015-08-13T17:01:16Z CONTRIBUTOR

Any idea why the new test class is failing in python 3.4? I would expect the corresponding netcdf3 tests to fail as well, unless they are disabled.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Issue #526 F8 values are incorrectly coerced to F4 when writing NETCD… 100692054
130536778 https://github.com/pydata/xarray/issues/526#issuecomment-130536778 https://api.github.com/repos/pydata/xarray/issues/526 MDEyOklzc3VlQ29tbWVudDEzMDUzNjc3OA== petercable 6645714 2015-08-13T05:06:46Z 2015-08-13T05:08:02Z CONTRIBUTOR

I did some more investigating while working on a fix for this issue. It turns out that only the F8 format is supported and this fix is applicable to all NETCDF3-compatible formats.

https://www.unidata.ucar.edu/software/netcdf/docs/netcdf-c/NetCDF_002d3-Variable-Types.html

| Type | C #define | Bits | | --- | --- | --- | | byte | NC_BYTE | 8 | | char | NC_CHAR | 8 | | short | NC_SHORT | 16 | | int | NC_INT | 32 | | float | NC_FLOAT | 32 | | double | NC_DOUBLE | 64 |

I have updated the issue title to reflect this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   64-bit values are coerced to 32-bit when writing as NETCDF4_CLASSIC 100601294
130416921 https://github.com/pydata/xarray/issues/526#issuecomment-130416921 https://api.github.com/repos/pydata/xarray/issues/526 MDEyOklzc3VlQ29tbWVudDEzMDQxNjkyMQ== petercable 6645714 2015-08-12T19:19:51Z 2015-08-12T19:19:51Z CONTRIBUTOR

Sure, I'll take a look at it tonight if I get a chance. Do you need corresponding unit tests for any changes? I haven't looked...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   64-bit values are coerced to 32-bit when writing as NETCDF4_CLASSIC 100601294

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);