issue_comments

Table actions

6 rows where user = 6145107 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, reactions, created_at (date), updated_at (date)

user 1

  • abrammer · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1529130077 https://github.com/pydata/xarray/pull/7798#issuecomment-1529130077 https://api.github.com/repos/pydata/xarray/issues/7798 IC_kwDOAMm_X85bJKxd abrammer 6145107 2023-04-30T20:15:24Z 2023-04-30T20:20:21Z CONTRIBUTOR

Apologies, that's my bad. Looks like I introduced a broken test and didn't manually double check the results coming back. The right shift test should have been:

``` python right_expected = Dataset( { "x": ("index", [0, 0, 2, 2]), "y": ("index", [-1, -1, -2, -2]), "level": ("index", [0, 0, 4, 4]), "index": [0, 1, 2, 3], } )

right_actual = (left_expected.groupby("level") >> shift).reset_coords(names="level")
assert_equal(right_expected, right_actual)

```

I haven't paid attention to this issue, but doing the groupby manually didn't have the bug fwiw.

Probably overkill test that only fails at the last assert before this fix

```python def test_groupby_math_bitshift() -> None: # create new dataset of int's only ds = Dataset( { "x": ("index", np.ones(4, dtype=int)), "y": ("index", np.ones(4, dtype=int) * -1), "level": ("index", [1, 1, 2, 2]), "index": [0, 1, 2, 3], } ) shift = DataArray([1, 2, 1], [("level", [1, 2, 8])]) left_expected = Dataset( { "x": ("index", [2, 2, 4, 4]), "y": ("index", [-2, -2, -4, -4]), "level": ("index", [2, 2, 8, 8]), "index": [0, 1, 2, 3], } ) left_manual = [] for lev, group in ds.groupby("level"): shifter = shift.sel(level=lev) left_manual.append(group << shifter) left_actual = xr.concat(left_manual, dim="index").reset_coords(names="level") assert_equal(left_expected, left_actual) left_actual = (ds.groupby("level") << shift).reset_coords(names="level") assert_equal(left_expected, left_actual) right_expected = Dataset( { "x": ("index", [0, 0, 2, 2]), "y": ("index", [-1, -1, -2, -2]), "level": ("index", [0, 0, 4, 4]), "index": [0, 1, 2, 3], } ) right_manual = [] for lev, group in left_expected.groupby("level"): shifter = shift.sel(level=lev) right_manual.append(group >> shifter) right_actual = xr.concat(right_manual, dim="index").reset_coords(names="level") assert_equal(right_expected, right_actual) right_actual = (left_expected.groupby("level") >> shift).reset_coords(names="level") assert_equal(right_expected, right_actual) ``` 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix groupby binary ops when grouped array is subset relative to other 1689773381
1524063361 https://github.com/pydata/xarray/pull/7741#issuecomment-1524063361 https://api.github.com/repos/pydata/xarray/issues/7741 IC_kwDOAMm_X85a11yB abrammer 6145107 2023-04-26T21:24:14Z 2023-04-26T21:24:14Z CONTRIBUTOR

The commits yesterday were to add an entry to whats-new and a couple examples lines to the computation doc page. I didn't find the binary_ops listed in methods anywhere, so this was the best idea I had? In the block just above missing-values: https://xray--7741.org.readthedocs.build/en/7741/user-guide/computation.html#missing-values

Otherwise, I think this is done from my perspective. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add lshift and rshift operators 1659654612
496036760 https://github.com/pydata/xarray/pull/2144#issuecomment-496036760 https://api.github.com/repos/pydata/xarray/issues/2144 MDEyOklzc3VlQ29tbWVudDQ5NjAzNjc2MA== abrammer 6145107 2019-05-26T22:32:29Z 2019-05-26T22:32:29Z CONTRIBUTOR

@dopplershift I built from your start here, over in #2989 and keeping your initial code and tests along with an edited version of your what's-new. Kept you in the what's new, so hope that's cool otherwise lmk. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add strftime() to datetime accessor 323823894
495723917 https://github.com/pydata/xarray/pull/2144#issuecomment-495723917 https://api.github.com/repos/pydata/xarray/issues/2144 MDEyOklzc3VlQ29tbWVudDQ5NTcyMzkxNw== abrammer 6145107 2019-05-24T17:35:59Z 2019-05-24T17:35:59Z CONTRIBUTOR

I took a stab at this after being reminded about it. https://github.com/abrammer/xarray/tree/strftime_addition Can open a new PR if this one has gone stale. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add strftime() to datetime accessor 323823894
424100894 https://github.com/pydata/xarray/pull/2144#issuecomment-424100894 https://api.github.com/repos/pydata/xarray/issues/2144 MDEyOklzc3VlQ29tbWVudDQyNDEwMDg5NA== abrammer 6145107 2018-09-24T19:45:54Z 2018-09-24T19:54:11Z CONTRIBUTOR

ok, thanks. Anything an outsider can help with?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add strftime() to datetime accessor 323823894
424096368 https://github.com/pydata/xarray/pull/2144#issuecomment-424096368 https://api.github.com/repos/pydata/xarray/issues/2144 MDEyOklzc3VlQ29tbWVudDQyNDA5NjM2OA== abrammer 6145107 2018-09-24T19:30:09Z 2018-09-24T19:30:09Z CONTRIBUTOR

Was looking for this functionality and came across the parent issue and this work around, did this just get forgotten or was there more work to be done? It'd be great to have this functionality readily available without having to work around. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add strftime() to datetime accessor 323823894

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);