issue_comments

Table actions

16 rows where user = 490531 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, reactions, created_at (date), updated_at (date)

user 1

  • ArchangeGabriel · 16 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
800565107 https://github.com/pydata/xarray/issues/5038#issuecomment-800565107 https://api.github.com/repos/pydata/xarray/issues/5038 MDEyOklzc3VlQ29tbWVudDgwMDU2NTEwNw== ArchangeGabriel 490531 2021-03-16T20:03:33Z 2021-03-16T20:04:19Z CONTRIBUTOR

Thanks to both of you as well as @eli-schwartz, it was indeed setuptools-scm missing (and apparently had been since 0.15.0, but previous setuptools version were silently downloading it through easy_install it seems).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [tests] ImportError: Pandas requires version '0.12.3' or newer of 'xarray' (version '0.0.0' currently installed).  832404698
800164034 https://github.com/pydata/xarray/issues/5038#issuecomment-800164034 https://api.github.com/repos/pydata/xarray/issues/5038 MDEyOklzc3VlQ29tbWVudDgwMDE2NDAzNA== ArchangeGabriel 490531 2021-03-16T11:03:51Z 2021-03-16T11:03:51Z CONTRIBUTOR

I’ve used the one from Pypi.

I’ll check with @FFY00 whether I should be switching to build then.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [tests] ImportError: Pandas requires version '0.12.3' or newer of 'xarray' (version '0.0.0' currently installed).  832404698
799982702 https://github.com/pydata/xarray/issues/5038#issuecomment-799982702 https://api.github.com/repos/pydata/xarray/issues/5038 MDEyOklzc3VlQ29tbWVudDc5OTk4MjcwMg== ArchangeGabriel 490531 2021-03-16T06:12:05Z 2021-03-16T06:12:05Z CONTRIBUTOR

Actually while disabling tests and keeping on packaging, I indeed see a reported version of 0.0.0 for xarray. Our diff checker grabbed this: usr/lib/python3.9/site-packages/xarray-0.16.2-py3.9.egg-info/ | usr/lib/python3.9/site-packages/xarray-0.0.0-py3.9.egg-info/ So maybe there is something wrong in the 0.17.0 tarball?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [tests] ImportError: Pandas requires version '0.12.3' or newer of 'xarray' (version '0.0.0' currently installed).  832404698
799980456 https://github.com/pydata/xarray/issues/5038#issuecomment-799980456 https://api.github.com/repos/pydata/xarray/issues/5038 MDEyOklzc3VlQ29tbWVudDc5OTk4MDQ1Ng== ArchangeGabriel 490531 2021-03-16T06:07:37Z 2021-03-16T06:07:37Z CONTRIBUTOR

It’s not installed, I’m building it from source. So I run those command from within the cloned tarball: python setup.py build pytest --deselect xarray/tests/test_distributed.py::test_serializable_locks

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [tests] ImportError: Pandas requires version '0.12.3' or newer of 'xarray' (version '0.0.0' currently installed).  832404698
749791484 https://github.com/pydata/xarray/issues/4281#issuecomment-749791484 https://api.github.com/repos/pydata/xarray/issues/4281 MDEyOklzc3VlQ29tbWVudDc0OTc5MTQ4NA== ArchangeGabriel 490531 2020-12-22T21:47:50Z 2020-12-22T21:47:50Z CONTRIBUTOR

The error seems variable indeed, this time I got error.log.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Test failure in test_serializable_locks 667055142
589032374 https://github.com/pydata/xarray/issues/3266#issuecomment-589032374 https://api.github.com/repos/pydata/xarray/issues/3266 MDEyOklzc3VlQ29tbWVudDU4OTAzMjM3NA== ArchangeGabriel 490531 2020-02-20T13:48:15Z 2020-02-20T13:48:15Z CONTRIBUTOR

These are the (much less numerous) warnings without pint: ``` =============================== warnings summary =============================== xarray/tests/test_accessor_str.py::test_empty_str_methods xarray/tests/test_accessor_str.py::test_empty_str_methods xarray/tests/test_accessor_str.py::test_empty_str_methods xarray/tests/test_accessor_str.py::test_empty_str_methods xarray/tests/test_accessor_str.py::test_empty_str_methods xarray/tests/test_accessor_str.py::test_empty_str_methods xarray/tests/test_accessor_str.py::test_empty_str_methods xarray/tests/test_accessor_str.py::test_empty_str_methods xarray/tests/test_accessor_str.py::test_empty_str_methods /build/python-xarray/src/xarray-0.15.0/xarray/core/duck_array_ops.py:224: FutureWarning: elementwise comparison failed; returning scalar instead, but in the future will perform elementwise comparison flag_array = (arr1 == arr2) | (isnull(arr1) & isnull(arr2))

xarray/tests/test_backends.py::TestNetCDF4Data::test_orthogonal_indexing xarray/tests/test_backends.py::TestNetCDF4Data::test_orthogonal_indexing xarray/tests/test_backends.py::TestNetCDF4Data::test_orthogonal_indexing xarray/tests/test_backends.py::TestNetCDF4Data::test_orthogonal_indexing xarray/tests/test_backends.py::TestNetCDF4Data::test_vectorized_indexing xarray/tests/test_backends.py::TestNetCDF4Data::test_vectorized_indexing xarray/tests/test_backends.py::TestNetCDF4Data::test_vectorized_indexing xarray/tests/test_backends.py::TestNetCDF4Data::test_vectorized_indexing xarray/tests/test_backends.py::TestNetCDF4Data::test_vectorized_indexing xarray/tests/test_backends.py::TestNetCDF4Data::test_vectorized_indexing xarray/tests/test_backends.py::TestNetCDF4Data::test_vectorized_indexing xarray/tests/test_backends.py::TestNetCDF4Data::test_vectorized_indexing xarray/tests/test_backends.py::TestNetCDF4Data::test_array_type_after_indexing xarray/tests/test_backends.py::TestNetCDF4Data::test_array_type_after_indexing xarray/tests/test_backends.py::TestNetCDF4Data::test_array_type_after_indexing xarray/tests/test_backends.py::TestNetCDF4Data::test_array_type_after_indexing xarray/tests/test_backends.py::TestNetCDF3ViaNetCDF4Data::test_orthogonal_indexing xarray/tests/test_backends.py::TestNetCDF3ViaNetCDF4Data::test_orthogonal_indexing xarray/tests/test_backends.py::TestNetCDF3ViaNetCDF4Data::test_orthogonal_indexing xarray/tests/test_backends.py::TestNetCDF3ViaNetCDF4Data::test_orthogonal_indexing xarray/tests/test_backends.py::TestNetCDF3ViaNetCDF4Data::test_vectorized_indexing xarray/tests/test_backends.py::TestNetCDF3ViaNetCDF4Data::test_vectorized_indexing xarray/tests/test_backends.py::TestNetCDF3ViaNetCDF4Data::test_vectorized_indexing xarray/tests/test_backends.py::TestNetCDF3ViaNetCDF4Data::test_vectorized_indexing xarray/tests/test_backends.py::TestNetCDF3ViaNetCDF4Data::test_vectorized_indexing xarray/tests/test_backends.py::TestNetCDF3ViaNetCDF4Data::test_vectorized_indexing xarray/tests/test_backends.py::TestNetCDF3ViaNetCDF4Data::test_vectorized_indexing xarray/tests/test_backends.py::TestNetCDF3ViaNetCDF4Data::test_vectorized_indexing xarray/tests/test_backends.py::TestNetCDF3ViaNetCDF4Data::test_array_type_after_indexing xarray/tests/test_backends.py::TestNetCDF3ViaNetCDF4Data::test_array_type_after_indexing xarray/tests/test_backends.py::TestNetCDF3ViaNetCDF4Data::test_array_type_after_indexing xarray/tests/test_backends.py::TestNetCDF3ViaNetCDF4Data::test_array_type_after_indexing xarray/tests/test_backends.py::TestNetCDF4ClassicViaNetCDF4Data::test_orthogonal_indexing xarray/tests/test_backends.py::TestNetCDF4ClassicViaNetCDF4Data::test_orthogonal_indexing xarray/tests/test_backends.py::TestNetCDF4ClassicViaNetCDF4Data::test_orthogonal_indexing xarray/tests/test_backends.py::TestNetCDF4ClassicViaNetCDF4Data::test_orthogonal_indexing xarray/tests/test_backends.py::TestNetCDF4ClassicViaNetCDF4Data::test_vectorized_indexing xarray/tests/test_backends.py::TestNetCDF4ClassicViaNetCDF4Data::test_vectorized_indexing xarray/tests/test_backends.py::TestNetCDF4ClassicViaNetCDF4Data::test_vectorized_indexing xarray/tests/test_backends.py::TestNetCDF4ClassicViaNetCDF4Data::test_vectorized_indexing xarray/tests/test_backends.py::TestNetCDF4ClassicViaNetCDF4Data::test_vectorized_indexing xarray/tests/test_backends.py::TestNetCDF4ClassicViaNetCDF4Data::test_vectorized_indexing xarray/tests/test_backends.py::TestNetCDF4ClassicViaNetCDF4Data::test_vectorized_indexing xarray/tests/test_backends.py::TestNetCDF4ClassicViaNetCDF4Data::test_vectorized_indexing xarray/tests/test_backends.py::TestNetCDF4ClassicViaNetCDF4Data::test_array_type_after_indexing xarray/tests/test_backends.py::TestNetCDF4ClassicViaNetCDF4Data::test_array_type_after_indexing xarray/tests/test_backends.py::TestNetCDF4ClassicViaNetCDF4Data::test_array_type_after_indexing xarray/tests/test_backends.py::TestNetCDF4ClassicViaNetCDF4Data::test_array_type_after_indexing xarray/tests/test_backends.py::TestGenericNetCDFData::test_orthogonal_indexing xarray/tests/test_backends.py::TestGenericNetCDFData::test_orthogonal_indexing xarray/tests/test_backends.py::TestGenericNetCDFData::test_orthogonal_indexing xarray/tests/test_backends.py::TestGenericNetCDFData::test_orthogonal_indexing xarray/tests/test_backends.py::TestGenericNetCDFData::test_vectorized_indexing xarray/tests/test_backends.py::TestGenericNetCDFData::test_vectorized_indexing xarray/tests/test_backends.py::TestGenericNetCDFData::test_vectorized_indexing xarray/tests/test_backends.py::TestGenericNetCDFData::test_vectorized_indexing xarray/tests/test_backends.py::TestGenericNetCDFData::test_vectorized_indexing xarray/tests/test_backends.py::TestGenericNetCDFData::test_vectorized_indexing xarray/tests/test_backends.py::TestGenericNetCDFData::test_vectorized_indexing xarray/tests/test_backends.py::TestGenericNetCDFData::test_vectorized_indexing xarray/tests/test_backends.py::TestGenericNetCDFData::test_array_type_after_indexing xarray/tests/test_backends.py::TestGenericNetCDFData::test_array_type_after_indexing xarray/tests/test_backends.py::TestGenericNetCDFData::test_array_type_after_indexing xarray/tests/test_backends.py::TestGenericNetCDFData::test_array_type_after_indexing <array_function internals>:5: DeprecationWarning: np.alen is deprecated, use len instead

xarray/tests/test_concat.py::test_concat_compat /build/python-xarray/src/xarray-0.15.0/xarray/core/dataarray.py:669: FutureWarning: elementwise comparison failed; returning scalar instead, but in the future will perform elementwise comparison return key in self.data

xarray/tests/test_dataarray.py::TestDataArray::test_stack_unstack /usr/lib/python3.8/site-packages/pandas/util/init.py:12: FutureWarning: pandas.util.testing is deprecated. Use the functions in the public API at pandas.testing instead. import pandas.util.testing

xarray/tests/test_dataarray.py::TestDataArray::test_to_and_from_empty_series /build/python-xarray/src/xarray-0.15.0/xarray/tests/test_dataarray.py:3468: DeprecationWarning: The default dtype for empty Series will be 'object' instead of 'float64' in a future version. Specify a dtype explicitly to silence this warning. expected = pd.Series([])

xarray/tests/test_duck_array_ops.py::test_datetime_mean[False] xarray/tests/test_duck_array_ops.py::test_datetime_mean[False] xarray/tests/test_groupby.py::test_groupby_drops_nans /build/python-xarray/src/xarray-0.15.0/xarray/core/nanops.py:142: RuntimeWarning: Mean of empty slice return np.nanmean(a, axis=axis, dtype=dtype) ```

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Warnings in the test suite 485446209
588298652 https://github.com/pydata/xarray/issues/3779#issuecomment-588298652 https://api.github.com/repos/pydata/xarray/issues/3779 MDEyOklzc3VlQ29tbWVudDU4ODI5ODY1Mg== ArchangeGabriel 490531 2020-02-19T16:08:01Z 2020-02-19T16:08:01Z CONTRIBUTOR

Well, the thing is we don’t package dask (yet!), so I tested with all we had (i.e. 7 of the 20 existing optdeps), which is a configuration quite different from your usual test matrix. ;)

I might package dask in the future, but they are too much missing dependencies for it in our repos for now, and I don’t have enough time currently to go into packaging each of them and their own dependencies, etc.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Three test_aggregation[int-method_median] tests failing 567062305
588274222 https://github.com/pydata/xarray/pull/3780#issuecomment-588274222 https://api.github.com/repos/pydata/xarray/issues/3780 MDEyOklzc3VlQ29tbWVudDU4ODI3NDIyMg== ArchangeGabriel 490531 2020-02-19T14:55:00Z 2020-02-19T14:55:00Z CONTRIBUTOR

Added the whatsnew entry and replaced the commit.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Avoid running test_open_mfdataset_list_attr without dask 567510745
588263780 https://github.com/pydata/xarray/pull/3780#issuecomment-588263780 https://api.github.com/repos/pydata/xarray/issues/3780 MDEyOklzc3VlQ29tbWVudDU4ODI2Mzc4MA== ArchangeGabriel 490531 2020-02-19T14:34:07Z 2020-02-19T14:34:07Z CONTRIBUTOR

Should it be under bug fixes or internal changes?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Avoid running test_open_mfdataset_list_attr without dask 567510745
588262722 https://github.com/pydata/xarray/issues/3777#issuecomment-588262722 https://api.github.com/repos/pydata/xarray/issues/3777 MDEyOklzc3VlQ29tbWVudDU4ODI2MjcyMg== ArchangeGabriel 490531 2020-02-19T14:31:59Z 2020-02-19T14:31:59Z CONTRIBUTOR

Well, you can’t test every combination of dependencies, especially with the large number of optional ones you have. ;)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   test_open_mfdataset_list_attr is ran even when dask is not available 567035590
588215239 https://github.com/pydata/xarray/pull/3780#issuecomment-588215239 https://api.github.com/repos/pydata/xarray/issues/3780 MDEyOklzc3VlQ29tbWVudDU4ODIxNTIzOQ== ArchangeGabriel 490531 2020-02-19T12:58:58Z 2020-02-19T12:58:58Z CONTRIBUTOR

I don’t care about credit, so the question is whether you want this to be documented as a whatsnew entry (I don’t know your workflow/rules about this). ;)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Avoid running test_open_mfdataset_list_attr without dask 567510745
588180524 https://github.com/pydata/xarray/issues/3777#issuecomment-588180524 https://api.github.com/repos/pydata/xarray/issues/3777 MDEyOklzc3VlQ29tbWVudDU4ODE4MDUyNA== ArchangeGabriel 490531 2020-02-19T11:42:13Z 2020-02-19T11:42:13Z CONTRIBUTOR

You mean in your test matrix? Then yes. Anyway, I’ve proposed a simple fix in https://github.com/pydata/xarray/pull/3780, not sure if you want to go a different route (like making the test work without dask, not sure if that makes any sense).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   test_open_mfdataset_list_attr is ran even when dask is not available 567035590
588176698 https://github.com/pydata/xarray/issues/3778#issuecomment-588176698 https://api.github.com/repos/pydata/xarray/issues/3778 MDEyOklzc3VlQ29tbWVudDU4ODE3NjY5OA== ArchangeGabriel 490531 2020-02-19T11:33:35Z 2020-02-19T11:33:35Z CONTRIBUTOR

I have pint 0.10.1, and 0.10 definitively changed a lot of things as also shown in https://github.com/pydata/xarray/issues/3266#issuecomment-587574737.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Two strange errors in tests TestVariable using .copy() 567058587
587943881 https://github.com/pydata/xarray/issues/3778#issuecomment-587943881 https://api.github.com/repos/pydata/xarray/issues/3778 MDEyOklzc3VlQ29tbWVudDU4Nzk0Mzg4MQ== ArchangeGabriel 490531 2020-02-18T22:50:02Z 2020-02-18T22:50:02Z CONTRIBUTOR

Sure: ``` INSTALLED VERSIONS

commit: None python: 3.8.1 (default, Jan 22 2020, 06:38:00) [GCC 9.2.0] python-bits: 64 OS: Linux OS-release: 5.5.3-arch1-1 machine: x86_64 processor: byteorder: little LC_ALL: None LANG: en_US.UTF-8 LOCALE: en_US.UTF-8 libhdf5: 1.10.5 libnetcdf: 4.7.3

xarray: 0.15.0 pandas: 1.0.1 numpy: 1.18.1 scipy: 1.4.1 netCDF4: 1.5.3 pydap: None h5netcdf: None h5py: None Nio: None zarr: None cftime: 1.1.0 nc_time_axis: None PseudoNetCDF: None rasterio: None cfgrib: None iris: None bottleneck: 1.3.1 dask: None distributed: None matplotlib: 3.1.3 cartopy: None seaborn: 0.10.0 numbagg: None setuptools: 45.2.0 pip: None conda: None pytest: 5.3.5 IPython: None sphinx: None ```

BTW, why does it report h5py? I did not see it in the list of optional dependencies. Same for distributed by the way.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Two strange errors in tests TestVariable using .copy() 567058587
587593888 https://github.com/pydata/xarray/issues/3266#issuecomment-587593888 https://api.github.com/repos/pydata/xarray/issues/3266 MDEyOklzc3VlQ29tbWVudDU4NzU5Mzg4OA== ArchangeGabriel 490531 2020-02-18T18:00:40Z 2020-02-18T18:00:40Z CONTRIBUTOR

Even 99% by number. ;) And essentially only one warning repeated 5k times.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Warnings in the test suite 485446209
587574737 https://github.com/pydata/xarray/issues/3266#issuecomment-587574737 https://api.github.com/repos/pydata/xarray/issues/3266 MDEyOklzc3VlQ29tbWVudDU4NzU3NDczNw== ArchangeGabriel 490531 2020-02-18T17:19:27Z 2020-02-18T17:19:27Z CONTRIBUTOR

If people want more, here are some from a fresh compilation: https://paste.xinu.at/LnH/

 
{
    "total_count": 2,
    "+1": 0,
    "-1": 0,
    "laugh": 2,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Warnings in the test suite 485446209

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);