issue_comments

Table actions

4 rows where user = 4671621 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

user 1

  • JoelJaeschke · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1416740962 https://github.com/pydata/xarray/pull/7427#issuecomment-1416740962 https://api.github.com/repos/pydata/xarray/issues/7427 IC_kwDOAMm_X85UccBi JoelJaeschke 4671621 2023-02-04T12:34:39Z 2023-02-04T12:34:39Z NONE

Hi @dcherian, I added a note to whats-new. Thanks for your patience, still got a lot to learn :D

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Change .groupby fastpath to work for monotonic increasing and decreasing 1523260646
1412754874 https://github.com/pydata/xarray/pull/7427#issuecomment-1412754874 https://api.github.com/repos/pydata/xarray/issues/7427 IC_kwDOAMm_X85UNO26 JoelJaeschke 4671621 2023-02-01T21:29:40Z 2023-02-01T21:29:40Z NONE

Hi @dcherian, I implemented the feedback as you described, hope this does the trick.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Change .groupby fastpath to work for monotonic increasing and decreasing 1523260646
1399055025 https://github.com/pydata/xarray/pull/7427#issuecomment-1399055025 https://api.github.com/repos/pydata/xarray/issues/7427 IC_kwDOAMm_X85TY-Kx JoelJaeschke 4671621 2023-01-20T23:06:28Z 2023-01-20T23:07:06Z NONE

Hi @dcherian that was so obvious that I missed it..My bad!

I am not sure if I understand correctly what you are saying, but if I implement the test as you describe, would this not already work anyways? It will take the slow-path, but the behavior should be identical, right? My intention when writing the test was to explicitly test this case by supplying a grouper.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Change .groupby fastpath to work for monotonic increasing and decreasing 1523260646
1375937247 https://github.com/pydata/xarray/issues/6220#issuecomment-1375937247 https://api.github.com/repos/pydata/xarray/issues/6220 IC_kwDOAMm_X85SAyLf JoelJaeschke 4671621 2023-01-09T16:48:57Z 2023-01-09T16:48:57Z NONE

Hi @dcherian, I took a look at this issue and would appreciate your feedback :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [FEATURE]: Use fast path when grouping by unique monotonic decreasing variable 1119647191

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);