home / github

Menu
  • GraphQL API
  • Search all tables

issue_comments

Table actions
  • GraphQL API for issue_comments

6 rows where user = 4441865 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, reactions, created_at (date), updated_at (date)

issue 3

  • Use pytorch as backend for xarrays 3
  • update_attrs method 2
  • Method chaining on magic methods? 1

user 1

  • hsharrison · 6 ✖

author_association 1

  • CONTRIBUTOR 6
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1190382681 https://github.com/pydata/xarray/issues/3232#issuecomment-1190382681 https://api.github.com/repos/pydata/xarray/issues/3232 IC_kwDOAMm_X85G88xZ hsharrison 4441865 2022-07-20T14:48:15Z 2022-07-20T14:48:15Z CONTRIBUTOR

Makes sense, then I'll wait for https://github.com/pytorch/pytorch/issues/58743 to try it.

{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Use pytorch as backend for xarrays 482543307
1190068100 https://github.com/pydata/xarray/issues/3232#issuecomment-1190068100 https://api.github.com/repos/pydata/xarray/issues/3232 IC_kwDOAMm_X85G7v-E hsharrison 4441865 2022-07-20T09:50:59Z 2022-07-20T09:50:59Z CONTRIBUTOR

Nice that it's so simple. I think it can't be tested with pytorch until they compete https://github.com/pytorch/pytorch/issues/58743, right?

Or we should just try passing torch.tensor into xarray directly?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Use pytorch as backend for xarrays 482543307
1189938517 https://github.com/pydata/xarray/issues/3232#issuecomment-1189938517 https://api.github.com/repos/pydata/xarray/issues/3232 IC_kwDOAMm_X85G7QVV hsharrison 4441865 2022-07-20T07:42:05Z 2022-07-20T07:42:05Z CONTRIBUTOR

Glad to see progress on this!! 👏

Just curious though, seeing this comment in the PR:

Note: I haven't actually tested this with pytorch (which is the motivating example for https://github.com/pydata/xarray/issues/3232).

Are we sure this closes the issue? And, how can we try it out? Even lacking docs, a comment explaining how to set it up would be great, and I can do some testing on my end. I understand that it's an experimental feature.

{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 1,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Use pytorch as backend for xarrays 482543307
509022657 https://github.com/pydata/xarray/issues/3081#issuecomment-509022657 https://api.github.com/repos/pydata/xarray/issues/3081 MDEyOklzc3VlQ29tbWVudDUwOTAyMjY1Nw== hsharrison 4441865 2019-07-07T18:57:25Z 2019-07-07T18:57:25Z CONTRIBUTOR

That's fair. If this hasn't come up before, it must not be bothering too many people. Maybe I'll write a DataArray.op accessor.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Method chaining on magic methods? 464717028
282146064 https://github.com/pydata/xarray/issues/1281#issuecomment-282146064 https://api.github.com/repos/pydata/xarray/issues/1281 MDEyOklzc3VlQ29tbWVudDI4MjE0NjA2NA== hsharrison 4441865 2017-02-23T22:43:10Z 2017-02-23T22:43:10Z CONTRIBUTOR

FWIW I've been doing

def update_attrs(obj, *args, **kwargs):
    obj.attrs.update(*args, **kwargs)
    return obj

ds.pipe(update_attrs, foo='bar')

which, yeah, is not too painful. But when I find myself using it every time I use xarray it makes me wish it was included.

A lambda solution is more difficult (maybe impossible?) because you need to update the attrs and return the original object to continue the pipe.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  update_attrs method 209523348
281908185 https://github.com/pydata/xarray/issues/1281#issuecomment-281908185 https://api.github.com/repos/pydata/xarray/issues/1281 MDEyOklzc3VlQ29tbWVudDI4MTkwODE4NQ== hsharrison 4441865 2017-02-23T06:36:18Z 2017-02-23T06:36:18Z CONTRIBUTOR

Thanks for the tip. I'll give it a shot.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  update_attrs method 209523348

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 11.516ms · About: xarray-datasette