issue_comments

Table actions

5 rows where user = 42680748 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

user 1

  • Ockenfuss · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1555970164 https://github.com/pydata/xarray/issues/7665#issuecomment-1555970164 https://api.github.com/repos/pydata/xarray/issues/7665 IC_kwDOAMm_X85cvjh0 Ockenfuss 42680748 2023-05-20T18:44:53Z 2023-05-20T18:44:53Z CONTRIBUTOR

Do you have any thoughts on this?

I think with the following signature, the function will be backward compatible: interpolate_na(dim, method='linear', use_coordinate=True, limit=None, limit_direction='forward', limit_area=None, limit_use_coordinate=False, max_gap=None)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Interpolate_na: Rework 'limit' argument documentation/implementation 1637898633
1481534629 https://github.com/pydata/xarray/issues/7665#issuecomment-1481534629 https://api.github.com/repos/pydata/xarray/issues/7665 IC_kwDOAMm_X85YTmyl Ockenfuss 42680748 2023-03-23T16:47:57Z 2023-03-23T16:47:57Z CONTRIBUTOR

Two comments if the pandas arguments are introduced: * If the pandas arguments are introduced, one might raise the question, whether the max_gap argument of xarray is still necessary, since pandas does not have such an argument. However, if the user does not want any interpolation if a gap is bigger than a specified length, this is currently not possible with pandas (actually, the max_gap feature is requested by the pandas community since a long time: pandas-dev/pandas#12187 ) * Coordinate handling: Currently, limit is operating on indices, max_gap is operating on coordinates. Is there a deeper reason for this separation? Both operations limit the interpolation 'distance'. If not, similar to use_coordinates, one could introduce something like limit_use_coordinates. If True, limit as well as max_gap refer to numeric coordinates, otherwise to a linearly increasing index ([0,1,2,...]).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Interpolate_na: Rework 'limit' argument documentation/implementation 1637898633
1461677732 https://github.com/pydata/xarray/pull/7598#issuecomment-1461677732 https://api.github.com/repos/pydata/xarray/issues/7598 IC_kwDOAMm_X85XH26k Ockenfuss 42680748 2023-03-09T09:45:09Z 2023-03-09T09:45:09Z CONTRIBUTOR

As a newcomer, a short general question: The 'Contributing' guide mentions to document changes in whats-new.rst. Shall this be done by the developer or are you (the maintainers) doing this once the PR is merged into the main branch? (Since at the time of requesting, I can`t know when (or if) the issue will be merged).

Usually this is done by the developer/contributor. You can just copy a similar entry and adopt it to yourself in the newest section, you have basically full freedom :)

Thanks, good to know!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix missing 'dim' argument in _get_nan_block_lengths 1615645463
1461033123 https://github.com/pydata/xarray/issues/7597#issuecomment-1461033123 https://api.github.com/repos/pydata/xarray/issues/7597 IC_kwDOAMm_X85XFZij Ockenfuss 42680748 2023-03-08T23:33:27Z 2023-03-08T23:33:27Z CONTRIBUTOR

@dcherian The answers above read like they are generated by a bot (they even include the typo I made in the Issue title: max_map instead of max_gap). ChatGPT seems to create very similar answers, if I input the issue heading. @Karimat22 : Please clarify what you mean, if this is not the case, I currently do not understand you comment.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Interpolate_na: max_map argument not working at array boundaries 1615599224
1460577111 https://github.com/pydata/xarray/pull/7598#issuecomment-1460577111 https://api.github.com/repos/pydata/xarray/issues/7598 IC_kwDOAMm_X85XDqNX Ockenfuss 42680748 2023-03-08T17:46:22Z 2023-03-08T17:55:11Z CONTRIBUTOR

As a newcomer, a short general question: The 'Contributing' guide mentions to document changes in whats-new.rst. Shall this be done by the developer or are you (the maintainers) doing this once the PR is merged into the main branch?

(Since at the time of requesting, I can`t know when (or if) the issue will be merged).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix missing 'dim' argument in _get_nan_block_lengths 1615645463

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);