issue_comments

Table actions

2 rows where user = 3606852 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • rmsare · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
409774622 https://github.com/pydata/xarray/issues/1624#issuecomment-409774622 https://api.github.com/repos/pydata/xarray/issues/1624 MDEyOklzc3VlQ29tbWVudDQwOTc3NDYyMg== rmsare 3606852 2018-08-02T01:20:43Z 2018-08-02T01:20:43Z NONE

@shoyer Nice! Thanks for pointing it out, hadn't seen that PR.

I like how the checks have been abstracted with validator functions, seems much more flexible overall.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve documentation and error validation for set_options(arithmetic_join) 264509098
409755419 https://github.com/pydata/xarray/issues/1624#issuecomment-409755419 https://api.github.com/repos/pydata/xarray/issues/1624 MDEyOklzc3VlQ29tbWVudDQwOTc1NTQxOQ== rmsare 3606852 2018-08-01T23:14:18Z 2018-08-01T23:14:18Z NONE

This issue is pretty stale, but I've taken a crack at this. Not sure I like my approach. This doesn't seem like a high priority issue, but if we can triage my implementation with some feedback, happy to work it up into a PR.

branch diff

The idea was to add _check_values method to the options class that check the current values in OPTIONS against a dictionary which contains lists of accepted values. If there's no entry in that dictionary, any value is assumed valid. But values of incorrect type can be caught by a _check_types method, which checks for type consistency with the default values.

Both are called at the end of initialization to catch bad values before some function tries to use them in the new context.

Does xarray have any established value checking practices? Skimming through the code I couldn't find any.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Improve documentation and error validation for set_options(arithmetic_join) 264509098

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);