issue_comments

Table actions

3 rows where user = 30324885 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • ayjayt · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1547022976 https://github.com/pydata/xarray/pull/7840#issuecomment-1547022976 https://api.github.com/repos/pydata/xarray/issues/7840 IC_kwDOAMm_X85cNbKA ayjayt 30324885 2023-05-14T23:10:31Z 2023-05-14T23:10:31Z NONE

I'm sorry, but just to reiterate, "x" is referred to as a dimension several times in the document. It is then, one time, mistakenly referred to as a coordinate. This pull request, which should be accepted, is to make the document consistent in how it refers to "x".

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix words to make terminology consistent in docs 1707774178
1546041240 https://github.com/pydata/xarray/pull/7840#issuecomment-1546041240 https://api.github.com/repos/pydata/xarray/issues/7840 IC_kwDOAMm_X85cJreY ayjayt 30324885 2023-05-12T17:07:08Z 2023-05-12T17:09:44Z NONE

Yeah, as a total new comer, this explanation seems not only unintuitive but also like we're fighting with common terminology used in math and everywhere else.

When you define the coordinates,

data = xr.DataArray(np.random.randn(2,3)*10, dims=("x", "y"), coords={"x": [10, 20]})

It looks like you are defining a specific coordinate system [10,20] on a specific dimension "x". The key of the object-value pair set in coords (ie. "x") MUST refer to a dimension, because "x" is a dimension that we are defining a coordinate system for. As we don't define any coordinate system on "y", asking xarray for data.coords["y"] gives us a array([0,1,2]) which we'd consider to be an intuitive default coordinate system.

Intuitively, we think: An xarray contains dimensions along which specific coordinates can be defined: xarray.dimension.coordinate

In the attribute definition, we say:

data.x.attrs["units"] = "x units" which feels like we are defining an attribute on the entire dimension. As opposed to data.x.10 (I realize the problem here) which would be definiting an attribute on a single coordinate within a dimension.

I'm done, thank you for your time. I will continue reading and learning about xarray.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix words to make terminology consistent in docs 1707774178
1546019472 https://github.com/pydata/xarray/pull/7840#issuecomment-1546019472 https://api.github.com/repos/pydata/xarray/issues/7840 IC_kwDOAMm_X85cJmKQ ayjayt 30324885 2023-05-12T16:47:46Z 2023-05-12T16:51:44Z NONE

Well, it's not consistent within this particular document, which is reasonably the first anyone reads. The dimension, as its refered to, in this example is called "x", we are assigning an attribute to "x", the coordinates of "x" are [10,20], we are not assigning an attribute to a coordinate within the dimension "x".

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix words to make terminology consistent in docs 1707774178

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);