issue_comments

Table actions

5 rows where user = 2501846 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, reactions, created_at (date), updated_at (date)

user 1

  • ksunden · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1530256448 https://github.com/pydata/xarray/issues/7802#issuecomment-1530256448 https://api.github.com/repos/pydata/xarray/issues/7802 IC_kwDOAMm_X85bNdxA ksunden 2501846 2023-05-01T21:00:30Z 2023-05-01T21:00:30Z CONTRIBUTOR

[xy]ticks upstream PR submitted, linked above

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
   Mypy errors with matplotlib 3.8 1691206894
1528091492 https://github.com/pydata/xarray/pull/7787#issuecomment-1528091492 https://api.github.com/repos/pydata/xarray/issues/7787 IC_kwDOAMm_X85bFNNk ksunden 2501846 2023-04-28T21:02:29Z 2023-04-28T21:02:29Z CONTRIBUTOR

The suggestion from mpl (specifically @tacaswell) was to use constrained layout for the purpose that xarray currently uses get_renderer, this will ensure that the facetgrid works with all mpl backends.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow the label run-upstream to run upstream CI 1684281101
1523743471 https://github.com/pydata/xarray/pull/7787#issuecomment-1523743471 https://api.github.com/repos/pydata/xarray/issues/7787 IC_kwDOAMm_X85a0nrv ksunden 2501846 2023-04-26T16:46:14Z 2023-04-26T16:46:14Z CONTRIBUTOR

Tackling a few of them (but not all in one go):

  • [xy]ticks in mpl is currently overly narrowly type hinted because I was following the docstring, but I agree that ArrayLike is a better type hint for that, plan on updating (including the docstring) upstream
  • [xy]lim originally neglected the case of passing set_xlim((min, max)) as a tuple, but that has been updated. xarray has that type hinted as array like, but mpl has it hinted as a 2-tuple (I think it is currently still of floats, but may be expanded as we more directly address units/categoricals/etc). Willing to debate here, but my starting position is that the "exactly 2 values" is valuable info here, and I think tuple is the only way to do that.
  • get_renderer is not actually available on all of our backends, we should maybe see if there is a more preferred way of doing what you are doing here that will work for all backends, but haven't looked into it too closely.
  • Module has no attribute <colormap> is another instance of dynamically generated behavior which can't be statically type checked (elegantly, at least), can probably be replaced by mpl.colormaps["<colormap>"] in many cases, which is statically typecheckable
  • Anything to do with 3D Axes is not type hinted, perhaps ignore for now (or help us get that type hinted adequately, but it is relatively low priority currently)
  • Module has no attribute "dates" we don't currently type hint dates/units things, but it is on my mind, not sure yet if it will be in first release or not though (may at least put a placeholder that gets rid of this error, but treats everything as "Any").
 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
   Allow the label run-upstream to run upstream CI 1684281101
1020669305 https://github.com/pydata/xarray/issues/6176#issuecomment-1020669305 https://api.github.com/repos/pydata/xarray/issues/6176 IC_kwDOAMm_X8481i15 ksunden 2501846 2022-01-24T23:57:13Z 2022-01-24T23:57:13Z CONTRIBUTOR

setup.py sdist bdist_wheel creates files in dist/ that have the leading zeros removed.

I did git tag v2022.01.0 and then built the wheel/sdist and got: xarray-2022.1.0-py3-none-any.whl and xarray-2022.1.0.tar.gz and xarray.__version__ gave 2022.1.0

I do understand the appeal of leading zeros, I started off using them myself, but pypi/setuptools/etc will bring in inconsistencies that you will either need to fight against or give into the consistent way, which is sans leading zero (that is the path I chose)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Xarray versioning to switch to CalVer 1108564253
1020405910 https://github.com/pydata/xarray/issues/6176#issuecomment-1020405910 https://api.github.com/repos/pydata/xarray/issues/6176 IC_kwDOAMm_X8480iiW ksunden 2501846 2022-01-24T18:23:26Z 2022-01-24T18:23:26Z CONTRIBUTOR

Note that PEP 440 normalizes integers in version strings, so leading zeros are ignored and the version as it appears in PyPI would be 2022.1.0, as that displays the normalized version string.

On my own packages which I use calver for I have opted to not have leading zeros such that the "canonical" version matches the "normalized" version to avoid any confusion that may cause.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Xarray versioning to switch to CalVer 1108564253

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);