home / github

Menu
  • GraphQL API
  • Search all tables

issue_comments

Table actions
  • GraphQL API for issue_comments

9 rows where user = 1970404 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

issue 3

  • test_reduce[None-True-var-True-float32-2] fails on i386 6
  • Fix tests on big-endian systems 2
  • Allow test_indexes to pass on big-endian systems 1

user 1

  • ginggs · 9 ✖

author_association 1

  • CONTRIBUTOR 9
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1244442964 https://github.com/pydata/xarray/pull/7026#issuecomment-1244442964 https://api.github.com/repos/pydata/xarray/issues/7026 IC_kwDOAMm_X85KLLFU ginggs 1970404 2022-09-12T20:48:04Z 2022-09-12T20:48:04Z CONTRIBUTOR

Since the 2022.06.0 release, the following tests have been failing in Debian and Ubuntu on big-endian systems: ``` =================================== FAILURES =================================== ____ TestPandasIndex.test_join _______

self = <xarray.tests.test_indexes.TestPandasIndex object at 0x3ff828b6ef0>

def test_join(self) -> None:
    index1 = PandasIndex(["a", "aa", "aaa"], "x", coord_dtype="<U3")
    index2 = PandasIndex(["aa", "aaa", "aaaa"], "x", coord_dtype="<U4")

    expected = PandasIndex(["aa", "aaa"], "x")
    actual = index1.join(index2)
    print(actual.index)
    assert actual.equals(expected)
  assert actual.coord_dtype == "<U4"

E AssertionError: assert dtype('>U4') == '<U4' E + where dtype('>U4') = <xarray.core.indexes.PandasIndex object at 0x3ff716d5300>.coord_dtype

/usr/lib/python3/dist-packages/xarray/tests/test_indexes.py:267: AssertionError ----------------------------- Captured stdout call ----------------------------- Index(['aa', 'aaa'], dtype='object', name='x') ___ TestPandasMultiIndex.test_concat ___

self = <xarray.tests.test_indexes.TestPandasMultiIndex object at 0x3ff82e70370>

def test_concat(self) -> None:
    pd_midx = pd.MultiIndex.from_product(
        [[0, 1, 2], ["a", "b"]], names=("foo", "bar")
    )
    level_coords_dtype = {"foo": np.int32, "bar": "<U1"}

    midx1 = PandasMultiIndex(
        pd_midx[:2], "x", level_coords_dtype=level_coords_dtype
    )
    midx2 = PandasMultiIndex(
        pd_midx[2:], "x", level_coords_dtype=level_coords_dtype
    )
    expected = PandasMultiIndex(pd_midx, "x", level_coords_dtype=level_coords_dtype)

    actual = PandasMultiIndex.concat([midx1, midx2], "x")
    assert actual.equals(expected)
  assert actual.level_coords_dtype == expected.level_coords_dtype

E AssertionError: assert {'bar': dtype...type('int32')} == {'bar': '<U1'...numpy.int32'>} E Omitting 1 identical items, use -vv to show E Differing items: E {'bar': dtype('>U1')} != {'bar': '<U1'} E Full diff: E - {'bar': '<U1', 'foo': \<class 'numpy.int32'>} E + {'bar': dtype('>U1'), 'foo': dtype('int32')}

/usr/lib/python3/dist-packages/xarray/tests/test_indexes.py:395: AssertionError ___ TestPandasMultiIndex.testjoin ____

self = <xarray.tests.test_indexes.TestPandasMultiIndex object at 0x3ff828b6590>

def test_join(self):
    midx = pd.MultiIndex.from_product([["a", "aa"], [1, 2]], names=("one", "two"))
    level_coords_dtype = {"one": "<U2", "two": "i"}
    index1 = PandasMultiIndex(midx, "x", level_coords_dtype=level_coords_dtype)
    index2 = PandasMultiIndex(midx[0:2], "x", level_coords_dtype=level_coords_dtype)

    actual = index1.join(index2)
    assert actual.equals(index2)
  assert actual.level_coords_dtype == level_coords_dtype

E AssertionError: assert {'one': dtype...type('int32')} == {'one': '<U2', 'two': 'i'} E Omitting 1 identical items, use -vv to show E Differing items: E {'one': dtype('>U2')} != {'one': '<U2'} E Full diff: E - {'one': '<U2', 'two': 'i'} E + {'one': dtype('>U2'), 'two': dtype('int32')}

/usr/lib/python3/dist-packages/xarray/tests/test_indexes.py:493: AssertionError ``` Full test log on IBM s390x with Ubuntu 22.10: https://autopkgtest.ubuntu.com/results/autopkgtest-kinetic/kinetic/s390x/p/python-xarray/20220911_200538_24725@/log.gz

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Allow test_indexes to pass on big-endian systems 1370494294
511551723 https://github.com/pydata/xarray/pull/3125#issuecomment-511551723 https://api.github.com/repos/pydata/xarray/issues/3125 MDEyOklzc3VlQ29tbWVudDUxMTU1MTcyMw== ginggs 1970404 2019-07-15T20:12:59Z 2019-07-15T20:12:59Z CONTRIBUTOR

@max-sixty done in #3135

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Fix tests on big-endian systems 467856339
511459360 https://github.com/pydata/xarray/pull/3125#issuecomment-511459360 https://api.github.com/repos/pydata/xarray/issues/3125 MDEyOklzc3VlQ29tbWVudDUxMTQ1OTM2MA== ginggs 1970404 2019-07-15T15:51:34Z 2019-07-15T15:51:34Z CONTRIBUTOR

@max-sixty

Yes, #2334 is still relevant, I recently rebased and added another XFAIL for a new test.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Fix tests on big-endian systems 467856339
408590300 https://github.com/pydata/xarray/issues/2063#issuecomment-408590300 https://api.github.com/repos/pydata/xarray/issues/2063 MDEyOklzc3VlQ29tbWVudDQwODU5MDMwMA== ginggs 1970404 2018-07-28T07:50:43Z 2018-07-28T07:50:43Z CONTRIBUTOR

This issue has gone away. Weirdly, it seems to have happened after NumPy was upgraded to 1.14, and Dask was still at 0.16.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  test_reduce[None-True-var-True-float32-2] fails on i386 314670220
384776509 https://github.com/pydata/xarray/issues/2063#issuecomment-384776509 https://api.github.com/repos/pydata/xarray/issues/2063 MDEyOklzc3VlQ29tbWVudDM4NDc3NjUwOQ== ginggs 1970404 2018-04-26T20:20:59Z 2018-04-26T20:20:59Z CONTRIBUTOR

Same results with dask: 0.17.2. Thanks for your help.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  test_reduce[None-True-var-True-float32-2] fails on i386 314670220
384756623 https://github.com/pydata/xarray/issues/2063#issuecomment-384756623 https://api.github.com/repos/pydata/xarray/issues/2063 MDEyOklzc3VlQ29tbWVudDM4NDc1NjYyMw== ginggs 1970404 2018-04-26T19:07:24Z 2018-04-26T19:07:24Z CONTRIBUTOR

I have dask: 0.16.0 installed and there is a 0.17.2 out. I'll try upgrading that and see if it helps.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  test_reduce[None-True-var-True-float32-2] fails on i386 314670220
384729424 https://github.com/pydata/xarray/issues/2063#issuecomment-384729424 https://api.github.com/repos/pydata/xarray/issues/2063 MDEyOklzc3VlQ29tbWVudDM4NDcyOTQyNA== ginggs 1970404 2018-04-26T17:48:31Z 2018-04-26T17:48:31Z CONTRIBUTOR

Thanks!

After adding: import dask.array as da I get: numpy 1.07926 /usr/lib/python3/dist-packages/dask/array/reductions.py:297: RuntimeWarning: invalid value encountered in true_divide u = total / n /usr/lib/python3/dist-packages/dask/array/numpy_compat.py:46: RuntimeWarning: invalid value encountered in true_divide x = np.divide(x1, x2, out) dask 1.09559 pandas 1.0792573690414429 bottleneck 1.0792573690414429

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  test_reduce[None-True-var-True-float32-2] fails on i386 314670220
384631112 https://github.com/pydata/xarray/issues/2063#issuecomment-384631112 https://api.github.com/repos/pydata/xarray/issues/2063 MDEyOklzc3VlQ29tbWVudDM4NDYzMTExMg== ginggs 1970404 2018-04-26T12:56:06Z 2018-04-26T12:56:06Z CONTRIBUTOR

Hi, any ideas, please?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  test_reduce[None-True-var-True-float32-2] fails on i386 314670220
381666083 https://github.com/pydata/xarray/issues/2063#issuecomment-381666083 https://api.github.com/repos/pydata/xarray/issues/2063 MDEyOklzc3VlQ29tbWVudDM4MTY2NjA4Mw== ginggs 1970404 2018-04-16T16:29:56Z 2018-04-16T16:29:56Z CONTRIBUTOR

Thanks, here you go: ```

xarray.show_versions()

INSTALLED VERSIONS

commit: None python: 3.6.5.candidate.1 python-bits: 32 OS: Linux OS-release: 4.15.0-12-generic machine: i686 processor: athlon byteorder: little LC_ALL: None LANG: en_ZA.UTF-8 LOCALE: en_ZA.UTF-8

xarray: 0.10.3 pandas: 0.22.0 numpy: 1.13.3 ... bottleneck: 1.2.0 ... ```

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  test_reduce[None-True-var-True-float32-2] fails on i386 314670220

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 14.69ms · About: xarray-datasette