issue_comments

Table actions

5 rows where user = 10647082 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, reactions, created_at (date), updated_at (date)

user 1

  • mroeschke · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1498160636 https://github.com/pydata/xarray/issues/7716#issuecomment-1498160636 https://api.github.com/repos/pydata/xarray/issues/7716 IC_kwDOAMm_X85ZTB38 mroeschke 10647082 2023-04-05T21:05:34Z 2023-04-05T21:05:34Z CONTRIBUTOR

CI says these are the tests we'd need to fix:

Chiming in from the pandas side on those failures, I think they are all expected https://pandas.pydata.org/docs/whatsnew/v2.0.0.html namely

  • Since pandas supports s, ms and us numpy datetime resolutions now, I'm guessing that's why test_to_datetimeindex_out_of_range and test_should_cftime_be_used_source_outside_range are failing
  • For test_sel_float, pd.Index intentionally does not support np.float16 as dtype anymore (we never had an indexing engine for this dtype)
  • For test_maybe_coerce_to_str, this might be expected too as Index dtypes can hold np.int32 types now
 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   bad conda solve with pandas 2 1654022522
1349626420 https://github.com/pydata/xarray/pull/7361#issuecomment-1349626420 https://api.github.com/repos/pydata/xarray/issues/7361 IC_kwDOAMm_X85Qcao0 mroeschke 10647082 2022-12-13T20:12:28Z 2022-12-13T20:12:28Z CONTRIBUTOR

Great added the whatsnew note and just removed the arguments

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   COMPAT: Adjust CFTimeIndex.get_loc for pandas 2.0 deprecation enforcement 1477931237
1347186812 https://github.com/pydata/xarray/pull/7361#issuecomment-1347186812 https://api.github.com/repos/pydata/xarray/issues/7361 IC_kwDOAMm_X85QTHB8 mroeschke 10647082 2022-12-12T19:40:21Z 2022-12-12T19:40:21Z CONTRIBUTOR

I guess this could be a "Breaking Change" in the next release's What's New. Let me know if that's the direction you're still leaning

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   COMPAT: Adjust CFTimeIndex.get_loc for pandas 2.0 deprecation enforcement 1477931237
1339701584 https://github.com/pydata/xarray/pull/7361#issuecomment-1339701584 https://api.github.com/repos/pydata/xarray/issues/7361 IC_kwDOAMm_X85P2jlQ mroeschke 10647082 2022-12-06T17:13:04Z 2022-12-06T17:13:04Z CONTRIBUTOR

I wonder if it's appropriate to simply remove these arguments altogether following pandas?

Sure, happy to remove this method and tolerance from CFTimeIndex.get_loc. Would that require a deprecation in xarray or can they simply be removed if CFTimeIndex.get_loc is "private"?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   COMPAT: Adjust CFTimeIndex.get_loc for pandas 2.0 deprecation enforcement 1477931237
1008167734 https://github.com/pydata/xarray/pull/6145#issuecomment-1008167734 https://api.github.com/repos/pydata/xarray/issues/6145 IC_kwDOAMm_X848F2s2 mroeschke 10647082 2022-01-08T22:39:24Z 2022-01-08T22:39:37Z CONTRIBUTOR

Thanks, addressed

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove pd.Panel checks 1096802655

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);