issue_comments

Table actions

8 rows where issue = 99547211 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • 2d plot titles · 8 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
130456762 https://github.com/pydata/xarray/pull/519#issuecomment-130456762 https://api.github.com/repos/pydata/xarray/issues/519 MDEyOklzc3VlQ29tbWVudDEzMDQ1Njc2Mg== shoyer 1217238 2015-08-12T21:40:03Z 2015-08-12T21:40:03Z MEMBER

feel free to merge

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   2d plot titles 99547211
130400290 https://github.com/pydata/xarray/pull/519#issuecomment-130400290 https://api.github.com/repos/pydata/xarray/issues/519 MDEyOklzc3VlQ29tbWVudDEzMDQwMDI5MA== shoyer 1217238 2015-08-12T18:21:09Z 2015-08-12T18:21:09Z MEMBER

OK, seems pretty reasonable on the title then. Just note that some datasets (especially from model output) contain a lot of scalar variables, so that could easily get unwieldy. We might need to revisit this once it gets more use in the wild. For example, truncating the title at some reasonable line length might be a good idea.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   2d plot titles 99547211
130398680 https://github.com/pydata/xarray/pull/519#issuecomment-130398680 https://api.github.com/repos/pydata/xarray/issues/519 MDEyOklzc3VlQ29tbWVudDEzMDM5ODY4MA== clarkfitzg 5356122 2015-08-12T18:15:22Z 2015-08-12T18:15:22Z MEMBER

Maybe we should restrict squeezing the data to only the magic DataArray.plot() method?

Works for me. The error message should be informative enough in the other cases.

Scalar coordinates- this is the current behavior:

``` In [16]: a = xray.DataArray(np.random.randn(3, 4))

In [17]: a.coords['foo'] = 123

In [18]: a.plot() ```

So scalar coordinates do show up in the title, which is what I was going for. I could add a test for this.

labelling facets will be more reliable if it is done explicitly in the same code that is doing the indexing/groupby.

That's the approach that I've moved to after spending more time on it. This PR adds the argument add_labels to 2d plotting functions. Now for the faceting I'll actually use add_labels=False.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   2d plot titles 99547211
130390873 https://github.com/pydata/xarray/pull/519#issuecomment-130390873 https://api.github.com/repos/pydata/xarray/issues/519 MDEyOklzc3VlQ29tbWVudDEzMDM5MDg3Mw== shoyer 1217238 2015-08-12T17:56:13Z 2015-08-12T17:56:13Z MEMBER

For interactive use, I think plotting squeezed data is probably what users want. But I worry that this will make the result of plotting functions less predictable. Maybe we should restrict squeezing the data to only the magic DataArray.plot() method?

For axis titles, what happens if the data array has many scalar coordinates? Scalar coordinates can be directly assigned, not just created from indexing. My sense is that labelling facets will be more reliable if it is done explicitly in the same code that is doing the indexing/groupby.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   2d plot titles 99547211
129649712 https://github.com/pydata/xarray/pull/519#issuecomment-129649712 https://api.github.com/repos/pydata/xarray/issues/519 MDEyOklzc3VlQ29tbWVudDEyOTY0OTcxMg== clarkfitzg 5356122 2015-08-10T23:55:33Z 2015-08-10T23:55:33Z MEMBER

Will finish this up tomorrow morning.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   2d plot titles 99547211
129630708 https://github.com/pydata/xarray/pull/519#issuecomment-129630708 https://api.github.com/repos/pydata/xarray/issues/519 MDEyOklzc3VlQ29tbWVudDEyOTYzMDcwOA== clarkfitzg 5356122 2015-08-10T22:11:07Z 2015-08-10T22:11:07Z MEMBER

@jhamman Yes, ready for review.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   2d plot titles 99547211
129624981 https://github.com/pydata/xarray/pull/519#issuecomment-129624981 https://api.github.com/repos/pydata/xarray/issues/519 MDEyOklzc3VlQ29tbWVudDEyOTYyNDk4MQ== jhamman 2443309 2015-08-10T21:55:08Z 2015-08-10T21:55:08Z MEMBER

@clarkfitzg - in your eyes, is this done? If so, I'll give it another look?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   2d plot titles 99547211
129556441 https://github.com/pydata/xarray/pull/519#issuecomment-129556441 https://api.github.com/repos/pydata/xarray/issues/519 MDEyOklzc3VlQ29tbWVudDEyOTU1NjQ0MQ== clarkfitzg 5356122 2015-08-10T18:22:58Z 2015-08-10T18:22:58Z MEMBER

@jhamman good idea :+1: 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   2d plot titles 99547211

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);