issue_comments

Table actions

4 rows where issue = 99098066 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Fix pickle on DataArray objects · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
130975336 https://github.com/pydata/xarray/pull/517#issuecomment-130975336 https://api.github.com/repos/pydata/xarray/issues/517 MDEyOklzc3VlQ29tbWVudDEzMDk3NTMzNg== jhamman 2443309 2015-08-14T05:41:56Z 2015-08-14T05:41:56Z MEMBER

This looks good to me. Much cleaner than before.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix pickle on DataArray objects 99098066
130884608 https://github.com/pydata/xarray/pull/517#issuecomment-130884608 https://api.github.com/repos/pydata/xarray/issues/517 MDEyOklzc3VlQ29tbWVudDEzMDg4NDYwOA== shoyer 1217238 2015-08-13T23:36:42Z 2015-08-13T23:36:42Z MEMBER

OK, new approach, now that I finally understand what is going on. Got ride of _initialized, put an explicit check for __setstate__ in __getattr__. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix pickle on DataArray objects 99098066
130869105 https://github.com/pydata/xarray/pull/517#issuecomment-130869105 https://api.github.com/repos/pydata/xarray/issues/517 MDEyOklzc3VlQ29tbWVudDEzMDg2OTEwNQ== jhamman 2443309 2015-08-13T22:41:45Z 2015-08-13T22:41:45Z MEMBER

This looks pretty good to me. Can you explain why we need the _initialized attribute?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix pickle on DataArray objects 99098066
130860681 https://github.com/pydata/xarray/pull/517#issuecomment-130860681 https://api.github.com/repos/pydata/xarray/issues/517 MDEyOklzc3VlQ29tbWVudDEzMDg2MDY4MQ== shoyer 1217238 2015-08-13T21:57:21Z 2015-08-13T21:57:21Z MEMBER

This actually works now, if anyone wants to give this a review

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix pickle on DataArray objects 99098066

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);