issue_comments

Table actions

6 rows where issue = 990194656 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Create benchmark for groupby · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
914488317 https://github.com/pydata/xarray/pull/5772#issuecomment-914488317 https://api.github.com/repos/pydata/xarray/issues/5772 IC_kwDOAMm_X842gfv9 github-actions[bot] 41898282 2021-09-07T17:25:28Z 2021-09-20T20:46:41Z CONTRIBUTOR

Unit Test Results

6 files  ±0           6 suites  ±0   56m 50s :stopwatch: ±0s 16 227 tests ±0  14 492 :heavy_check_mark: ±0  1 735 :zzz: ±0  0 :x: ±0  90 558 runs  ±0  82 383 :heavy_check_mark: ±0  8 175 :zzz: ±0  0 :x: ±0 

Results for commit 7a65d596. ± Comparison against base commit 7a65d596.

:recycle: This comment has been updated with latest results.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Create benchmark for groupby 990194656
923262623 https://github.com/pydata/xarray/pull/5772#issuecomment-923262623 https://api.github.com/repos/pydata/xarray/issues/5772 IC_kwDOAMm_X843B96f dcherian 2448579 2021-09-20T20:15:24Z 2021-09-20T20:15:24Z MEMBER

Thanks @Illviljan 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Create benchmark for groupby 990194656
914487425 https://github.com/pydata/xarray/pull/5772#issuecomment-914487425 https://api.github.com/repos/pydata/xarray/issues/5772 IC_kwDOAMm_X842gfiB pep8speaks 24736507 2021-09-07T17:23:53Z 2021-09-14T02:19:50Z NONE

Hello @Illviljan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-09-14 02:19:50 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Create benchmark for groupby 990194656
914520961 https://github.com/pydata/xarray/pull/5772#issuecomment-914520961 https://api.github.com/repos/pydata/xarray/issues/5772 IC_kwDOAMm_X842gnuB Illviljan 14371165 2021-09-07T18:17:54Z 2021-09-07T18:17:54Z MEMBER

I agree we should have more array sizes. I was thinking grouping small, medium, large, 1d, 2d, Nd arrays. But that's for a future PR, I lost interest when I couldn't see the results.

It froze during the tests, for example I explicitly tested repr.py because I thought it would be an easy one. PC still froze. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Create benchmark for groupby 990194656
914511168 https://github.com/pydata/xarray/pull/5772#issuecomment-914511168 https://api.github.com/repos/pydata/xarray/issues/5772 IC_kwDOAMm_X842glVA max-sixty 5635139 2021-09-07T18:02:26Z 2021-09-07T18:02:26Z MEMBER

This looks great, thanks @Illviljan

We may want to make the array much bigger, given the overhead.

And (could be a TODO), parameterize the cardinality.

Sorry to hear re asv. Does it install the environment successfully? That can take a while. But maybe not worth exploring more if it brings down the PC... 😬

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Create benchmark for groupby 990194656
914491014 https://github.com/pydata/xarray/pull/5772#issuecomment-914491014 https://api.github.com/repos/pydata/xarray/issues/5772 IC_kwDOAMm_X842ggaG Illviljan 14371165 2021-09-07T17:30:05Z 2021-09-07T17:48:30Z MEMBER

Someone who understands asv is free to try it out. Every time I managed to get asv running my entire pc froze and I had to force restart it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Create benchmark for groupby 990194656

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);