issue_comments

Table actions

5 rows where issue = 98498103 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Add sel_points for point-wise indexing by label · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
127834493 https://github.com/pydata/xarray/pull/507#issuecomment-127834493 https://api.github.com/repos/pydata/xarray/issues/507 MDEyOklzc3VlQ29tbWVudDEyNzgzNDQ5Mw== jhamman 2443309 2015-08-05T03:28:47Z 2015-08-05T03:28:47Z MEMBER

Are there going to be merge conflicts with #512? Maybe merge this then update that PR accordingly?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add sel_points for point-wise indexing by label 98498103
127833763 https://github.com/pydata/xarray/pull/507#issuecomment-127833763 https://api.github.com/repos/pydata/xarray/issues/507 MDEyOklzc3VlQ29tbWVudDEyNzgzMzc2Mw== jhamman 2443309 2015-08-05T03:23:47Z 2015-08-05T03:23:47Z MEMBER

No, I think this is good to go.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add sel_points for point-wise indexing by label 98498103
127815521 https://github.com/pydata/xarray/pull/507#issuecomment-127815521 https://api.github.com/repos/pydata/xarray/issues/507 MDEyOklzc3VlQ29tbWVudDEyNzgxNTUyMQ== shoyer 1217238 2015-08-05T01:44:15Z 2015-08-05T01:44:15Z MEMBER

@jhamman any other comments? If not, I'll merge this shortly.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add sel_points for point-wise indexing by label 98498103
126972030 https://github.com/pydata/xarray/pull/507#issuecomment-126972030 https://api.github.com/repos/pydata/xarray/issues/507 MDEyOklzc3VlQ29tbWVudDEyNjk3MjAzMA== shoyer 1217238 2015-08-02T01:32:15Z 2015-08-02T01:32:15Z MEMBER

Are you basically letting pandas do all the testing in terms of the method and range of the indexers? I'm wondering if we need to target any corner cases that extend beyond how pandas does the indexer mapping.

This has been my strategy. Pandas has lots of tests for the exact behavior of get_indexer.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add sel_points for point-wise indexing by label 98498103
126877112 https://github.com/pydata/xarray/pull/507#issuecomment-126877112 https://api.github.com/repos/pydata/xarray/issues/507 MDEyOklzc3VlQ29tbWVudDEyNjg3NzExMg== jhamman 2443309 2015-08-01T07:01:03Z 2015-08-01T07:01:03Z MEMBER

This looks pretty good to me. Are you basically letting pandas do all the testing in terms of the method and range of the indexers? I'm wondering if we need to target any corner cases that extend beyond how pandas does the indexer mapping.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add sel_points for point-wise indexing by label 98498103

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);