issue_comments

Table actions

5 rows where issue = 97861940 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

user 1

  • shoyer · 5 ✖

issue 1

  • discrete colormap option for imshow and pcolormesh · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
126532498 https://github.com/pydata/xarray/issues/500#issuecomment-126532498 https://api.github.com/repos/pydata/xarray/issues/500 MDEyOklzc3VlQ29tbWVudDEyNjUzMjQ5OA== shoyer 1217238 2015-07-31T00:52:38Z 2015-07-31T00:52:38Z MEMBER

Yeah, I guess we would only want a legend if we're truly plotting categorical values (e.g., from pandas.cut)

On Thu, Jul 30, 2015 at 5:31 PM, Clark Fitzgerald notifications@github.com wrote:

The legend definitely looks better than the color bar in the seaborn PR.

Reply to this email directly or view it on GitHub: https://github.com/xray/xray/issues/500#issuecomment-126530340

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   discrete colormap option for imshow and pcolormesh 97861940
126527616 https://github.com/pydata/xarray/issues/500#issuecomment-126527616 https://api.github.com/repos/pydata/xarray/issues/500 MDEyOklzc3VlQ29tbWVudDEyNjUyNzYxNg== shoyer 1217238 2015-07-31T00:18:29Z 2015-07-31T00:18:38Z MEMBER

Also worth taking a look at for possible API and/or code inspiration: https://github.com/mwaskom/seaborn/pull/629

Do we want a color bar or a legend for discrete colormaps?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   discrete colormap option for imshow and pcolormesh 97861940
126470540 https://github.com/pydata/xarray/issues/500#issuecomment-126470540 https://api.github.com/repos/pydata/xarray/issues/500 MDEyOklzc3VlQ29tbWVudDEyNjQ3MDU0MA== shoyer 1217238 2015-07-30T20:22:00Z 2015-07-30T20:22:00Z MEMBER

Instead of adding a separate argument cmap_intervals, it might make sense to call the argument levels -- which is the name of the existing contour/contourf argument. Then, it could work consistently between imshow/pcolormesh/contour/contourf.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   discrete colormap option for imshow and pcolormesh 97861940
126447673 https://github.com/pydata/xarray/issues/500#issuecomment-126447673 https://api.github.com/repos/pydata/xarray/issues/500 MDEyOklzc3VlQ29tbWVudDEyNjQ0NzY3Mw== shoyer 1217238 2015-07-30T19:29:27Z 2015-07-30T19:29:27Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   discrete colormap option for imshow and pcolormesh 97861940
125849396 https://github.com/pydata/xarray/issues/500#issuecomment-125849396 https://api.github.com/repos/pydata/xarray/issues/500 MDEyOklzc3VlQ29tbWVudDEyNTg0OTM5Ng== shoyer 1217238 2015-07-29T05:41:03Z 2015-07-29T05:41:03Z MEMBER

This is also something I often find useful, so +1 from me. contourf does something similar, but it also involves plotting contour lines.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   discrete colormap option for imshow and pcolormesh 97861940

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);