issue_comments

Table actions

6 rows where issue = 976108741 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Remove use of deprecated `kind` argument in `CFTimeIndex` tests · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
950294664 https://github.com/pydata/xarray/pull/5723#issuecomment-950294664 https://api.github.com/repos/pydata/xarray/issues/5723 IC_kwDOAMm_X844pFiI dcherian 2448579 2021-10-24T09:55:30Z 2021-10-24T09:55:30Z MEMBER

Thanks @spencerkclark 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove use of deprecated `kind` argument in `CFTimeIndex` tests 976108741
950239817 https://github.com/pydata/xarray/pull/5723#issuecomment-950239817 https://api.github.com/repos/pydata/xarray/issues/5723 IC_kwDOAMm_X844o4JJ spencerkclark 6628425 2021-10-24T00:51:33Z 2021-10-24T00:51:33Z MEMBER

@mathause I think this should be ready now. I added some version-dependent logic to the tests.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove use of deprecated `kind` argument in `CFTimeIndex` tests 976108741
903098921 https://github.com/pydata/xarray/pull/5723#issuecomment-903098921 https://api.github.com/repos/pydata/xarray/issues/5723 IC_kwDOAMm_X8411DIp github-actions[bot] 41898282 2021-08-21T10:56:00Z 2021-10-24T00:48:45Z CONTRIBUTOR

Unit Test Results

6 files           6 suites   54m 8s :stopwatch: 16 209 tests 14 488 :heavy_check_mark: 1 721 :zzz: 0 :x: 90 450 runs  82 285 :heavy_check_mark: 8 165 :zzz: 0 :x:

Results for commit a3cc075f.

:recycle: This comment has been updated with latest results.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove use of deprecated `kind` argument in `CFTimeIndex` tests 976108741
910277794 https://github.com/pydata/xarray/pull/5723#issuecomment-910277794 https://api.github.com/repos/pydata/xarray/issues/5723 IC_kwDOAMm_X842Qbyi spencerkclark 6628425 2021-09-01T13:18:27Z 2021-09-01T13:18:27Z MEMBER

Oops I forgot about the minimum deps environment. Those failures are indeed real. I guess we could put some version-dependent logic in there.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove use of deprecated `kind` argument in `CFTimeIndex` tests 976108741
910262411 https://github.com/pydata/xarray/pull/5723#issuecomment-910262411 https://api.github.com/repos/pydata/xarray/issues/5723 IC_kwDOAMm_X842QYCL spencerkclark 6628425 2021-09-01T13:02:36Z 2021-09-01T13:02:36Z MEMBER

That's right. I now merged main so hopefully those test failures should clear up.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove use of deprecated `kind` argument in `CFTimeIndex` tests 976108741
910254534 https://github.com/pydata/xarray/pull/5723#issuecomment-910254534 https://api.github.com/repos/pydata/xarray/issues/5723 IC_kwDOAMm_X842QWHG mathause 10194086 2021-09-01T12:53:06Z 2021-09-01T12:53:06Z MEMBER

LGTM - I think the test failure does not come from here?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove use of deprecated `kind` argument in `CFTimeIndex` tests 976108741

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);