issue_comments

Table actions

7 rows where issue = 975385095 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • pandas deprecates Index.get_loc with method · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
908124860 https://github.com/pydata/xarray/issues/5721#issuecomment-908124860 https://api.github.com/repos/pydata/xarray/issues/5721 IC_kwDOAMm_X842IOK8 benbovy 4160723 2021-08-30T07:52:10Z 2021-08-30T07:52:10Z MEMBER

Not sure that #5692 will be ready for the next release so I'll do this in a separate PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pandas deprecates Index.get_loc with method 975385095
908118179 https://github.com/pydata/xarray/issues/5721#issuecomment-908118179 https://api.github.com/repos/pydata/xarray/issues/5721 IC_kwDOAMm_X842IMij mathause 10194086 2021-08-30T07:47:10Z 2021-08-30T07:47:10Z MEMBER

👍 I can take care of it in #5692 or in a separate PR.

I don't have a strong opinion but would be good to do this before the next release.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pandas deprecates Index.get_loc with method 975385095
903880943 https://github.com/pydata/xarray/issues/5721#issuecomment-903880943 https://api.github.com/repos/pydata/xarray/issues/5721 IC_kwDOAMm_X8414CDv benbovy 4160723 2021-08-23T15:34:59Z 2021-08-23T15:34:59Z MEMBER

👍 I can take care of it in #5692 or in a separate PR.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pandas deprecates Index.get_loc with method 975385095
903141020 https://github.com/pydata/xarray/issues/5721#issuecomment-903141020 https://api.github.com/repos/pydata/xarray/issues/5721 IC_kwDOAMm_X8411Nac jbrockmendel 8078968 2021-08-21T16:28:07Z 2021-08-21T16:28:07Z NONE

The "if method is not None" approach seems reasonable. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pandas deprecates Index.get_loc with method 975385095
903095007 https://github.com/pydata/xarray/issues/5721#issuecomment-903095007 https://api.github.com/repos/pydata/xarray/issues/5721 IC_kwDOAMm_X8411CLf spencerkclark 6628425 2021-08-21T10:18:33Z 2021-08-21T10:18:33Z MEMBER

Exactly, yeah, those are the problematic lines. That's an elegant solution. I think it will work with the minor modification to raise a KeyError if any of the indices returned by get_indexer_nd are less than zero: python if method is not None: indexer = get_indexer_nd(self.index, label, method, tolerance) if np.any(indexer < 0): raise KeyError(f"not all values found in index {coord_name!r}") else: indexer = self.index.get_loc(label_value)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pandas deprecates Index.get_loc with method 975385095
902992039 https://github.com/pydata/xarray/issues/5721#issuecomment-902992039 https://api.github.com/repos/pydata/xarray/issues/5721 IC_kwDOAMm_X8410pCn shoyer 1217238 2021-08-20T22:37:53Z 2021-08-20T22:37:53Z MEMBER

These lines seem to be the problematic place? https://github.com/pydata/xarray/blob/e26aec9500e04f3b926b248988b976dbfcb9c632/xarray/core/indexes.py#L233-L235

We might be able to do something like: python if method is not None: indexer = get_indexer_nd(self.index, label, method, tolerance) else: indexer = self.index.get_loc(label_value)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pandas deprecates Index.get_loc with method 975385095
902918293 https://github.com/pydata/xarray/issues/5721#issuecomment-902918293 https://api.github.com/repos/pydata/xarray/issues/5721 IC_kwDOAMm_X8410XCV spencerkclark 6628425 2021-08-20T19:47:19Z 2021-08-20T19:47:19Z MEMBER

Thanks for the heads up @mathause. We'll need to think carefully about this with respect to partial datetime string indexing. DatetimeIndex.get_indexer and DatetimeIndex.get_loc behave differently with respect to datetime strings. get_indexer interprets strings as specific dates, while get_loc interprets them as ranges: ```

import pandas as pd times = pd.date_range("2000", periods=5) times.get_indexer(["2000"]) array([0]) times.get_loc("2000") slice(0, 5, None) `` In other words -- at least for partial datetime string indexing -- it may not be as simple as swapping inget_indexerforget_loc`.

Perhaps @jbrockmendel has thoughts on how we should approach this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pandas deprecates Index.get_loc with method 975385095

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);