issue_comments

Table actions

2 rows where issue = 966669714 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • MultiIndex coordinates loc/sel not working in 0.19.0 · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
897609802 https://github.com/pydata/xarray/issues/5691#issuecomment-897609802 https://api.github.com/repos/pydata/xarray/issues/5691 IC_kwDOAMm_X841gHBK benbovy 4160723 2021-08-12T12:46:22Z 2021-08-12T12:46:22Z MEMBER

So the issue was that #3153 doesn't work well with multi-indexes that don't like numpy arrays nor even numpy scalars given as labels. Previously it worked because of multi-index virtual coordinates, i.e., the dtype of multi-index levels was ignored when internally re-organizing the indexers passed to .sel in xarray. However, this is not the case anymore as we are currently dropping virtual coordinates by real coordinates in the context of xarray's explicit indexes refactoring.

This should be fixed in #5692 (https://github.com/pydata/xarray/pull/5692/commits/a551c7f05abf90a492fb59068b59ebb2bac8cb4c), although #3153 still doesn't address the case of multi-index level coordinates with float32 values.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   MultiIndex coordinates loc/sel not working in 0.19.0 966669714
896960401 https://github.com/pydata/xarray/issues/5691#issuecomment-896960401 https://api.github.com/repos/pydata/xarray/issues/5691 IC_kwDOAMm_X841doeR benbovy 4160723 2021-08-11T16:13:26Z 2021-08-11T16:13:26Z MEMBER

Thanks for the report @genric. Probably some regression introduced in #5322. I'm surprised this hasn't been caught in the tests. I'm also surprised that it seems to be fixed in #5692. I'll take a closer look.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   MultiIndex coordinates loc/sel not working in 0.19.0 966669714

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);