issue_comments

Table actions

5 rows where issue = 962647570 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • max-sixty · 5 ✖

issue 1

  • Add typing to the OPTIONS dict · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
902287190 https://github.com/pydata/xarray/pull/5678#issuecomment-902287190 https://api.github.com/repos/pydata/xarray/issues/5678 IC_kwDOAMm_X841x89W max-sixty 5635139 2021-08-19T22:15:34Z 2021-08-19T22:17:14Z MEMBER

Thanks @Illviljan !

Please feel free to add a whatsnew in another PR, maybe as a batch for some of your PRs :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add typing to the OPTIONS dict 962647570
902287027 https://github.com/pydata/xarray/pull/5678#issuecomment-902287027 https://api.github.com/repos/pydata/xarray/issues/5678 IC_kwDOAMm_X841x86z max-sixty 5635139 2021-08-19T22:15:15Z 2021-08-19T22:15:15Z MEMBER

This looks really good!

I didn't know about Literal, TIL. We could use that in more places too, I guess.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add typing to the OPTIONS dict 962647570
894545722 https://github.com/pydata/xarray/pull/5678#issuecomment-894545722 https://api.github.com/repos/pydata/xarray/issues/5678 IC_kwDOAMm_X841Ua86 max-sixty 5635139 2021-08-06T22:17:16Z 2021-08-06T22:17:16Z MEMBER

Yeah, we had similar issues in https://github.com/pydata/xarray/pull/5624

But I think it's fine if it's messy for now given there's a clear path to clean it up when we move to 3.8.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add typing to the OPTIONS dict 962647570
894446124 https://github.com/pydata/xarray/pull/5678#issuecomment-894446124 https://api.github.com/repos/pydata/xarray/issues/5678 IC_kwDOAMm_X841UCos max-sixty 5635139 2021-08-06T18:35:59Z 2021-08-06T18:35:59Z MEMBER

As long as it passes mypy on 3.7, I think that's fine. If we're not sure, it's worth confirming that it does pass, either locally or adding a pre-commit task...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add typing to the OPTIONS dict 962647570
894373712 https://github.com/pydata/xarray/pull/5678#issuecomment-894373712 https://api.github.com/repos/pydata/xarray/issues/5678 IC_kwDOAMm_X841Tw9Q max-sixty 5635139 2021-08-06T16:26:37Z 2021-08-06T16:26:37Z MEMBER

This looks cool! You're ahead of me on the new python features @Illviljan !

Any thoughts before we merge?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add typing to the OPTIONS dict 962647570

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);