issue_comments

Table actions

3 rows where issue = 959604710 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Fix typing for coords argument in DataArray · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1000265317 https://github.com/pydata/xarray/issues/5671#issuecomment-1000265317 https://api.github.com/repos/pydata/xarray/issues/5671 IC_kwDOAMm_X847ntZl H0R5E 5088535 2021-12-23T12:16:26Z 2021-12-23T12:18:22Z NONE

My issue might actually be fixed in main.

EDIT: Change was made in #5728

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix typing for coords argument in DataArray 959604710
1000257950 https://github.com/pydata/xarray/issues/5671#issuecomment-1000257950 https://api.github.com/repos/pydata/xarray/issues/5671 IC_kwDOAMm_X847nrme H0R5E 5088535 2021-12-23T12:03:09Z 2021-12-23T12:03:09Z NONE

I can confirm this issue when specifying dimensions with coordinates, as per this example:

``` import xarray as xr

z = -1 x = [1, 2, 3] y = [4, 5, 6] data = [0, 0, 0]

coords = {"z": z, "x": ("dim_0", x), "y": ("dim_0", y)}

xr.DataArray(data, coords=coords) ```

MyPy output:

error: Argument "coords" to "DataArray" has incompatible type "Dict[str, object]"; expected "Union[Sequence[Tuple[Any, ...]], Mapping[Hashable, Any], None]"

I can work around it by specifying the type of coords explicitly:

``` from typing import Any, Hashable, Mapping

import xarray as xr

z = -1 x = [1, 2, 3] y = [4, 5, 6] data = [0, 0, 0]

coords: Mapping[Hashable, Any] = {"z": z, "x": ("dim_0", x), "y": ("dim_0", y)}

xr.DataArray(data, coords=coords) ```

Success: no issues found in 1 source file

There is some discussion about str and Hashable in this issue, but type invariance is still a little over my head, TBH.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix typing for coords argument in DataArray 959604710
892238900 https://github.com/pydata/xarray/issues/5671#issuecomment-892238900 https://api.github.com/repos/pydata/xarray/issues/5671 IC_kwDOAMm_X841Lnw0 max-sixty 5635139 2021-08-03T23:43:38Z 2021-08-03T23:43:38Z MEMBER

Good spot, thanks @DeltaSigma130 .

I think this should be a fairly easy fix if anyone is up for taking this. I'm somewhat surprised that it's not covered in our existing code such that mypy fails within xarray.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix typing for coords argument in DataArray 959604710

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);