issue_comments

Table actions

8 rows where issue = 957432870 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Speed up _mapping_repr · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
890482230 https://github.com/pydata/xarray/pull/5661#issuecomment-890482230 https://api.github.com/repos/pydata/xarray/issues/5661 IC_kwDOAMm_X841E642 github-actions[bot] 41898282 2021-08-01T09:13:22Z 2021-08-02T20:14:06Z CONTRIBUTOR

Unit Test Results

6 files  ±0           6 suites  ±0   51m 27s :stopwatch: ±0s 16 200 tests ±0  14 468 :heavy_check_mark: ±0  1 732 :zzz: ±0  0 :x: ±0  90 396 runs  ±0  82 224 :heavy_check_mark: ±0  8 172 :zzz: ±0  0 :x: ±0 

Results for commit 8f5b4a18. ± Comparison against base commit 8f5b4a18.

:recycle: This comment has been updated with latest results.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Speed up _mapping_repr 957432870
891285564 https://github.com/pydata/xarray/pull/5661#issuecomment-891285564 https://api.github.com/repos/pydata/xarray/issues/5661 IC_kwDOAMm_X841H_A8 max-sixty 5635139 2021-08-02T19:45:28Z 2021-08-02T19:45:28Z MEMBER

Another great one @Illviljan ! Thank you!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Speed up _mapping_repr 957432870
891187358 https://github.com/pydata/xarray/pull/5661#issuecomment-891187358 https://api.github.com/repos/pydata/xarray/issues/5661 IC_kwDOAMm_X841HnCe Illviljan 14371165 2021-08-02T17:06:41Z 2021-08-02T17:07:30Z MEMBER

Ok, if you got 15 seconds as well I'm satisfied. I was just worried I had something else affecting my results.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Speed up _mapping_repr 957432870
891179723 https://github.com/pydata/xarray/pull/5661#issuecomment-891179723 https://api.github.com/repos/pydata/xarray/issues/5661 IC_kwDOAMm_X841HlLL dcherian 2448579 2021-08-02T16:56:36Z 2021-08-02T16:56:36Z MEMBER

3x is good! I reduced the size so it would run faster, we can't run a 15s benchmark every time we benchmark an older commit...

Can you add a whats-new note please?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Speed up _mapping_repr 957432870
891174032 https://github.com/pydata/xarray/pull/5661#issuecomment-891174032 https://api.github.com/repos/pydata/xarray/issues/5661 IC_kwDOAMm_X841HjyQ Illviljan 14371165 2021-08-02T16:47:12Z 2021-08-02T16:47:12Z MEMBER

The benchmark uses (only) 100 arrays so I suppose there isn't as big of difference at that point. Did you get similar values as me with 2000, @dcherian ?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Speed up _mapping_repr 957432870
891156817 https://github.com/pydata/xarray/pull/5661#issuecomment-891156817 https://api.github.com/repos/pydata/xarray/issues/5661 IC_kwDOAMm_X841HflR dcherian 2448579 2021-08-02T16:20:06Z 2021-08-02T16:20:06Z MEMBER

I pushed a benchmark...

this branch: [ 31.25%] ··· repr.Repr.time_repr 14.8±0.3ms [ 37.50%] ··· repr.Repr.time_repr_html 164±1ms

main: [ 31.25%] ··· repr.Repr.time_repr 41.6±0.5ms [ 37.50%] ··· repr.Repr.time_repr_html 188±1ms

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Speed up _mapping_repr 957432870
891137073 https://github.com/pydata/xarray/pull/5661#issuecomment-891137073 https://api.github.com/repos/pydata/xarray/issues/5661 IC_kwDOAMm_X841Hawx dcherian 2448579 2021-08-02T15:54:15Z 2021-08-02T15:54:15Z MEMBER

I haven't had time to understand why it's so dramatic

The old way creates all dataarrays (2000 in this case). This version creates first_rows+last_rows dataarrays. Very nice idea @Illviljan !

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Speed up _mapping_repr 957432870
890711166 https://github.com/pydata/xarray/pull/5661#issuecomment-890711166 https://api.github.com/repos/pydata/xarray/issues/5661 IC_kwDOAMm_X841Fyx- max-sixty 5635139 2021-08-02T04:47:42Z 2021-08-02T04:47:42Z MEMBER

Wow, that's quite the speed up! I haven't had time to understand why it's so dramatic, but let's merge unless there are any objections. Feel free to add a whatsnew @Illviljan 

{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Speed up _mapping_repr 957432870

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);