issue_comments

Table actions

2 rows where issue = 957201551 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Allow .attrs to use dict-likes · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
892477231 https://github.com/pydata/xarray/issues/5655#issuecomment-892477231 https://api.github.com/repos/pydata/xarray/issues/5655 IC_kwDOAMm_X841Mh8v Illviljan 14371165 2021-08-04T08:39:53Z 2021-08-04T08:39:53Z MEMBER

I'm not so sure it simplifies that considerably. The linked PR is the minimal changes I had to do to get it working for my use cases and most of the changes were just removing unneccessary dict(x). I admittedly haven't checked every part of the code yet though.

My files have 2000+ variables with each variable having like 8 attributes. It starts taking a while when you have to read each one of those. At the moment, reading from file to Dataset takes about 2s, 600ms of those were reading attributes. With the PR I got it down to 200ms. Not as much as I'd hoped but I think I can get my LazyDict implementation much faster.

Changing file formats is too large of a change. We have used hdf5-files for many years and just switching to a different file format is just not something you do in painless way without (fast) backwards compatible alternative. It's hard to motivate a switch to xarray if the old alternative reads in files faster.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow .attrs to use dict-likes 957201551
892275313 https://github.com/pydata/xarray/issues/5655#issuecomment-892275313 https://api.github.com/repos/pydata/xarray/issues/5655 IC_kwDOAMm_X841Lwpx shoyer 1217238 2021-08-04T00:55:40Z 2021-08-04T00:55:40Z MEMBER

I appreciate the concern here, but I'm not sure we want to relax this constraint. Using built-in Python dict objects simplifies Xarray's internal logic considerably.

Could you talk a little bit more about your use-case and why you need lazy attributes? How many attributes are in your HDF5 files and how slow are they to load? Have you considered alternative file formats?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Allow .attrs to use dict-likes 957201551

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);