home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

7 rows where issue = 957131705 and user = 6213168 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • crusaderky · 7 ✖

issue 1

  • recent versions of sparse and dask seem to be incompatible with our tests · 7 ✖

author_association 1

  • MEMBER 7
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
906684380 https://github.com/pydata/xarray/issues/5654#issuecomment-906684380 https://api.github.com/repos/pydata/xarray/issues/5654 IC_kwDOAMm_X842Cufc crusaderky 6213168 2021-08-26T19:30:25Z 2021-08-26T19:50:20Z MEMBER

Third and final issue is when numpy.broadcast_to is applied to the output of zeros_like: ```

import sparse s = sparse.COO.from_numpy([0, 0, 1, 2]) np.broadcast_to(np.zeros_like(s.todense(), shape=()), (3, )) array([0, 0, 0]) np.broadcast_to(np.zeros_like(s, shape=()), (3, )) ValueError: The data length does not match the coordinates given. len(data) = 0, but 3 coords specified. ```

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  recent versions of sparse and dask seem to be incompatible with our tests 957131705
906633901 https://github.com/pydata/xarray/issues/5654#issuecomment-906633901 https://api.github.com/repos/pydata/xarray/issues/5654 IC_kwDOAMm_X842CiKt crusaderky 6213168 2021-08-26T18:15:29Z 2021-08-26T19:47:12Z MEMBER

Ah, shape= was very recently added in 0.12.0. It wasn't there in 0.11.2.

[EDIT] It is not the only problem. Investigating further.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  recent versions of sparse and dask seem to be incompatible with our tests 957131705
906656030 https://github.com/pydata/xarray/issues/5654#issuecomment-906656030 https://api.github.com/repos/pydata/xarray/issues/5654 IC_kwDOAMm_X842Cnke crusaderky 6213168 2021-08-26T18:47:32Z 2021-08-26T18:47:42Z MEMBER

The second issue is that sparse.zeros_like doesn't accept the order= parameter, which is required by the same dask code linked above (it's in the kwargs in dask/wrap.py:133). This in turn triggers an unfortunate handling of TypeError on behalf of @curry, which obfuscates the exception.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  recent versions of sparse and dask seem to be incompatible with our tests 957131705
906621248 https://github.com/pydata/xarray/issues/5654#issuecomment-906621248 https://api.github.com/repos/pydata/xarray/issues/5654 IC_kwDOAMm_X842CfFA crusaderky 6213168 2021-08-26T17:56:52Z 2021-08-26T18:02:53Z MEMBER

da.zeros_like(a) internally invokes da.zeros(a.shape, meta=a._meta) which internally invokes np.broadcast(np.zeros_like(a._meta, shape=1), a.shape)

The problem is that sparse.zeros_like does not accept the shape= optional parameter, which is new in numpy 1.17.

This is where it gets triggered: https://github.com/dask/dask/blob/85f0b14bd36a5135ce51aeee067b6207374b00c4/dask/array/wrap.py#L128-L168

I don't think dask should write a workaround to this, and it should be just fixed upstream? CC @jrbourbeau for opinion.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  recent versions of sparse and dask seem to be incompatible with our tests 957131705
906584459 https://github.com/pydata/xarray/issues/5654#issuecomment-906584459 https://api.github.com/repos/pydata/xarray/issues/5654 IC_kwDOAMm_X842CWGL crusaderky 6213168 2021-08-26T17:02:09Z 2021-08-26T17:02:09Z MEMBER

Narrowed it down.

```python

import dask.array as da import sparse s = sparse.COO.from_numpy([0, 0, 1, 2]) a = da.from_array(s) z = da.zeros_like(a) z dask.array<zeros_like, shape=(4,), dtype=int64, chunksize=(4,), chunktype=sparse.COO> z.compute() <function _broadcast_trick_inner at 0x7fb8a3874e50> ``` numpy-1.20.1 dask-2021.3.0 sparse-0.11.2

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  recent versions of sparse and dask seem to be incompatible with our tests 957131705
906479974 https://github.com/pydata/xarray/issues/5654#issuecomment-906479974 https://api.github.com/repos/pydata/xarray/issues/5654 IC_kwDOAMm_X842B8lm crusaderky 6213168 2021-08-26T14:48:38Z 2021-08-26T14:48:38Z MEMBER

I see now. I got really confused by the matplotlib issue which is what the opening post of this ticket is about. Would it be possible to have the two issues tracked by separate tickets?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  recent versions of sparse and dask seem to be incompatible with our tests 957131705
906475469 https://github.com/pydata/xarray/issues/5654#issuecomment-906475469 https://api.github.com/repos/pydata/xarray/issues/5654 IC_kwDOAMm_X842B7fN crusaderky 6213168 2021-08-26T14:43:13Z 2021-08-26T14:43:13Z MEMBER

I'm a bit lost. The failure in xarray/tests/test_sparse.py::test_chunk doesn't appear anywhere in recent CI runs and I can't reproduce it locally.

The ongoing failures in upstream-dev: FAILED xarray/tests/test_plot.py::TestFacetGrid::test_can_set_norm FAILED xarray/tests/test_plot.py::TestCFDatetimePlot::test_cfdatetime_line_plot FAILED xarray/tests/test_plot.py::TestCFDatetimePlot::test_cfdatetime_pcolormesh_plot FAILED xarray/tests/test_plot.py::TestCFDatetimePlot::test_cfdatetime_contour_plot Aren't in any way related to either sparse or dask; they appear when I upgrade matplotlib from 3.4.3 to 3.5.0b1.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  recent versions of sparse and dask seem to be incompatible with our tests 957131705

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 25.613ms · About: xarray-datasette