issue_comments

Table actions

1 row where issue = 951121126 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 1 ✖

issue 1

  • remove deprecations scheduled for 0.19 · 1 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
885801454 https://github.com/pydata/xarray/pull/5630#issuecomment-885801454 https://api.github.com/repos/pydata/xarray/issues/5630 IC_kwDOAMm_X840zEHu shoyer 1217238 2021-07-23T17:50:16Z 2021-07-23T17:50:57Z MEMBER

I would still return something from Dataset.update() for now.

I agree that it would be great to remove it, but to do that perhaps we could make some of Dataset subclass that issues a warning when any method is called on it? Perhaps something like: ```python import xarray import warnings

class DeprecatedDatasetFromUpdate(xarray.Dataset): slots = ['_accessed']

def init(self, args, kwargs): self._accessed = False super().init(args, **kwargs)

def getattribute(self, key): if not super().getattribute('_accessed'): warnings.warn( "This xarray.Dataset was created as the return value of " "xarray.Dataset.update(), but update() will return None in the " "future", category=FutureWarning) self._accessed = True return super().getattribute(key) ```

But could be a little tricky to get right, so perhaps let's save this for a later PR.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   remove deprecations scheduled for 0.19 951121126

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);