issue_comments

Table actions

3 rows where issue = 945226829 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • max-sixty · 3 ✖

issue 1

  • Add option to pass callable assertion failure message generator · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
881967812 https://github.com/pydata/xarray/pull/5607#issuecomment-881967812 https://api.github.com/repos/pydata/xarray/issues/5607 IC_kwDOAMm_X840kcLE max-sixty 5635139 2021-07-17T22:25:54Z 2021-07-17T22:25:54Z MEMBER

@naught101 to what extent do you think your wants are idiosyncratic vs. better overall? To the extent this is for things that would make the function better for all, then one option is to implement them; e.g. add f"Largest difference in data is {abs(a-b).max().item()}"`.

Possibly that reduces the opportunity to experiment though? People could probably monkey-patch the function in their own environments if they want. And I think we can also be fairly liberal about merging changes given the output is read by people.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add option to pass callable assertion failure message generator 945226829
881269881 https://github.com/pydata/xarray/pull/5607#issuecomment-881269881 https://api.github.com/repos/pydata/xarray/issues/5607 IC_kwDOAMm_X840hxx5 max-sixty 5635139 2021-07-16T08:23:52Z 2021-07-16T08:23:52Z MEMBER

My particular use case is that have datasets that are large enough that I can't see the full diff, so might miss major changes. I'm wanting to pass in something like lambda a, b: f"Largest difference in data is {abs(a-b).max().item()}", so I can quickly see if the changes are meaningful. Obviously a more complex function might also be useful, like a summary/describe table output of the differences..

Whether or not we merge this, I would be a +1 on improving the output of the canonical function better, such that we can see differences easily. I would also imagine we can iterate on those without worrying about backward-compat, given this is generating output for people.

As an example, printing the result of the exact statement above for large arrays, maybe also with dimension values, would be great!

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add option to pass callable assertion failure message generator 945226829
880889091 https://github.com/pydata/xarray/pull/5607#issuecomment-880889091 https://api.github.com/repos/pydata/xarray/issues/5607 MDEyOklzc3VlQ29tbWVudDg4MDg4OTA5MQ== max-sixty 5635139 2021-07-15T17:40:11Z 2021-07-15T17:40:11Z MEMBER

(if we do this we should make it kwarg-only)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add option to pass callable assertion failure message generator 945226829

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);