issue_comments

Table actions

4 rows where issue = 94417601 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date)

user 1

  • shoyer · 4 ✖

issue 1

  • Feature plotting · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
122745978 https://github.com/pydata/xarray/pull/466#issuecomment-122745978 https://api.github.com/repos/pydata/xarray/issues/466 MDEyOklzc3VlQ29tbWVudDEyMjc0NTk3OA== shoyer 1217238 2015-07-20T03:20:11Z 2015-07-20T03:20:11Z MEMBER

Let's follow up on this with some smaller PRs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature plotting 94417601
122618273 https://github.com/pydata/xarray/pull/466#issuecomment-122618273 https://api.github.com/repos/pydata/xarray/issues/466 MDEyOklzc3VlQ29tbWVudDEyMjYxODI3Mw== shoyer 1217238 2015-07-19T03:01:36Z 2015-07-19T03:01:36Z MEMBER

Re Python 3 compatibility with xray.DataArray(d_ylog, zip(('y', 'x'), (y, x))) it would be nice if the DataArray constructor accepted an iterable. Thoughts?

Agreed. Want to add a fix?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature plotting 94417601
122582764 https://github.com/pydata/xarray/pull/466#issuecomment-122582764 https://api.github.com/repos/pydata/xarray/issues/466 MDEyOklzc3VlQ29tbWVudDEyMjU4Mjc2NA== shoyer 1217238 2015-07-18T19:18:24Z 2015-07-18T19:18:24Z MEMBER

Have you tried the ioos conda channel for cartopy? They do a really nice job maintaining builds.

On Sat, Jul 18, 2015 at 11:30 AM, Joe Hamman notifications@github.com wrote:

@clarkfitzg - I just spent some time running through your examples and trying to plot some of my own data. Overall - this is really slick and I really liked what you have going here. Below are a few comments I made along the way - take them or leave them. 1. Consider yincrease=True as the default. Maybe there is a downside to this but I don't see it. I'm pretty sure it is just the convention of imshow. 1. It may be worth mentioning why you are using imshow over pcolormesh. The limitation of imshow having regularly spaced coordinates will be important to some (myself included). We may, at some point, want to add an option for using pcolormesh. This would support irregular grids without forcing the use of contourf. 1. More examples with cartopy would be good. Maybe we can put together example page here: http://xray.readthedocs.org/en/latest/examples.html

1. I continue to have cartopy install problems on osx, even with python2.7 using anaconda. I also had problems on a clean docker image. I know this has nothing to do with this PR but the problems with installing cartopy will limit its applicability here.

Reply to this email directly or view it on GitHub: https://github.com/xray/xray/pull/466#issuecomment-122576123

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature plotting 94417601
122483377 https://github.com/pydata/xarray/pull/466#issuecomment-122483377 https://api.github.com/repos/pydata/xarray/issues/466 MDEyOklzc3VlQ29tbWVudDEyMjQ4MzM3Nw== shoyer 1217238 2015-07-18T04:40:38Z 2015-07-18T04:40:38Z MEMBER

@jhamman I'd be happy to bundle viridis with xray as the default colormap (the source code is here) -- or we could just wait a few months, at which time it will be the matplotlib default.

@nbren12 Seaborn has some heuristics for picking sequential vs diverging colormaps. Possibly worth borrowing: https://github.com/mwaskom/seaborn/blob/v0.6.0/seaborn/matrix.py#L158

My inclination is to merge this on master and iterate in future PRs. There are still a few things to fix, but this is a great start.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature plotting 94417601

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);