issue_comments

Table actions

3 rows where issue = 940702754 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Call .compute() in all plot methods? · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
877287358 https://github.com/pydata/xarray/issues/5589#issuecomment-877287358 https://api.github.com/repos/pydata/xarray/issues/5589 MDEyOklzc3VlQ29tbWVudDg3NzI4NzM1OA== dcherian 2448579 2021-07-09T15:57:27Z 2021-07-09T15:57:27Z MEMBER

We should create a DataArray with just the data that is needed based on x, y etc. and then call compute on the whole thing, rather than computing x separately and y separately.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Call .compute() in all plot methods? 940702754
877278379 https://github.com/pydata/xarray/issues/5589#issuecomment-877278379 https://api.github.com/repos/pydata/xarray/issues/5589 MDEyOklzc3VlQ29tbWVudDg3NzI3ODM3OQ== TomNicholas 35968931 2021-07-09T15:42:50Z 2021-07-09T15:42:50Z MEMBER

But let me know if you spot anywhere that #5561 isn't going to cover with to_numpy() calls!

I guess the 1d plot functions would all need to be modified individually.

@Illviljan was talking about adding a @_plot1d decorator like the 2d one, which might be a good place to enforce this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Call .compute() in all plot methods? 940702754
877268860 https://github.com/pydata/xarray/issues/5589#issuecomment-877268860 https://api.github.com/repos/pydata/xarray/issues/5589 MDEyOklzc3VlQ29tbWVudDg3NzI2ODg2MA== TomNicholas 35968931 2021-07-09T15:27:24Z 2021-07-09T15:27:24Z MEMBER

We should be calling .compute() before passing anything to matplotlib - if we're not then that's a bug. I've also noticed that not doing so can cause huge slowdown.

I think that #5561 might (or really should) fix this as a side effect though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Call .compute() in all plot methods? 940702754

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);