issue_comments

Table actions

15 rows where issue = 940054482 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Release v0.19? · 15 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
885957406 https://github.com/pydata/xarray/issues/5588#issuecomment-885957406 https://api.github.com/repos/pydata/xarray/issues/5588 IC_kwDOAMm_X840zqMe shoyer 1217238 2021-07-23T23:15:39Z 2021-07-23T23:15:39Z MEMBER

Thanks Tom and everyone else who helped out!

On Fri, Jul 23, 2021 at 3:09 PM Tom Nicholas @.***> wrote:

Good news everyone! The release is done.

— You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/issues/5588#issuecomment-885938059, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJJFVQEEK66RGURLARNT5TTZHSARANCNFSM5ABEGYEQ . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Release v0.19? 940054482
885938059 https://github.com/pydata/xarray/issues/5588#issuecomment-885938059 https://api.github.com/repos/pydata/xarray/issues/5588 IC_kwDOAMm_X840zleL TomNicholas 35968931 2021-07-23T22:09:02Z 2021-07-23T22:09:02Z MEMBER

Good news everyone! The release is done.

 
{
    "total_count": 2,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 2,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Release v0.19? 940054482
885289900 https://github.com/pydata/xarray/issues/5588#issuecomment-885289900 https://api.github.com/repos/pydata/xarray/issues/5588 IC_kwDOAMm_X840xHOs dcherian 2448579 2021-07-22T23:02:24Z 2021-07-22T23:02:24Z MEMBER

Just merged the blocker. @TomNicholas we should be good to release.

 
{
    "total_count": 2,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 2,
    "eyes": 0
}
   Release v0.19? 940054482
885271773 https://github.com/pydata/xarray/issues/5588#issuecomment-885271773 https://api.github.com/repos/pydata/xarray/issues/5588 IC_kwDOAMm_X840xCzd tlvu 11966697 2021-07-22T22:17:11Z 2021-07-22T22:17:11Z NONE

Is it possible to make quick release of xarray? Without a release containing PR https://github.com/pydata/xarray/pull/5359, we are forced to pin pandas below 1.3.0. Thanks !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Release v0.19? 940054482
884543369 https://github.com/pydata/xarray/issues/5588#issuecomment-884543369 https://api.github.com/repos/pydata/xarray/issues/5588 IC_kwDOAMm_X840uQ-J TomNicholas 35968931 2021-07-21T22:38:57Z 2021-07-21T22:38:57Z MEMBER

Is this just blocking on #5495? What did we decide to do there?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Release v0.19? 940054482
881787108 https://github.com/pydata/xarray/issues/5588#issuecomment-881787108 https://api.github.com/repos/pydata/xarray/issues/5588 IC_kwDOAMm_X840jwDk shoyer 1217238 2021-07-17T00:48:39Z 2021-07-17T00:48:39Z MEMBER

I'd like to consider rolling back the addition of typing-extensions as a required dependency before issuing the release: https://github.com/pydata/xarray/issues/5495

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Release v0.19? 940054482
881656736 https://github.com/pydata/xarray/issues/5588#issuecomment-881656736 https://api.github.com/repos/pydata/xarray/issues/5588 IC_kwDOAMm_X840jQOg TomNicholas 35968931 2021-07-16T19:05:37Z 2021-07-16T19:05:37Z MEMBER

@max-sixty I think it somewhat depends on the intended purpose of the release: new features or bug fixes? Here the primary motivation was a bug fix so I agree with you in this case.

On Fri, 16 Jul 2021, 12:31 Maximilian Roos, @.***> wrote:

I basically think we should never wait for PRs, or spend time "rounding them up" before doing a release. Stuff is going to go in at some point, and exactly when doesn't matter as much as reducing the burden of doing releases. Indeed — even if we're only attempting to reduce the time between code merging and being released — we'd arguably reduce that more by forgoing this rounding up effort, making releases easier and more frequent.

The only argument I can see is that it's some "call to action" that helps motivate people to push something over the edge.

(but not super confident and realize I am maybe contra-consensus, so weigh appropriately)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/issues/5588#issuecomment-881639368, or unsubscribe https://github.com/notifications/unsubscribe-auth/AISNPI6RT2U2VKR5KPSTYLTTYB3JXANCNFSM5ABEGYEQ . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Release v0.19? 940054482
881639368 https://github.com/pydata/xarray/issues/5588#issuecomment-881639368 https://api.github.com/repos/pydata/xarray/issues/5588 IC_kwDOAMm_X840jL_I max-sixty 5635139 2021-07-16T18:31:44Z 2021-07-16T18:31:44Z MEMBER

I basically think we should never wait for PRs, or spend time "rounding them up" before doing a release. Stuff is going to go in at some point, and exactly when doesn't matter as much as reducing the burden of doing releases. Indeed — even if we're only attempting to reduce the time between code merging and being released — we'd arguably reduce that more by forgoing this rounding up effort, making releases easier and more frequent.

The only argument I can see is that it's some "call to action" that helps motivate people to push something over the edge.

(but not super confident and realize I am maybe contra-consensus, so weigh appropriately)

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Release v0.19? 940054482
881570228 https://github.com/pydata/xarray/issues/5588#issuecomment-881570228 https://api.github.com/repos/pydata/xarray/issues/5588 IC_kwDOAMm_X840i7G0 dcherian 2448579 2021-07-16T16:26:51Z 2021-07-16T16:26:51Z MEMBER

Should we do the release soon anyway?

Yes!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Release v0.19? 940054482
881158084 https://github.com/pydata/xarray/issues/5588#issuecomment-881158084 https://api.github.com/repos/pydata/xarray/issues/5588 IC_kwDOAMm_X840hWfE TomNicholas 35968931 2021-07-16T03:58:39Z 2021-07-16T04:00:20Z MEMBER

I know I volunteered to do this release, but some of the PRs I wanted to include have taken longer than I thought they would (particularly #5571), and now I'm going to be away from a computer from tomorrow until near the end of next week.

Should we do the release soon anyway?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Release v0.19? 940054482
877490956 https://github.com/pydata/xarray/issues/5588#issuecomment-877490956 https://api.github.com/repos/pydata/xarray/issues/5588 MDEyOklzc3VlQ29tbWVudDg3NzQ5MDk1Ng== keewis 14808389 2021-07-09T22:34:28Z 2021-07-09T22:34:28Z MEMBER

there are also a few deprecations scheduled for removal in 0.19

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Release v0.19? 940054482
876610545 https://github.com/pydata/xarray/issues/5588#issuecomment-876610545 https://api.github.com/repos/pydata/xarray/issues/5588 MDEyOklzc3VlQ29tbWVudDg3NjYxMDU0NQ== dcherian 2448579 2021-07-08T17:19:22Z 2021-07-08T17:19:22Z MEMBER

@keewis See #4696 . that whats-new note is in the wrong place which is why I couldn't find it yesterday

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Release v0.19? 940054482
876608603 https://github.com/pydata/xarray/issues/5588#issuecomment-876608603 https://api.github.com/repos/pydata/xarray/issues/5588 MDEyOklzc3VlQ29tbWVudDg3NjYwODYwMw== keewis 14808389 2021-07-08T17:16:01Z 2021-07-08T17:16:01Z MEMBER

we were also wondering whether a renamed kwarg went through a deprecation cycle, but I can't find that PR. Has it been merged, yet?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Release v0.19? 940054482
876602541 https://github.com/pydata/xarray/issues/5588#issuecomment-876602541 https://api.github.com/repos/pydata/xarray/issues/5588 MDEyOklzc3VlQ29tbWVudDg3NjYwMjU0MQ== dcherian 2448579 2021-07-08T17:06:30Z 2021-07-08T17:06:30Z MEMBER

There's a breaking change so it should be 0.19.0: https://xarray.pydata.org/en/latest/whats-new.html

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Release v0.19? 940054482
876599942 https://github.com/pydata/xarray/issues/5588#issuecomment-876599942 https://api.github.com/repos/pydata/xarray/issues/5588 MDEyOklzc3VlQ29tbWVudDg3NjU5OTk0Mg== keewis 14808389 2021-07-08T17:02:35Z 2021-07-08T17:02:35Z MEMBER

is there a way to tag only the core dev team?

as long as you're a member you can use @pydata/xarray

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Release v0.19? 940054482

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);