issue_comments

Table actions

9 rows where issue = 936123457 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Consolidate TypeVars in a single place · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
873312325 https://github.com/pydata/xarray/pull/5569#issuecomment-873312325 https://api.github.com/repos/pydata/xarray/issues/5569 MDEyOklzc3VlQ29tbWVudDg3MzMxMjMyNQ== github-actions[bot] 41898282 2021-07-03T00:13:54Z 2021-08-22T00:04:54Z CONTRIBUTOR

Unit Test Results

6 files  ±0           6 suites  ±0   53m 5s :stopwatch: ±0s 16 224 tests ±0  14 488 :heavy_check_mark: ±0  1 736 :zzz: ±0  0 :x: ±0  90 540 runs  ±0  82 357 :heavy_check_mark: ±0  8 183 :zzz: ±0  0 :x: ±0 

Results for commit 6b59d9a5. ± Comparison against base commit 6b59d9a5.

:recycle: This comment has been updated with latest results.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Consolidate TypeVars in a single place 936123457
873464986 https://github.com/pydata/xarray/pull/5569#issuecomment-873464986 https://api.github.com/repos/pydata/xarray/issues/5569 MDEyOklzc3VlQ29tbWVudDg3MzQ2NDk4Ng== pep8speaks 24736507 2021-07-03T20:22:14Z 2021-08-21T23:10:59Z NONE

Hello @max-sixty! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 8:5: F401 '.common.DataWithCoords' imported but unused

Comment last updated at 2021-08-21 23:10:59 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Consolidate TypeVars in a single place 936123457
903186994 https://github.com/pydata/xarray/pull/5569#issuecomment-903186994 https://api.github.com/repos/pydata/xarray/issues/5569 IC_kwDOAMm_X8411Yoy max-sixty 5635139 2021-08-21T23:10:36Z 2021-08-21T23:10:36Z MEMBER

Thanks a lot @Illviljan ! Much nicer

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Consolidate TypeVars in a single place 936123457
903170577 https://github.com/pydata/xarray/pull/5569#issuecomment-903170577 https://api.github.com/repos/pydata/xarray/issues/5569 IC_kwDOAMm_X8411UoR max-sixty 5635139 2021-08-21T20:08:43Z 2021-08-21T20:08:43Z MEMBER

OK, ready to merge I think

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Consolidate TypeVars in a single place 936123457
873490975 https://github.com/pydata/xarray/pull/5569#issuecomment-873490975 https://api.github.com/repos/pydata/xarray/issues/5569 MDEyOklzc3VlQ29tbWVudDg3MzQ5MDk3NQ== dcherian 2448579 2021-07-04T00:32:23Z 2021-07-04T00:32:23Z MEMBER

T_DataWithCoords seems OK.

How about T_Xarray for all 3?

We should document these eventually under "Xarray internals"

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Consolidate TypeVars in a single place 936123457
873456058 https://github.com/pydata/xarray/pull/5569#issuecomment-873456058 https://api.github.com/repos/pydata/xarray/issues/5569 MDEyOklzc3VlQ29tbWVudDg3MzQ1NjA1OA== max-sixty 5635139 2021-07-03T19:07:58Z 2021-07-03T21:12:24Z MEMBER

I was hoping to come up with a name that described the concept rather than listing the union — e.g.

For Dataset & DataArray - T_DataWithCoords? - T_Data?

For Dataset & DataArray & Variable - XArray? - T_Array? - T_Data?

But not sold on any of them!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Consolidate TypeVars in a single place 936123457
873399931 https://github.com/pydata/xarray/pull/5569#issuecomment-873399931 https://api.github.com/repos/pydata/xarray/issues/5569 MDEyOklzc3VlQ29tbWVudDg3MzM5OTkzMQ== Illviljan 14371165 2021-07-03T12:25:14Z 2021-07-03T12:25:14Z MEMBER

Not sure about names. One idea is reversing T_dsORda, which is more inline with the typical names.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Consolidate TypeVars in a single place 936123457
873372098 https://github.com/pydata/xarray/pull/5569#issuecomment-873372098 https://api.github.com/repos/pydata/xarray/issues/5569 MDEyOklzc3VlQ29tbWVudDg3MzM3MjA5OA== max-sixty 5635139 2021-07-03T08:50:46Z 2021-07-03T08:50:46Z MEMBER

Probably should have a T_DSorDAorVar (Dataset or dataarray or variable) as well, at least used in #5365.

Yes good point. Any ideas for a name?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Consolidate TypeVars in a single place 936123457
873349178 https://github.com/pydata/xarray/pull/5569#issuecomment-873349178 https://api.github.com/repos/pydata/xarray/issues/5569 MDEyOklzc3VlQ29tbWVudDg3MzM0OTE3OA== Illviljan 14371165 2021-07-03T05:25:56Z 2021-07-03T05:25:56Z MEMBER

Probably should have a T_DSorDAorVar (Dataset or dataarray or variable) as well, at least used in #5365.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Consolidate TypeVars in a single place 936123457

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);