issue_comments

Table actions

6 rows where issue = 935317034 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Plots get labels from pint arrays · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
872636422 https://github.com/pydata/xarray/pull/5561#issuecomment-872636422 https://api.github.com/repos/pydata/xarray/issues/5561 MDEyOklzc3VlQ29tbWVudDg3MjYzNjQyMg== github-actions[bot] 41898282 2021-07-02T00:49:09Z 2021-07-21T23:06:21Z CONTRIBUTOR

Unit Test Results

6 files  ±0           6 suites  ±0   53m 47s :stopwatch: ±0s 16 204 tests ±0  14 469 :heavy_check_mark: ±0  1 735 :zzz: ±0  0 :x: ±0  90 420 runs  ±0  82 245 :heavy_check_mark: ±0  8 175 :zzz: ±0  0 :x: ±0 

Results for commit 92cb751a. ± Comparison against base commit 92cb751a.

:recycle: This comment has been updated with latest results.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plots get labels from pint arrays 935317034
872635251 https://github.com/pydata/xarray/pull/5561#issuecomment-872635251 https://api.github.com/repos/pydata/xarray/issues/5561 MDEyOklzc3VlQ29tbWVudDg3MjYzNTI1MQ== pep8speaks 24736507 2021-07-02T00:44:34Z 2021-07-21T22:08:37Z NONE

Hello @TomNicholas! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-07-21 22:08:37 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plots get labels from pint arrays 935317034
881159746 https://github.com/pydata/xarray/pull/5561#issuecomment-881159746 https://api.github.com/repos/pydata/xarray/issues/5561 IC_kwDOAMm_X840hW5C TomNicholas 35968931 2021-07-16T04:04:09Z 2021-07-16T04:04:09Z MEMBER

I think this is ready to merge after #5568 is merged?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plots get labels from pint arrays 935317034
873247522 https://github.com/pydata/xarray/pull/5561#issuecomment-873247522 https://api.github.com/repos/pydata/xarray/issues/5561 MDEyOklzc3VlQ29tbWVudDg3MzI0NzUyMg== TomNicholas 35968931 2021-07-02T20:43:41Z 2021-07-02T20:43:41Z MEMBER

Now builds on top of #5568, but fails because that PR is not complete (does not change .values -> .to_numpy() everywhere needed yet).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plots get labels from pint arrays 935317034
873023077 https://github.com/pydata/xarray/pull/5561#issuecomment-873023077 https://api.github.com/repos/pydata/xarray/issues/5561 MDEyOklzc3VlQ29tbWVudDg3MzAyMzA3Nw== TomNicholas 35968931 2021-07-02T14:02:46Z 2021-07-02T14:18:20Z MEMBER

This should be reimplemented following https://github.com/pydata/xarray/issues/3245#issuecomment-662547659. Really another PR should be opened to implement a to_duck_array method and to_numpy, and this PR rebased on top of that to coerce arrays before plotting.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plots get labels from pint arrays 935317034
872684433 https://github.com/pydata/xarray/pull/5561#issuecomment-872684433 https://api.github.com/repos/pydata/xarray/issues/5561 MDEyOklzc3VlQ29tbWVudDg3MjY4NDQzMw== TomNicholas 35968931 2021-07-02T03:23:41Z 2021-07-02T03:23:41Z MEMBER

I thought this approach was neat but it seems to have broken some of the tests in test_units...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plots get labels from pint arrays 935317034

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);