issue_comments

Table actions

6 rows where issue = 932677183 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Dataset.transpose support for missing_dims · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
875040245 https://github.com/pydata/xarray/issues/5550#issuecomment-875040245 https://api.github.com/repos/pydata/xarray/issues/5550 MDEyOklzc3VlQ29tbWVudDg3NTA0MDI0NQ== headtr1ck 43316012 2021-07-06T19:55:46Z 2021-07-06T19:55:46Z COLLABORATOR

I'm not sure if "copy" is the best way to do it. Since DataArray and Dataset just use Variable.transpose would it not make more sense to implement this functionality into Variable.transpose and just let Data{set,Array}.transpose pass on these arguments?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.transpose support for missing_dims 932677183
873449057 https://github.com/pydata/xarray/issues/5550#issuecomment-873449057 https://api.github.com/repos/pydata/xarray/issues/5550 MDEyOklzc3VlQ29tbWVudDg3MzQ0OTA1Nw== max-sixty 5635139 2021-07-03T18:21:12Z 2021-07-03T18:21:12Z MEMBER

Should Dataset and Variable just copy what's done for DataArray ?

Yes good idea!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.transpose support for missing_dims 932677183
873437513 https://github.com/pydata/xarray/issues/5550#issuecomment-873437513 https://api.github.com/repos/pydata/xarray/issues/5550 MDEyOklzc3VlQ29tbWVudDg3MzQzNzUxMw== gcaria 44147817 2021-07-03T17:00:01Z 2021-07-03T17:00:01Z CONTRIBUTOR

I've noticed that Dataset.transpose calls Variable.transpose, which does not support missing_dims either. It is interesting that both DataArray.transpose and Variable.transpose use utils.infix_dims, but only the former takes advantage of its missing_dims argument.

https://github.com/pydata/xarray/blob/3d1d134278bbf5cabdd176d42787a05eba23730d/xarray/core/dataarray.py#L2250-L2251

https://github.com/pydata/xarray/blob/3d1d134278bbf5cabdd176d42787a05eba23730d/xarray/core/variable.py#L1407

Should Dataset and Variable just copy what's done for DataArray ?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.transpose support for missing_dims 932677183
870832144 https://github.com/pydata/xarray/issues/5550#issuecomment-870832144 https://api.github.com/repos/pydata/xarray/issues/5550 MDEyOklzc3VlQ29tbWVudDg3MDgzMjE0NA== max-sixty 5635139 2021-06-29T18:47:59Z 2021-06-29T18:47:59Z MEMBER

Another solution is ds.transpose(..., "other")

Yes, this works for the majority of cases (and is a really nice interface).

It doesn't cover all cases; e.g. we want a before b and aren't sure whether a or b exist.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.transpose support for missing_dims 932677183
870795977 https://github.com/pydata/xarray/issues/5550#issuecomment-870795977 https://api.github.com/repos/pydata/xarray/issues/5550 MDEyOklzc3VlQ29tbWVudDg3MDc5NTk3Nw== dcherian 2448579 2021-06-29T17:50:33Z 2021-06-29T17:50:33Z MEMBER

Another solution is ds.transpose(..., "other")

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.transpose support for missing_dims 932677183
870787110 https://github.com/pydata/xarray/issues/5550#issuecomment-870787110 https://api.github.com/repos/pydata/xarray/issues/5550 MDEyOklzc3VlQ29tbWVudDg3MDc4NzExMA== max-sixty 5635139 2021-06-29T17:35:37Z 2021-06-29T17:35:37Z MEMBER

Sounds good, we'd take a PR for this — seems abberant to have it for DataArray but not Dataset.

Any objections?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.transpose support for missing_dims 932677183

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);