issue_comments

Table actions

6 rows where issue = 931591247 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • max-sixty · 6 ✖

issue 1

  • Increase default `display_max_rows` · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
873628670 https://github.com/pydata/xarray/issues/5545#issuecomment-873628670 https://api.github.com/repos/pydata/xarray/issues/5545 MDEyOklzc3VlQ29tbWVudDg3MzYyODY3MA== max-sixty 5635139 2021-07-04T17:19:12Z 2021-07-04T17:19:12Z MEMBER

Great, I think we're decided!

@st-bender would you be interested in a PR to kick some of this off? It would be fine to do a subset (e.g. ignoring the limit for the .coords and .data_vars methods). I feel like we could parlay any tension above into a nice contribution. Also fine if not!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Increase default `display_max_rows` 931591247
872473732 https://github.com/pydata/xarray/issues/5545#issuecomment-872473732 https://api.github.com/repos/pydata/xarray/issues/5545 MDEyOklzc3VlQ29tbWVudDg3MjQ3MzczMg== max-sixty 5635139 2021-07-01T18:51:17Z 2021-07-01T18:51:17Z MEMBER

For the Dataset.data_vars and Dataset.coords reprs, it's more obvious that we want to see all of them, so I'd suggest not limiting the maximum of rows displayed

IMO this would be an excellent synthesis of the tradeoffs, +1

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Increase default `display_max_rows` 931591247
871808557 https://github.com/pydata/xarray/issues/5545#issuecomment-871808557 https://api.github.com/repos/pydata/xarray/issues/5545 MDEyOklzc3VlQ29tbWVudDg3MTgwODU1Nw== max-sixty 5635139 2021-07-01T00:12:14Z 2021-07-01T00:12:25Z MEMBER

@st-bender I don't imagine you intend it, but the first two paragraphs of your comment read as abrasive to me. Others should weigh in if they disagree with my assessment.

FWIW I found @Illviljan 's examples very helpful to visualize the various options.

Back to the question: for me, 50 is longer than ideal; it spans my 27" portrait monitor. 20 seems good. We could also have fewer attrs (or coords too?). But as before, no strong view, and I'm rarely dealing with datasets like this

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Increase default `display_max_rows` 931591247
870833694 https://github.com/pydata/xarray/issues/5545#issuecomment-870833694 https://api.github.com/repos/pydata/xarray/issues/5545 MDEyOklzc3VlQ29tbWVudDg3MDgzMzY5NA== max-sixty 5635139 2021-06-29T18:50:40Z 2021-06-29T18:50:40Z MEMBER

If people feel strongly about a default > 12, that seems reasonable. Do people?

I can't speak for other people, but I do, sorry about that.

Also, just to be clear as things can come across in the wrong tone when we're responding quickly on issues — I appreciate you raising the issue and would like to find the right answer — I had meant the original message as a friendly call for opinions!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Increase default `display_max_rows` 931591247
870790648 https://github.com/pydata/xarray/issues/5545#issuecomment-870790648 https://api.github.com/repos/pydata/xarray/issues/5545 MDEyOklzc3VlQ29tbWVudDg3MDc5MDY0OA== max-sixty 5635139 2021-06-29T17:41:35Z 2021-06-29T17:41:35Z MEMBER

Great! I would have vote lower, since 100 cuts off much of a screen, but maybe there's a synthesis of 50 or so?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Increase default `display_max_rows` 931591247
870047867 https://github.com/pydata/xarray/issues/5545#issuecomment-870047867 https://api.github.com/repos/pydata/xarray/issues/5545 MDEyOklzc3VlQ29tbWVudDg3MDA0Nzg2Nw== max-sixty 5635139 2021-06-28T21:15:39Z 2021-06-28T21:15:39Z MEMBER

We need to cut some of the output, given a dataset has arbitrary size — same as numpy arrays / pandas dataframes.

If people feel strongly about a default > 12, that seems reasonable. Do people?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Increase default `display_max_rows` 931591247

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);