issue_comments

Table actions

4 rows where issue = 930191953 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • Can `reset_index` return None? · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
869822366 https://github.com/pydata/xarray/issues/5533#issuecomment-869822366 https://api.github.com/repos/pydata/xarray/issues/5533 MDEyOklzc3VlQ29tbWVudDg2OTgyMjM2Ng== keewis 14808389 2021-06-28T16:19:32Z 2021-06-28T16:19:32Z MEMBER

maybe Optional["DataArray"] is a remnant of the time we had the inplace parameter?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Can `reset_index` return None? 930191953
869808997 https://github.com/pydata/xarray/issues/5533#issuecomment-869808997 https://api.github.com/repos/pydata/xarray/issues/5533 MDEyOklzc3VlQ29tbWVudDg2OTgwODk5Nw== max-sixty 5635139 2021-06-28T16:02:44Z 2021-06-28T16:02:44Z MEMBER

Great @joooeey 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Can `reset_index` return None? 930191953
869595180 https://github.com/pydata/xarray/issues/5533#issuecomment-869595180 https://api.github.com/repos/pydata/xarray/issues/5533 MDEyOklzc3VlQ29tbWVudDg2OTU5NTE4MA== joooeey 28426758 2021-06-28T11:11:51Z 2021-06-28T11:11:51Z CONTRIBUTOR

Well, when I change the return type to "DataArray" in my local project the mypy error I had reported is gone. It also doesn't introduce any new errors. I don't have the xarray dev environment installed on my machine. Next thing I would do would be to make the pull request via the Github web interface and see if the CI passes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Can `reset_index` return None? 930191953
868728024 https://github.com/pydata/xarray/issues/5533#issuecomment-868728024 https://api.github.com/repos/pydata/xarray/issues/5533 MDEyOklzc3VlQ29tbWVudDg2ODcyODAyNA== max-sixty 5635139 2021-06-25T17:39:28Z 2021-06-25T17:39:28Z MEMBER

Good spot @joooeey . I think you're right. Does changing it cause any mypy errors?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Can `reset_index` return None? 930191953

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);